chore: eliminate all ESLint warnings, enforce --max-warnings 0

Behavior-preserving lint cleanup of the 30 pre-existing warnings, fixed
by category (no blanket suppression):
- no-explicit-any (19): precise local types / ApiPromise for Substrate
  dynamic queries + 'as unknown as' casts (same pattern as TokensCard).
- no-console (4): dev-gated (import.meta.env.DEV) / warn; main.tsx prod
  console-suppression kept with a scoped documented disable.
- no-non-null-assertion (4): replaced '!' with explicit guards reusing
  the existing fallback/return paths.
- react-hooks/exhaustive-deps (3): missing dep is 't' (i18n) — adding it
  would re-fire blockchain fetches on language change; kept deps with a
  documented intentional disable.

Tighten the lint gate from --max-warnings 30 to 0 so no new warnings can
land. Verified: tsc 0 errors, eslint --max-warnings 0 clean, vite build ok.
This commit is contained in:
2026-06-14 09:21:12 -07:00
parent 97e5723aa5
commit 2017ae77da
11 changed files with 199 additions and 93 deletions
+2 -4
View File
@@ -424,9 +424,7 @@ export function FundFeesModal({ isOpen, onClose }: Props) {
}`}
/>
<div className="text-sm font-medium">{chain.name}</div>
<div className="text-xs text-muted-foreground">
{t(chain.description as any)}
</div>
<div className="text-xs text-muted-foreground">{t(chain.description)}</div>
</button>
))}
</div>
@@ -505,7 +503,7 @@ export function FundFeesModal({ isOpen, onClose }: Props) {
targetChain === 'asset-hub' ? 'text-blue-400' : 'text-purple-400'
}`}
>
{t('fees.minRecommended', { description: t(selectedChain.description as any) })}
{t('fees.minRecommended', { description: t(selectedChain.description) })}
</p>
</div>
@@ -133,6 +133,10 @@ export function HEZStakingModal({ isOpen, onClose }: HEZStakingModalProps) {
} finally {
setIsLoading(false);
}
// `t` is intentionally omitted: it is only used for error messages and its
// identity changes only on language switch — including it would re-run the
// blockchain fetch (extra RPC calls) on every language change.
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [assetHubApi, address]);
useEffect(() => {
+4
View File
@@ -179,6 +179,10 @@ export function LPStakingModal({ isOpen, onClose }: LPStakingModalProps) {
};
fetchPools();
// `t` is intentionally omitted: it is only used for error messages and its
// identity changes only on language switch — including it would re-run the
// blockchain fetch (extra RPC calls) on every language change.
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [assetHubApi, isOpen, address, selectedPool]);
const formatAmount = (amount: string, decimals: number = 12): string => {
+85 -46
View File
@@ -50,6 +50,26 @@ const formatAssetLocation = (id: number) => {
return { parents: 0, interior: { X2: [{ PalletInstance: 50 }, { GeneralIndex: id }] } };
};
// Minimal shapes for the dynamic @pezkuwi/api results we read here. These
// pallets/runtime-calls are not in the base typings, so we describe just the
// fields actually used and cast via `as unknown as`.
type AccountInfoResult = { data: { free: { toString(): string } } };
type AssetAccountResult = {
isSome: boolean;
unwrap(): { balance: { toString(): string } };
};
type QuoteResult = { isNone: boolean; unwrap(): { toString(): string } };
type AssetConversionCall = {
assetConversionApi: {
quotePriceExactTokensForTokens: (
asset0: ReturnType<typeof formatAssetLocation>,
asset1: ReturnType<typeof formatAssetLocation>,
amount: string,
includeFee: boolean
) => Promise<QuoteResult>;
};
};
export function PoolsModal({ isOpen, onClose }: PoolsModalProps) {
const { assetHubApi, keypair } = useWallet();
const { hapticImpact, hapticNotification } = useTelegram();
@@ -104,17 +124,17 @@ export function PoolsModal({ isOpen, onClose }: PoolsModalProps) {
// Fetch HEZ balance from Asset Hub (native token)
const hezAccount = (await withTimeout(
(assetHubApi.query.system as any).account(keypair.address),
assetHubApi.query.system.account(keypair.address),
10000
)) as any;
)) as unknown as AccountInfoResult;
if (isCancelled) return;
const hezFree = hezAccount.data.free.toString();
setBalances((prev) => ({ ...prev, HEZ: (parseInt(hezFree) / 1e12).toFixed(4) }));
const pezResult = (await withTimeout(
(assetHubApi.query.assets as any).account(1, keypair.address),
assetHubApi.query.assets.account(1, keypair.address),
10000
)) as any;
)) as unknown as AssetAccountResult;
if (isCancelled) return;
if (pezResult.isSome) {
setBalances((prev) => ({
@@ -126,9 +146,9 @@ export function PoolsModal({ isOpen, onClose }: PoolsModalProps) {
}
const usdtResult = (await withTimeout(
(assetHubApi.query.assets as any).account(1000, keypair.address),
assetHubApi.query.assets.account(1000, keypair.address),
10000
)) as any;
)) as unknown as AssetAccountResult;
if (isCancelled) return;
if (usdtResult.isSome) {
setBalances((prev) => ({
@@ -175,7 +195,9 @@ export function PoolsModal({ isOpen, onClose }: PoolsModalProps) {
const oneUnit = BigInt(Math.pow(10, token0.decimals));
const quote = await withTimeout(
(assetHubApi.call as any).assetConversionApi.quotePriceExactTokensForTokens(
(
assetHubApi.call as unknown as AssetConversionCall
).assetConversionApi.quotePriceExactTokensForTokens(
formatAssetLocation(asset0),
formatAssetLocation(asset1),
oneUnit.toString(),
@@ -184,11 +206,8 @@ export function PoolsModal({ isOpen, onClose }: PoolsModalProps) {
10000
);
// eslint-disable-next-line @typescript-eslint/no-explicit-any
if (quote && !(quote as any).isNone) {
price =
Number(BigInt((quote as any).unwrap().toString())) /
Math.pow(10, token1.decimals);
if (quote && !quote.isNone) {
price = Number(BigInt(quote.unwrap().toString())) / Math.pow(10, token1.decimals);
// Estimate reserves from LP supply
const lpAsset = await withTimeout(
@@ -283,6 +302,10 @@ export function PoolsModal({ isOpen, onClose }: PoolsModalProps) {
return () => {
isCancelled = true;
};
// `t` is intentionally omitted: it is only used for error messages and its
// identity changes only on language switch — including it would re-run the
// blockchain fetch (extra RPC calls) on every language change.
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [isOpen, assetHubApi, keypair]);
// Auto-calculate amount1 based on pool price
@@ -326,28 +349,36 @@ export function PoolsModal({ isOpen, onClose }: PoolsModalProps) {
keypair.address
);
// Minimal shape of the signAndSend result fields we read. `asModule`
// is typed from the registry call so it stays type-safe.
type TxResult = {
status: { isFinalized: boolean };
dispatchError?: {
isModule: boolean;
asModule: Parameters<typeof assetHubApi.registry.findMetaError>[0];
toString(): string;
};
};
// Wait for transaction to be finalized
await new Promise<void>((resolve, reject) => {
tx.signAndSend(
keypair,
({ status, dispatchError }: { status: any; dispatchError: any }) => {
if (status.isFinalized) {
if (dispatchError) {
let errorMsg = t('pools.addFailed');
if (dispatchError.isModule) {
const decoded = assetHubApi.registry.findMetaError(dispatchError.asModule);
errorMsg = `${decoded.section}.${decoded.name}: ${decoded.docs.join(' ')}`;
} else if (dispatchError.toString) {
errorMsg = dispatchError.toString();
}
console.error('Add liquidity error:', errorMsg);
reject(new Error(errorMsg));
} else {
resolve();
tx.signAndSend(keypair, ({ status, dispatchError }: TxResult) => {
if (status.isFinalized) {
if (dispatchError) {
let errorMsg = t('pools.addFailed');
if (dispatchError.isModule) {
const decoded = assetHubApi.registry.findMetaError(dispatchError.asModule);
errorMsg = `${decoded.section}.${decoded.name}: ${decoded.docs.join(' ')}`;
} else if (dispatchError.toString) {
errorMsg = dispatchError.toString();
}
console.error('Add liquidity error:', errorMsg);
reject(new Error(errorMsg));
} else {
resolve();
}
}
).catch(reject);
}).catch(reject);
});
setSuccessMessage(
@@ -420,28 +451,36 @@ export function PoolsModal({ isOpen, onClose }: PoolsModalProps) {
keypair.address
);
// Minimal shape of the signAndSend result fields we read. `asModule`
// is typed from the registry call so it stays type-safe.
type TxResult = {
status: { isFinalized: boolean };
dispatchError?: {
isModule: boolean;
asModule: Parameters<typeof assetHubApi.registry.findMetaError>[0];
toString(): string;
};
};
// Wait for transaction to be finalized
await new Promise<void>((resolve, reject) => {
tx.signAndSend(
keypair,
({ status, dispatchError }: { status: any; dispatchError: any }) => {
if (status.isFinalized) {
if (dispatchError) {
let errorMsg = t('pools.removeFailed');
if (dispatchError.isModule) {
const decoded = assetHubApi.registry.findMetaError(dispatchError.asModule);
errorMsg = `${decoded.section}.${decoded.name}: ${decoded.docs.join(' ')}`;
} else if (dispatchError.toString) {
errorMsg = dispatchError.toString();
}
console.error('Remove liquidity error:', errorMsg);
reject(new Error(errorMsg));
} else {
resolve();
tx.signAndSend(keypair, ({ status, dispatchError }: TxResult) => {
if (status.isFinalized) {
if (dispatchError) {
let errorMsg = t('pools.removeFailed');
if (dispatchError.isModule) {
const decoded = assetHubApi.registry.findMetaError(dispatchError.asModule);
errorMsg = `${decoded.section}.${decoded.name}: ${decoded.docs.join(' ')}`;
} else if (dispatchError.toString) {
errorMsg = dispatchError.toString();
}
console.error('Remove liquidity error:', errorMsg);
reject(new Error(errorMsg));
} else {
resolve();
}
}
).catch(reject);
}).catch(reject);
});
setSuccessMessage(t('pools.removedLiquidity', { amount: lpAmountToRemove }));
+59 -21
View File
@@ -74,10 +74,25 @@ export function SwapModal({ isOpen, onClose }: SwapModalProps) {
const hezFree = hezAccount.data.free.toString();
const hezBalance = (parseInt(hezFree) / 1e12).toFixed(4);
// Helper to extract balance from asset query result
const getAssetBalance = (result: any, decimals: number, fractionDigits: number): string => {
// Helper to extract balance from an asset storage query result. The
// shape is the subset of the @pezkuwi/api Option/Codec result we read.
type AssetQueryResult = {
isEmpty: boolean;
isSome?: boolean;
unwrap?: () => { toJSON(): unknown };
toJSON(): unknown;
};
const getAssetBalance = (
result: AssetQueryResult | null,
decimals: number,
fractionDigits: number
): string => {
if (!result || result.isEmpty) return '0'.padEnd(fractionDigits + 2, '0');
const data = result.isSome ? result.unwrap().toJSON() : result.toJSON();
const data = (
result.isSome && result.unwrap ? result.unwrap().toJSON() : result.toJSON()
) as {
balance?: { toString(): string };
} | null;
if (data && data.balance) {
return (parseInt(data.balance.toString()) / Math.pow(10, decimals)).toFixed(
fractionDigits
@@ -155,8 +170,21 @@ export function SwapModal({ isOpen, onClose }: SwapModalProps) {
const decimals2 = getDecimals(asset2);
const oneUnit = BigInt(Math.pow(10, decimals1));
// assetConversionApi is a runtime API not present in the base
// @pezkuwi/api typings; describe just the call we use.
type QuoteResult = { isNone: boolean; unwrap(): { toString(): string } };
type AssetConversionCall = {
assetConversionApi: {
quotePriceExactTokensForTokens: (
asset1: ReturnType<typeof formatAssetLocation>,
asset2: ReturnType<typeof formatAssetLocation>,
amount: string,
includeFee: boolean
) => Promise<QuoteResult>;
};
};
const quote = await (
assetHubApi.call as any
assetHubApi.call as unknown as AssetConversionCall
).assetConversionApi.quotePriceExactTokensForTokens(
formatAssetLocation(asset1),
formatAssetLocation(asset2),
@@ -257,28 +285,38 @@ export function SwapModal({ isOpen, onClose }: SwapModalProps) {
true
);
// Minimal shape of the signAndSend result fields we read (the full
// @pezkuwi/api ISubmittableResult is unavailable because `tx` above is
// produced from an untyped runtime extrinsic).
type SwapDispatchError = {
isModule: boolean;
asModule: Parameters<typeof assetHubApi.registry.findMetaError>[0];
toString(): string;
};
type SwapTxResult = {
status: { isFinalized: boolean };
dispatchError?: SwapDispatchError;
};
// Wait for transaction to be finalized
await new Promise<void>((resolve, reject) => {
tx.signAndSend(
keypair,
({ status, dispatchError }: { status: any; dispatchError: any }) => {
if (status.isFinalized) {
if (dispatchError) {
let errorMsg = t('swap.swapFailed');
if (dispatchError.isModule) {
const decoded = assetHubApi.registry.findMetaError(dispatchError.asModule);
errorMsg = `${decoded.section}.${decoded.name}: ${decoded.docs.join(' ')}`;
} else if (dispatchError.toString) {
errorMsg = dispatchError.toString();
}
console.error('Swap error:', errorMsg);
reject(new Error(errorMsg));
} else {
resolve();
tx.signAndSend(keypair, ({ status, dispatchError }: SwapTxResult) => {
if (status.isFinalized) {
if (dispatchError) {
let errorMsg = t('swap.swapFailed');
if (dispatchError.isModule) {
const decoded = assetHubApi.registry.findMetaError(dispatchError.asModule);
errorMsg = `${decoded.section}.${decoded.name}: ${decoded.docs.join(' ')}`;
} else if (dispatchError.toString) {
errorMsg = dispatchError.toString();
}
console.error('Swap error:', errorMsg);
reject(new Error(errorMsg));
} else {
resolve();
}
}
).catch(reject);
}).catch(reject);
});
setSuccess(true);
+12 -3
View File
@@ -1103,14 +1103,23 @@ function SendTab({ onBack }: { onBack: () => void }) {
let tx;
if (selectedToken === 'HEZ') {
// HEZ transfer on main chain
// HEZ transfer on main chain (api guaranteed by the guard above, but
// narrow again here so TS knows it is non-null in this branch).
if (!api) {
setError(t('send.mainnetApiNotReady'));
return;
}
// eslint-disable-next-line @typescript-eslint/no-explicit-any
tx = (api!.tx.balances as any).transferKeepAlive(toAddress, amountInSmallestUnit);
tx = (api.tx.balances as any).transferKeepAlive(toAddress, amountInSmallestUnit);
} else {
// Asset transfer on Asset Hub (PEZ: asset ID 1, USDT: asset ID 1000)
if (!assetHubApi) {
setError(t('send.assetHubApiNotReady'));
return;
}
const assetId = tokenInfo?.assetId ?? 1;
// eslint-disable-next-line @typescript-eslint/no-explicit-any
tx = (assetHubApi!.tx.assets as any).transfer(assetId, toAddress, amountInSmallestUnit);
tx = (assetHubApi.tx.assets as any).transfer(assetId, toAddress, amountInSmallestUnit);
}
const hash = await tx.signAndSend(keypair);