From 2ed9061d2309590503d74303199f4e42a14da170 Mon Sep 17 00:00:00 2001 From: Maciej Hirsz <1096222+maciejhirsz@users.noreply.github.com> Date: Thu, 11 Oct 2018 15:48:29 +0200 Subject: [PATCH] Don't jump when updating table (#84) --- packages/frontend/src/components/Chain/Chain.tsx | 16 ++++++++++------ packages/frontend/src/components/Node/Row.css | 7 ++++++- 2 files changed, 16 insertions(+), 7 deletions(-) diff --git a/packages/frontend/src/components/Chain/Chain.tsx b/packages/frontend/src/components/Chain/Chain.tsx index d07b4d7..e5b1c85 100644 --- a/packages/frontend/src/components/Chain/Chain.tsx +++ b/packages/frontend/src/components/Chain/Chain.tsx @@ -16,6 +16,8 @@ import settingsIcon from '../../icons/settings.svg'; const MAP_RATIO = 800 / 350; const MAP_HEIGHT_ADJUST = 400 / 350; const HEADER = 148; +const TH_HEIGHT = 35; +const TR_HEIGHT = 31; const ESCAPE_KEY = 27; @@ -70,14 +72,14 @@ export class Chain extends React.Component { } public componentWillMount() { - this.calculateMapDimensions(); + this.onResize(); - window.addEventListener('resize', this.calculateMapDimensions); + window.addEventListener('resize', this.onResize); window.addEventListener('keyup', this.onKeyUp); } public componentWillUnmount() { - window.removeEventListener('resize', this.calculateMapDimensions); + window.removeEventListener('resize', this.onResize); window.removeEventListener('keyup', this.onKeyUp); } @@ -133,8 +135,10 @@ export class Chain extends React.Component { ); } + const height = TH_HEIGHT + nodes.length * TR_HEIGHT; + return ( - +
@@ -144,7 +148,7 @@ export class Chain extends React.Component { }
- +
); } @@ -225,7 +229,7 @@ export class Chain extends React.Component { return { left, top, quarter }; } - private calculateMapDimensions: () => void = () => { + private onResize: () => void = () => { const vp = viewport(); vp.width = Math.max(1350, vp.width); diff --git a/packages/frontend/src/components/Node/Row.css b/packages/frontend/src/components/Node/Row.css index cea2ae4..ea38c84 100644 --- a/packages/frontend/src/components/Node/Row.css +++ b/packages/frontend/src/components/Node/Row.css @@ -5,13 +5,18 @@ .Node-Row-Header th, .Node-Row td { text-align: left; - padding: 0.35em 13px; + padding: 6px 13px; + height: 19px; } .Node-Row td { position: relative; } +.Node-Row-Header th { + height: 23px; +} + .Node-Row .Node-Row-truncate { position: absolute; left: 0;