Address David's comments

This commit is contained in:
James Wilson
2021-08-11 17:23:22 +01:00
parent f26b39ac63
commit 80d6ad916e
6 changed files with 14 additions and 12 deletions
@@ -37,7 +37,7 @@ pub struct Aggregator(Arc<AggregatorInternal>);
struct AggregatorInternal {
/// Shards that connect are each assigned a unique connection ID.
/// This helps us know who to send messages back to (especially in
/// conjunction with the [`LocalId`] that messages will come with).
/// conjunction with the `ShardNodeId` that messages will come with).
shard_conn_id: AtomicU64,
/// Feeds that connect have their own unique connection ID, too.
feed_conn_id: AtomicU64,
+2 -2
View File
@@ -97,7 +97,7 @@ impl Chain {
}
/// Can we add a node? If not, it's because the chain is at its quota.
pub fn can_add_node(&self) -> bool {
pub fn is_overquota(&self) -> bool {
// Dynamically determine the max nodes based on the most common
// label so far, in case it changes to something with a different limit.
self.nodes.len() < max_nodes(self.labels.best())
@@ -105,7 +105,7 @@ impl Chain {
/// Assign a node to this chain.
pub fn add_node(&mut self, node: Node) -> AddNodeResult {
if !self.can_add_node() {
if !self.is_overquota() {
return AddNodeResult::Overquota;
}