Tidy up stale connections. (#406)

* If messageId changes and network ID doesn't, remove 'old' message_id

* Boot nodes/connection when no recent messages received for it

* Separate task needed for soketto recv to avoid cancel-safety issues with new interval

* Wee tidy up

* cargo fmt

* Add some logging around node adding/removing

* Another log info msg

* a bit of tidy up

* bump stale node timeout to 60s

backend/common/src/node_message.rs

@@ -141,6 +141,7 @@ impl Payload {
 #[cfg(test)]
 mod tests {
     use super::*;
+    use arrayvec::ArrayString;
     use bincode::Options;
 
     // Without adding a derive macro and marker trait (and enforcing their use), we don't really
@@ -166,7 +167,7 @@ mod tests {
                     implementation: "foo".into(),
                     version: "foo".into(),
                     validator: None,
-                    network_id: None,
+                    network_id: ArrayString::new(),
                     startup_time: None,
                 },
             }),

backend/common/src/node_types.rs

@@ -17,6 +17,7 @@
 //! These types are partly used in [`crate::node_message`], but also stored and used
 //! more generally through the application.
 
+use arrayvec::ArrayString;
 use serde::ser::{SerializeTuple, Serializer};
 use serde::{Deserialize, Serialize};
 
@@ -25,6 +26,7 @@ use crate::{time, MeanList};
 pub type BlockNumber = u64;
 pub type Timestamp = u64;
 pub use primitive_types::H256 as BlockHash;
+pub type NetworkId = ArrayString<64>;
 
 /// Basic node details.
 #[derive(Serialize, Deserialize, Debug, Clone)]
@@ -34,7 +36,7 @@ pub struct NodeDetails {
     pub implementation: Box<str>,
     pub version: Box<str>,
     pub validator: Option<Box<str>>,
-    pub network_id: Option<Box<str>>,
+    pub network_id: NetworkId,
     pub startup_time: Option<Box<str>>,
 }