From 096d3d61ed93d76d7413c1c9116263aba7505954 Mon Sep 17 00:00:00 2001 From: Satoshi Qazi Muhammed Date: Fri, 10 Jul 2026 07:53:08 -0700 Subject: [PATCH] fix: add missing test-shared dependency for feature-wallet-impl unit tests RealTronTransactionServiceTest needed test-shared's Mockito helpers (whenever/eq/any/argThat), but feature-wallet-impl never declared testImplementation project(':test-shared') - every other module that uses these helpers (feature-account-impl, runtime, common, etc.) already does. Also pin two ambiguous-without-it type inferences (argThat's lambda param, emptyMap's type args) explicitly rather than relying on the dependency fix alone to un-cascade them. --- feature-wallet-impl/build.gradle | 1 + .../tron/transaction/RealTronTransactionServiceTest.kt | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/feature-wallet-impl/build.gradle b/feature-wallet-impl/build.gradle index efa0ef15..e04d2ce2 100644 --- a/feature-wallet-impl/build.gradle +++ b/feature-wallet-impl/build.gradle @@ -71,6 +71,7 @@ dependencies { testImplementation jUnitDep testImplementation mockitoDep + testImplementation project(':test-shared') implementation substrateSdkDep diff --git a/feature-wallet-impl/src/test/java/io/novafoundation/nova/feature_wallet_impl/data/network/tron/transaction/RealTronTransactionServiceTest.kt b/feature-wallet-impl/src/test/java/io/novafoundation/nova/feature_wallet_impl/data/network/tron/transaction/RealTronTransactionServiceTest.kt index b29091ab..1827ce15 100644 --- a/feature-wallet-impl/src/test/java/io/novafoundation/nova/feature_wallet_impl/data/network/tron/transaction/RealTronTransactionServiceTest.kt +++ b/feature-wallet-impl/src/test/java/io/novafoundation/nova/feature_wallet_impl/data/network/tron/transaction/RealTronTransactionServiceTest.kt @@ -133,7 +133,7 @@ class RealTronTransactionServiceTest { // equality in Kotlin, so this must compare contents (contentEquals), not rely on SignerPayloadRaw.equals(). val expectedMessage = rawDataHex.fromHex().sha256() verify(signer).signRaw( - argThat { payload -> + argThat { payload: SignerPayloadRaw -> payload.message.contentEquals(expectedMessage) && payload.accountId.contentEquals(ownerAccountId) && payload.skipMessageHashing @@ -186,7 +186,7 @@ class RealTronTransactionServiceTest { whenever(tronGridApi.createNativeTransfer(eq(baseUrl), eq(ownerHex), eq(recipientHex), eq(amountSun))).thenReturn(unsigned) whenever(tronGridApi.getAccountResource(eq(baseUrl), eq(ownerHex))).thenReturn(TronAccountResourceResponse()) - whenever(tronGridApi.getChainParameters(eq(baseUrl))).thenReturn(emptyMap()) + whenever(tronGridApi.getChainParameters(eq(baseUrl))).thenReturn(emptyMap()) val fee = subject.calculateFee( chain = chain,