From 4537be449602a28cc68dbdafbac2d9e1cf305a9a Mon Sep 17 00:00:00 2001 From: Satoshi Qazi Muhammed Date: Tue, 7 Jul 2026 07:17:43 -0700 Subject: [PATCH] fix: ktlint violations (nested-comment doc text, line length) Doc comments describing "/wallet/*" endpoints were parsed as opening a nested block comment (Kotlin block comments nest, unlike Java/C), leaving the outer KDoc unterminated - not just a lint nit, ktlint flagged these as invalid Kotlin files. Reworded to drop the trailing "*". Also wraps two over-long function signatures/calls. --- .../nova/common/utils/TronAddress.kt | 2 +- .../data/network/tron/TronGridApi.kt | 9 +++++++-- .../network/tron/model/TronTransactionModels.kt | 2 +- .../transaction/RealTronTransactionService.kt | 16 ++++++++++++++-- 4 files changed, 23 insertions(+), 6 deletions(-) diff --git a/common/src/main/java/io/novafoundation/nova/common/utils/TronAddress.kt b/common/src/main/java/io/novafoundation/nova/common/utils/TronAddress.kt index 70c01f05..5a299f6a 100644 --- a/common/src/main/java/io/novafoundation/nova/common/utils/TronAddress.kt +++ b/common/src/main/java/io/novafoundation/nova/common/utils/TronAddress.kt @@ -117,7 +117,7 @@ fun emptyTronAccountId() = ByteArray(20) { 1 } /** * Hex form of a Tron address (`0x41` prefix byte ++ accountId, hex-encoded, no `0x` prefix), e.g. - * `41a614f803b6fd780986a42c78ec9c7f77e6ded13c`. This is the format TronGrid's `/wallet/*` transaction + * `41a614f803b6fd780986a42c78ec9c7f77e6ded13c`. This is the format TronGrid's `/wallet/` transaction * construction/broadcast endpoints expect when called with `"visible": false` (as opposed to the human-facing * Base58Check form used by the `/v1/accounts/{address}` balance endpoint and by [toTronAddress]). */ diff --git a/feature-wallet-impl/src/main/java/io/novafoundation/nova/feature_wallet_impl/data/network/tron/TronGridApi.kt b/feature-wallet-impl/src/main/java/io/novafoundation/nova/feature_wallet_impl/data/network/tron/TronGridApi.kt index e052fb0c..8fa93b1b 100644 --- a/feature-wallet-impl/src/main/java/io/novafoundation/nova/feature_wallet_impl/data/network/tron/TronGridApi.kt +++ b/feature-wallet-impl/src/main/java/io/novafoundation/nova/feature_wallet_impl/data/network/tron/TronGridApi.kt @@ -14,7 +14,7 @@ import java.math.BigInteger /** * Thrown whenever TronGrid reports a failure via an HTTP-200 body (rather than an HTTP error status), which is - * how most `/wallet/*` endpoints signal validation/execution failures, e.g. + * how most `/wallet/` endpoints signal validation/execution failures, e.g. * `{"Error": "... no OwnerAccount."}` from `createtransaction`, or * `{"code": "CONTRACT_VALIDATE_ERROR", "message": ""}` from `broadcasttransaction`. */ @@ -98,7 +98,12 @@ class RealTronGridApi( return rawBalance?.toBigIntegerOrNull() ?: BigInteger.ZERO } - override suspend fun createNativeTransfer(baseUrl: String, ownerHexAddress: String, toHexAddress: String, amountSun: BigInteger): TronUnsignedTransactionResponse { + override suspend fun createNativeTransfer( + baseUrl: String, + ownerHexAddress: String, + toHexAddress: String, + amountSun: BigInteger + ): TronUnsignedTransactionResponse { val request = TronCreateTransactionRequest( ownerAddress = ownerHexAddress, toAddress = toHexAddress, diff --git a/feature-wallet-impl/src/main/java/io/novafoundation/nova/feature_wallet_impl/data/network/tron/model/TronTransactionModels.kt b/feature-wallet-impl/src/main/java/io/novafoundation/nova/feature_wallet_impl/data/network/tron/model/TronTransactionModels.kt index 742d4c83..e1d8bd3c 100644 --- a/feature-wallet-impl/src/main/java/io/novafoundation/nova/feature_wallet_impl/data/network/tron/model/TronTransactionModels.kt +++ b/feature-wallet-impl/src/main/java/io/novafoundation/nova/feature_wallet_impl/data/network/tron/model/TronTransactionModels.kt @@ -4,7 +4,7 @@ import com.google.gson.JsonObject import com.google.gson.annotations.SerializedName /** - * Request/response shapes for TronGrid's transaction-construction/broadcast endpoints (`/wallet/*`). + * Request/response shapes for TronGrid's transaction-construction/broadcast endpoints (`/wallet/`). * * All requests are sent with `"visible": false`, i.e. addresses are hex-encoded (`41` prefix byte ++ 20-byte * accountId, see `toTronHexAddress`) rather than Base58Check. Every shape below was confirmed against diff --git a/feature-wallet-impl/src/main/java/io/novafoundation/nova/feature_wallet_impl/data/network/tron/transaction/RealTronTransactionService.kt b/feature-wallet-impl/src/main/java/io/novafoundation/nova/feature_wallet_impl/data/network/tron/transaction/RealTronTransactionService.kt index 1502d781..2568dc1e 100644 --- a/feature-wallet-impl/src/main/java/io/novafoundation/nova/feature_wallet_impl/data/network/tron/transaction/RealTronTransactionService.kt +++ b/feature-wallet-impl/src/main/java/io/novafoundation/nova/feature_wallet_impl/data/network/tron/transaction/RealTronTransactionService.kt @@ -100,7 +100,13 @@ class RealTronTransactionService( val feeSun = when (intent) { is TronTransactionIntent.Native -> estimateNativeFee(baseUrl, ownerHex, recipient, intent.amountSun) - is TronTransactionIntent.Trc20Transfer -> estimateTrc20FeeFromContractHex(baseUrl, ownerHex, recipient, intent.contractAddress.tronAddressToHexAddress(), intent.amountSun) + is TronTransactionIntent.Trc20Transfer -> estimateTrc20FeeFromContractHex( + baseUrl, + ownerHex, + recipient, + intent.contractAddress.tronAddressToHexAddress(), + intent.amountSun + ) } return TronFee(feeSun, SubmissionOrigin.singleOrigin(ownerAccountId), chain.commissionAsset) @@ -213,7 +219,13 @@ class RealTronTransactionService( return bandwidthShortfall.toBigInteger() * bandwidthPrice } - private suspend fun estimateTrc20FeeFromContractHex(baseUrl: String, ownerHex: String, recipient: AccountId, contractHex: String, amountSun: BigInteger): BigInteger { + private suspend fun estimateTrc20FeeFromContractHex( + baseUrl: String, + ownerHex: String, + recipient: AccountId, + contractHex: String, + amountSun: BigInteger + ): BigInteger { val parameterHex = Trc20TransferAbi.encodeTransferParameters(recipient, amountSun) val dryRun = runCatching {