From 5705d0d5785735b4189204471bb692e36fdf9cff Mon Sep 17 00:00:00 2001 From: Kurdistan Tech Ministry Date: Sun, 1 Mar 2026 22:08:19 +0300 Subject: [PATCH] fix: resolve citizenship bottom sheet not opening on button tap Event(null) was swallowed by EventObserver's ?.let pattern, preventing the CitizenshipBottomSheet from opening when tapping dashboard buttons. Changed to Event("") with ifBlank conversion to preserve null referrer semantics while ensuring the observer callback fires. --- .../presentation/balance/list/BalanceListFragment.kt | 2 +- .../presentation/balance/list/BalanceListViewModel.kt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/feature-assets/src/main/java/io/novafoundation/nova/feature_assets/presentation/balance/list/BalanceListFragment.kt b/feature-assets/src/main/java/io/novafoundation/nova/feature_assets/presentation/balance/list/BalanceListFragment.kt index 8741f42..9e353df 100644 --- a/feature-assets/src/main/java/io/novafoundation/nova/feature_assets/presentation/balance/list/BalanceListFragment.kt +++ b/feature-assets/src/main/java/io/novafoundation/nova/feature_assets/presentation/balance/list/BalanceListFragment.kt @@ -179,7 +179,7 @@ class BalanceListFragment : viewModel.assetViewModeModelFlow.observe { manageAssetsAdapter.setAssetViewModeModel(it) } viewModel.openCitizenshipEvent.observeEvent { referrer -> - CitizenshipBottomSheet.newInstance(referrer).show(childFragmentManager, "citizenship") + CitizenshipBottomSheet.newInstance(referrer.ifBlank { null }).show(childFragmentManager, "citizenship") } viewModel.shareReferralEvent.observeEvent { shareText -> diff --git a/feature-assets/src/main/java/io/novafoundation/nova/feature_assets/presentation/balance/list/BalanceListViewModel.kt b/feature-assets/src/main/java/io/novafoundation/nova/feature_assets/presentation/balance/list/BalanceListViewModel.kt index a8ea579..9a068ed 100644 --- a/feature-assets/src/main/java/io/novafoundation/nova/feature_assets/presentation/balance/list/BalanceListViewModel.kt +++ b/feature-assets/src/main/java/io/novafoundation/nova/feature_assets/presentation/balance/list/BalanceListViewModel.kt @@ -414,7 +414,7 @@ class BalanceListViewModel( } fun basvuruClicked() = launchUnit { - _openCitizenshipEvent.postValue(Event(null)) + _openCitizenshipEvent.postValue(Event("")) } fun shareReferralClicked() = launchUnit {