From af3476982d165f0b4590e0b9f0dc5c6b0f37c3a1 Mon Sep 17 00:00:00 2001 From: Satoshi Qazi Muhammed Date: Mon, 19 Oct 2026 13:14:41 +0400 Subject: [PATCH] fix(deeplink): drop a pending link once it fails for good RootDeepLinkHandler cleared the persisted pending link only on success or when no handler matched. A link that reached a handler and failed with a DeepLinkHandlingException stayed in preferences and was replayed on every launch. Clear it on terminal handling failures in both the fresh and pending paths; this also recovers installs already stuck on update. Other failures keep the link pending for a retry. --- .../presentation/handling/RootDeepLinkHandler.kt | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/feature-deep-linking/src/main/java/io/novafoundation/nova/feature_deep_linking/presentation/handling/RootDeepLinkHandler.kt b/feature-deep-linking/src/main/java/io/novafoundation/nova/feature_deep_linking/presentation/handling/RootDeepLinkHandler.kt index 30f58e1c..7fa5446b 100644 --- a/feature-deep-linking/src/main/java/io/novafoundation/nova/feature_deep_linking/presentation/handling/RootDeepLinkHandler.kt +++ b/feature-deep-linking/src/main/java/io/novafoundation/nova/feature_deep_linking/presentation/handling/RootDeepLinkHandler.kt @@ -2,6 +2,7 @@ package io.novafoundation.nova.feature_deep_linking.presentation.handling import android.net.Uri import io.novafoundation.nova.common.utils.onFailureInstance +import io.novafoundation.nova.feature_deep_linking.presentation.handling.common.DeepLinkHandlingException import kotlinx.coroutines.flow.Flow import kotlinx.coroutines.flow.merge @@ -23,12 +24,18 @@ class RootDeepLinkHandler( return handleDeepLinkInternal(pendingDeepLink) .onSuccess { pendingDeepLinkProvider.clear() } + // A pending link that reaches a handler but fails with a terminal error (malformed/unresolvable), + // or matches no handler, will never succeed on retry - clear it so it does not replay on every launch. + .onFailureInstance { pendingDeepLinkProvider.clear() } + .onFailureInstance { pendingDeepLinkProvider.clear() } } override suspend fun handleDeepLink(data: Uri): Result { pendingDeepLinkProvider.save(data) return handleDeepLinkInternal(data) .onSuccess { pendingDeepLinkProvider.clear() } + // Same as above: a terminal handling failure must not be persisted, otherwise it bricks every launch. + .onFailureInstance { pendingDeepLinkProvider.clear() } .onFailureInstance { pendingDeepLinkProvider.clear() } // If we haven't find any handler - no need to save deep link }