From 74b87d73bdcc68cf496da00737c11dcbef3a64ee Mon Sep 17 00:00:00 2001
From: Jaco Greeff <jacogr@gmail.com>
Date: Wed, 2 Dec 2020 01:19:47 +0100
Subject: [PATCH] Allow host list cache (#26)

* Allow host list cache

* Apply suggestions from code review
---
 packages/phishing/src/index.ts | 20 +++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)

diff --git a/packages/phishing/src/index.ts b/packages/phishing/src/index.ts
index 4d2bec59d..172688a33 100644
--- a/packages/phishing/src/index.ts
+++ b/packages/phishing/src/index.ts
@@ -7,6 +7,11 @@ import fetch from '@polkadot/x-fetch';
 
 // Equivalent to https://raw.githubusercontent.com/polkadot-js/phishing/master/all.json
 const ALL_JSON = 'https://polkadot.js.org/phishing/all.json';
+// 1 hour cache refresh
+const CACHE_TIMEOUT = 1 * 60 * 60 * 1000;
+
+let cacheEnd = 0;
+let cacheList: HostList | null = null;
 
 // gets the host-only part for a host
 function extractHost (path: string): string {
@@ -18,10 +23,19 @@ function extractHost (path: string): string {
 /**
  * Retrieve allow/deny from our list provider
  */
-export async function retrieveHostList (): Promise<HostList> {
+export async function retrieveHostList (allowCached = true): Promise<HostList> {
+  const now = Date.now();
+
+  if (allowCached && cacheList && (now < cacheEnd)) {
+    return cacheList;
+  }
+
   const response = await fetch(ALL_JSON);
   const list = (await response.json()) as HostList;
 
+  cacheEnd = now + CACHE_TIMEOUT;
+  cacheList = list;
+
   return list;
 }
 
@@ -48,9 +62,9 @@ export function checkHost (items: string[], host: string): boolean {
  * Determines if a host is in our deny list. Returns true if host is a problematic one. Returns
  * true if the host provided is in our list of less-than-honest sites.
  */
-export async function checkIfDenied (host: string): Promise<boolean> {
+export async function checkIfDenied (host: string, allowCached = true): Promise<boolean> {
   try {
-    const { deny } = await retrieveHostList();
+    const { deny } = await retrieveHostList(allowCached);
 
     return checkHost(deny, host);
   } catch (error) {