Files
pwap/web/supabase/functions/process-withdraw/index.ts
T
pezkuwichain a8f41cd47f security(p2p): fix withdrawal BOLA, financial RLS exposure, admin dispute escrow
Critical/high audit remediation on the custodial P2P ledger. Auth model is
wallet-based; identity (citizen/visa) is cryptographically bound to a wallet
(People Chain tiki.citizenNft / active p2p_visa), which enables a correct fix.

- Withdrawal BOLA (CRITICAL): process-withdraw now requires a wallet-SIGNED
  challenge; server verifies signature (raw + <Bytes> forms), asserts the signer
  OWNS the identity, consumes a single-use nonce (replay), and derives user_id
  server-side — the client-supplied user_id is ignored. process-withdrawal (batch)
  now requires the service-role key (was: any bearer, incl. public anon key).
  request_withdraw is REVOKEd from anon/authenticated + service-role guarded.
- Financial RLS (HIGH): drop the blanket USING(true) SELECT on user_internal_balances,
  p2p_balance_transactions, p2p_deposit_withdraw_requests; lock p2p_user_payment_methods
  (IBAN PII) + p2p_fiat_disputes UPDATE to service_role; legitimate reads move behind
  scoped SECURITY DEFINER RPCs.
- Deposit integrity: verify-deposit now binds the on-chain sender to identity ownership
  before crediting.
- Admin dispute (CRITICAL fund-logic): DisputeResolutionPanel relabeled trades without
  moving escrow. New admin-signed resolve-dispute function + admin_resolve_dispute RPC
  moves escrow (release/refund/split) atomically with correct accounting (avoids the
  double-count in the legacy resolve_p2p_dispute). Client isAdmin documented as cosmetic.

DEPLOY RUNBOOK (gated; owner runs): 1) apply migrations 20260225/20260725* in order;
2) deploy edge functions process-withdraw, process-withdrawal, verify-deposit, resolve-dispute;
3) set edge secrets PEOPLE_RPC_ENDPOINT (+ optional ADMIN_WALLETS); 4) ship frontend.
Migrations + functions + frontend must go together or the app breaks.

KNOWN RESIDUAL (Round 2 — as severe as the withdrawal BOLA): release_/lock_/refund_
escrow_internal still have PUBLIC EXECUTE and the client calls release_escrow_internal
directly with the anon key from confirmPaymentReceived -> an anon caller can drain any
victim's LOCKED balance. Fix = a wallet-signed confirm-payment edge function (same
pattern as withdrawals) before revoking PUBLIC execute. Not yet fixed.
2026-07-25 00:09:03 -07:00

578 lines
19 KiB
TypeScript

// process-withdraw Edge Function
// Processes withdrawal requests by sending tokens from hot wallet to user wallet
// Uses @pezkuwi/api for Asset Hub blockchain transactions
import { serve } from 'https://deno.land/std@0.168.0/http/server.ts'
import { createClient } from 'npm:@supabase/supabase-js@2'
import { ApiPromise, WsProvider, Keyring } from 'npm:@pezkuwi/api@16.5.36'
import { cryptoWaitReady } from 'npm:@pezkuwi/util-crypto@14.0.25'
import {
identityToUUID,
verifyWalletSignature,
buildWithdrawChallenge,
assertIdentityOwnedByWallet,
consumeNonce,
isFreshTimestamp,
} from '../_shared/identity-auth.ts'
// Allowed origins for CORS
const ALLOWED_ORIGINS = [
'https://app.pezkuwichain.io',
'https://www.pezkuwichain.io',
'https://pezkuwichain.io',
]
function getCorsHeaders(origin: string | null) {
const allowedOrigin = origin && ALLOWED_ORIGINS.includes(origin) ? origin : ALLOWED_ORIGINS[0]
return {
'Access-Control-Allow-Origin': allowedOrigin,
'Access-Control-Allow-Headers': 'authorization, x-client-info, apikey, content-type',
'Access-Control-Allow-Credentials': 'true',
}
}
// Platform hot wallet address
const PLATFORM_WALLET = '5H18ZZBU4LwPYbeEZ1JBGvibCU2edhhM8HNUtFi7GgC36CgS'
// RPC endpoint — defaults to Asset Hub where user balances live
const RPC_ENDPOINT = Deno.env.get('RPC_ENDPOINT') || 'wss://asset-hub-rpc.pezkuwichain.io'
// Token decimals
const DECIMALS = 12
// PEZ asset ID
const PEZ_ASSET_ID = 1
// People Chain endpoint — required to verify citizen NFT ownership server-side
const PEOPLE_RPC_ENDPOINT = Deno.env.get('PEOPLE_RPC_ENDPOINT') || 'wss://people-rpc.pezkuwichain.io'
// Minimum withdrawal amounts
const MIN_WITHDRAW = {
HEZ: 1,
PEZ: 10
}
// Withdrawal fee (in tokens)
const WITHDRAW_FEE = {
HEZ: 0.1,
PEZ: 1
}
interface WithdrawRequest {
requestId?: string // If processing specific request
// ---- Authorization (all required) ----
// The caller proves control of a wallet that OWNS `identityId`. The user_id
// is derived server-side from identityId; a client-supplied user_id is IGNORED.
identityId?: string // Citizen number (#42-<item>-<6d>) or visa (V-XXXXXX)
signerAddress?: string // Wallet that signed the challenge
signature?: string // Signature over the canonical withdraw challenge
timestamp?: number // ms epoch, must be fresh
nonce?: string // single-use, replay-protected
token?: 'HEZ' | 'PEZ'
amount?: number
walletAddress?: string // Withdrawal destination (bound into the signature)
}
// Cache API connection
let apiInstance: ApiPromise | null = null
async function getApi(): Promise<ApiPromise> {
if (apiInstance && apiInstance.isConnected) {
return apiInstance
}
const provider = new WsProvider(RPC_ENDPOINT)
apiInstance = await ApiPromise.create({ provider })
return apiInstance
}
// Cache People Chain connection (citizen NFT ownership verification)
let peopleApiInstance: ApiPromise | null = null
async function getPeopleApi(): Promise<ApiPromise> {
if (peopleApiInstance && peopleApiInstance.isConnected) {
return peopleApiInstance
}
const provider = new WsProvider(PEOPLE_RPC_ENDPOINT)
peopleApiInstance = await ApiPromise.create({ provider })
return peopleApiInstance
}
// Send tokens from hot wallet
async function sendTokens(
api: ApiPromise,
privateKey: string,
toAddress: string,
token: string,
amount: number
): Promise<{ success: boolean; txHash?: string; error?: string }> {
try {
// Initialize crypto
await cryptoWaitReady()
// Create keyring and add hot wallet
const keyring = new Keyring({ type: 'sr25519' })
const hotWallet = keyring.addFromUri(privateKey)
// Verify hot wallet address matches expected
if (hotWallet.address !== PLATFORM_WALLET) {
return {
success: false,
error: 'CRITICAL: Private key does not match platform wallet address!'
}
}
// Convert amount to chain units
const amountBN = BigInt(Math.floor(amount * Math.pow(10, DECIMALS)))
console.log(`Sending ${amount} ${token}: ${hotWallet.address}${toAddress}`)
let tx
if (token === 'HEZ') {
tx = api.tx.balances.transferKeepAlive(toAddress, amountBN)
} else if (token === 'PEZ') {
tx = api.tx.assets.transfer(PEZ_ASSET_ID, toAddress, amountBN)
} else {
return { success: false, error: 'Invalid token' }
}
// Fetch nonce
const accountInfo = await api.query.system.account(hotWallet.address)
const nonce = accountInfo.nonce
// Sign and send transaction
return new Promise((resolve) => {
let txHash: string
tx.signAndSend(hotWallet, { nonce }, (result) => {
txHash = result.txHash.toHex()
if (result.status.isInBlock) {
console.log(`TX in block: ${result.status.asInBlock.toHex()}`)
}
if (result.status.isFinalized) {
// Check for errors
const dispatchError = result.dispatchError
if (dispatchError) {
if (dispatchError.isModule) {
const decoded = api.registry.findMetaError(dispatchError.asModule)
resolve({
success: false,
txHash,
error: `${decoded.section}.${decoded.name}: ${decoded.docs.join(' ')}`
})
} else {
resolve({
success: false,
txHash,
error: dispatchError.toString()
})
}
} else {
resolve({
success: true,
txHash
})
}
}
if (result.isError) {
resolve({
success: false,
txHash,
error: 'Transaction failed'
})
}
}).catch((error) => {
resolve({
success: false,
error: error.message
})
})
// Timeout after 60 seconds
setTimeout(() => {
resolve({
success: false,
txHash,
error: 'Transaction timeout - please check explorer for status'
})
}, 60000)
})
} catch (error) {
console.error('Send tokens error:', error)
return {
success: false,
error: error.message
}
}
}
serve(async (req) => {
const corsHeaders = getCorsHeaders(req.headers.get('Origin'))
// Handle CORS preflight
if (req.method === 'OPTIONS') {
return new Response(null, { headers: corsHeaders })
}
try {
// Get authorization header (transport-level only — NOT the authz boundary).
// Real authorization is the wallet signature + identity-ownership proof below.
const authHeader = req.headers.get('Authorization')
if (!authHeader) {
return new Response(
JSON.stringify({ success: false, error: 'Missing authorization header' }),
{ status: 401, headers: { ...corsHeaders, 'Content-Type': 'application/json' } }
)
}
// Create Supabase clients
const supabaseUrl = Deno.env.get('SUPABASE_URL')!
const supabaseServiceKey = Deno.env.get('SUPABASE_SERVICE_ROLE_KEY')!
// Get hot wallet private key from secrets
const hotWalletPrivateKey = Deno.env.get('PLATFORM_PRIVATE_KEY')
if (!hotWalletPrivateKey) {
console.error('PLATFORM_PRIVATE_KEY not configured')
return new Response(
JSON.stringify({ success: false, error: 'Withdrawal service not configured' }),
{ status: 500, headers: { ...corsHeaders, 'Content-Type': 'application/json' } }
)
}
// Service role client
const serviceClient = createClient(supabaseUrl, supabaseServiceKey)
// Parse request body
const body: WithdrawRequest = await req.json()
const { identityId, signerAddress, signature, timestamp, nonce } = body
let { requestId, token, amount, walletAddress } = body
// =====================================================
// OBJECT-LEVEL AUTHORIZATION (the security boundary)
// =====================================================
// 1) Require a complete signed challenge.
if (!identityId || !signerAddress || !signature || !nonce || typeof timestamp !== 'number') {
return new Response(
JSON.stringify({ success: false, error: 'Missing authorization (identityId, signerAddress, signature, timestamp, nonce required)' }),
{ status: 401, headers: { ...corsHeaders, 'Content-Type': 'application/json' } }
)
}
// 2) The signature covers the full withdrawal intent, incl. destination and
// amount. Determine the values that will be bound into the challenge.
// - Mode 1 (requestId): destination/amount/token come from the stored
// request; the client still signs them (fetched before submit).
// - Mode 2: destination/amount/token come from the (signed) body.
if (!isFreshTimestamp(timestamp)) {
return new Response(
JSON.stringify({ success: false, error: 'Authorization challenge expired. Please retry.' }),
{ status: 401, headers: { ...corsHeaders, 'Content-Type': 'application/json' } }
)
}
// 3) Verify the wallet signature over the canonical challenge. For Mode 1 the
// signed destination/amount/token are supplied alongside requestId and are
// re-checked against the stored request after lookup.
const challenge = buildWithdrawChallenge({
identityId,
token: String(token ?? ''),
amount: Number(amount ?? 0),
destination: String(walletAddress ?? ''),
signerAddress,
timestamp,
nonce,
})
const sigOk = await verifyWalletSignature(challenge, signature, signerAddress)
if (!sigOk) {
return new Response(
JSON.stringify({ success: false, error: 'Invalid signature' }),
{ status: 401, headers: { ...corsHeaders, 'Content-Type': 'application/json' } }
)
}
// 4) Prove the signing wallet OWNS the claimed identity (citizen NFT / visa).
const ownership = await assertIdentityOwnedByWallet(serviceClient, identityId, signerAddress, getPeopleApi)
if (!ownership.ok) {
return new Response(
JSON.stringify({ success: false, error: ownership.error || 'Identity ownership verification failed' }),
{ status: 403, headers: { ...corsHeaders, 'Content-Type': 'application/json' } }
)
}
// 5) Consume the nonce (single-use) to block replay of a captured signature.
const nonceOk = await consumeNonce(serviceClient, nonce, 'withdraw')
if (!nonceOk) {
return new Response(
JSON.stringify({ success: false, error: 'Authorization already used (replay detected)' }),
{ status: 401, headers: { ...corsHeaders, 'Content-Type': 'application/json' } }
)
}
// 6) Derive user_id SERVER-SIDE from the verified identity. Any client-supplied
// user_id is intentionally ignored.
const userId = await identityToUUID(identityId)
// Mode 1: Process existing request by ID
if (requestId) {
const { data: request, error: reqError } = await serviceClient
.from('p2p_deposit_withdraw_requests')
.select('*')
.eq('id', requestId)
.eq('user_id', userId)
.eq('request_type', 'withdraw')
.eq('status', 'pending')
.single()
if (reqError || !request) {
return new Response(
JSON.stringify({ success: false, error: 'Withdrawal request not found or already processed' }),
{ status: 404, headers: { ...corsHeaders, 'Content-Type': 'application/json' } }
)
}
// The signed challenge (built from body values) must match the stored
// request, so the signature authorizes exactly this withdrawal.
const storedAmount = parseFloat(request.amount)
const bodyAmount = Number(amount ?? 0)
if (
String(token ?? '') !== String(request.token) ||
String(walletAddress ?? '') !== String(request.wallet_address) ||
Math.abs(bodyAmount - storedAmount) > 1e-9
) {
return new Response(
JSON.stringify({ success: false, error: 'Signed withdrawal does not match the stored request' }),
{ status: 401, headers: { ...corsHeaders, 'Content-Type': 'application/json' } }
)
}
token = request.token as 'HEZ' | 'PEZ'
amount = storedAmount
walletAddress = request.wallet_address
}
// Mode 2: Create new withdrawal request
else {
if (!token || !amount || !walletAddress) {
return new Response(
JSON.stringify({ success: false, error: 'Missing required fields: token, amount, walletAddress' }),
{ status: 400, headers: { ...corsHeaders, 'Content-Type': 'application/json' } }
)
}
// Validate token
if (!['HEZ', 'PEZ'].includes(token)) {
return new Response(
JSON.stringify({ success: false, error: 'Invalid token. Must be HEZ or PEZ' }),
{ status: 400, headers: { ...corsHeaders, 'Content-Type': 'application/json' } }
)
}
// Validate amount
if (amount < MIN_WITHDRAW[token]) {
return new Response(
JSON.stringify({
success: false,
error: `Minimum withdrawal is ${MIN_WITHDRAW[token]} ${token}`
}),
{ status: 400, headers: { ...corsHeaders, 'Content-Type': 'application/json' } }
)
}
// Validate wallet address format (Substrate SS58)
if (!walletAddress.match(/^5[A-HJ-NP-Za-km-z1-9]{47}$/)) {
return new Response(
JSON.stringify({ success: false, error: 'Invalid wallet address format' }),
{ status: 400, headers: { ...corsHeaders, 'Content-Type': 'application/json' } }
)
}
// Check withdrawal limits first
const { data: limitCheck, error: limitError } = await serviceClient
.rpc('check_withdrawal_limit', {
p_user_id: userId,
p_amount: amount
})
if (limitError || !limitCheck?.allowed) {
return new Response(
JSON.stringify({
success: false,
error: limitCheck?.error || 'Withdrawal limit check failed',
dailyRemaining: limitCheck?.daily_remaining,
monthlyRemaining: limitCheck?.monthly_remaining
}),
{ status: 400, headers: { ...corsHeaders, 'Content-Type': 'application/json' } }
)
}
// Create withdrawal request using database function
const { data: requestResult, error: requestError } = await serviceClient
.rpc('request_withdraw', {
p_user_id: userId,
p_token: token,
p_amount: amount,
p_wallet_address: walletAddress
})
if (requestError || !requestResult?.success) {
return new Response(
JSON.stringify({
success: false,
error: requestResult?.error || requestError?.message || 'Failed to create withdrawal request'
}),
{ status: 400, headers: { ...corsHeaders, 'Content-Type': 'application/json' } }
)
}
requestId = requestResult.request_id
}
// Update request status to processing
await serviceClient
.from('p2p_deposit_withdraw_requests')
.update({ status: 'processing' })
.eq('id', requestId)
// Calculate net amount after fee
const fee = WITHDRAW_FEE[token as 'HEZ' | 'PEZ']
const netAmount = amount! - fee
if (netAmount <= 0) {
await serviceClient
.from('p2p_deposit_withdraw_requests')
.update({
status: 'failed',
error_message: 'Amount too small after fee deduction'
})
.eq('id', requestId)
return new Response(
JSON.stringify({ success: false, error: 'Amount too small after fee deduction' }),
{ status: 400, headers: { ...corsHeaders, 'Content-Type': 'application/json' } }
)
}
console.log(`Processing withdrawal: ${netAmount} ${token} to ${walletAddress}`)
// Connect to blockchain
const api = await getApi()
// Send tokens
const sendResult = await sendTokens(
api,
hotWalletPrivateKey,
walletAddress!,
token!,
netAmount
)
if (!sendResult.success) {
// Refund the locked balance
await serviceClient.rpc('refund_escrow_internal', {
p_user_id: userId,
p_token: token,
p_amount: amount,
p_reference_type: 'withdraw_failed',
p_reference_id: requestId
})
await serviceClient
.from('p2p_deposit_withdraw_requests')
.update({
status: 'failed',
error_message: sendResult.error,
processed_at: new Date().toISOString()
})
.eq('id', requestId)
return new Response(
JSON.stringify({
success: false,
error: sendResult.error || 'Blockchain transaction failed',
txHash: sendResult.txHash
}),
{ status: 500, headers: { ...corsHeaders, 'Content-Type': 'application/json' } }
)
}
// Success! Complete the withdrawal using database function
const { error: completeError } = await serviceClient
.rpc('complete_withdraw', {
p_user_id: userId,
p_token: token,
p_amount: amount,
p_tx_hash: sendResult.txHash,
p_request_id: requestId
})
if (completeError) {
console.error('Failed to complete withdrawal in DB:', completeError)
// TX was sent, but DB update failed - log for manual reconciliation
}
// Update request status
await serviceClient
.from('p2p_deposit_withdraw_requests')
.update({
status: 'completed',
blockchain_tx_hash: sendResult.txHash,
fee_amount: fee,
net_amount: netAmount,
processed_at: new Date().toISOString()
})
.eq('id', requestId)
// Record in withdrawal limits
await serviceClient.rpc('record_withdrawal_limit', {
p_user_id: userId,
p_amount: amount
})
// Log to audit
await serviceClient
.from('p2p_audit_log')
.insert({
user_id: userId,
action: 'withdraw_completed',
entity_type: 'withdraw_request',
entity_id: requestId,
details: {
token,
amount: amount,
net_amount: netAmount,
fee,
wallet_address: walletAddress,
tx_hash: sendResult.txHash
}
})
console.log(`Withdrawal successful: ${sendResult.txHash}`)
return new Response(
JSON.stringify({
success: true,
txHash: sendResult.txHash,
amount: netAmount,
fee,
token,
walletAddress,
message: 'Withdrawal processed successfully'
}),
{ status: 200, headers: { ...corsHeaders, 'Content-Type': 'application/json' } }
)
} catch (error) {
console.error('Edge function error:', error)
return new Response(
JSON.stringify({ success: false, error: 'Internal server error' }),
{ status: 500, headers: { ...corsHeaders, 'Content-Type': 'application/json' } }
)
}
})