mirror of
https://github.com/pezkuwichain/pwap.git
synced 2026-08-12 20:51:37 +00:00
pezkuwichain
6b368d9735
#25 was merged, the approval request went out at 22:14, nobody saw it in time, and at 22:44 the gate cancelled the deploy. Nothing shipped and the only trace was a failed job — the repair migration sat merged but unapplied. Thirty minutes assumes the approver is at their phone when the request lands. A meeting or a night's sleep loses the deploy, and the failure mode is silent unless someone goes looking at Actions. Six hours, with the deadline now stated in the Telegram message itself so the approver knows what they are working against. Job timeout-minutes is set to 370 explicitly: without it the job relies on GitHub's 6h default, which would kill the job at almost exactly the moment the script is still waiting. Worth being honest about the tradeoff: this job holds a pwap-runner slot for the entire wait, so six hours of waiting is six hours that runner cannot do anything else. The right fix is a GitHub Environment with required reviewers — that holds no runner while it waits and allows up to 30 days. This loop is a hand-rolled stand-in for that mechanism; widening it buys time but does not remove the cost.