Files
pwap/.github/workflows
SatoshiQaziMuhammed 39b71a428e ci: make the approval notification able to fail (#35)
The step piped Telegram's reply to /dev/null and then printed 'Approver
notified' unconditionally. A stale token, a wrong chat id, a rejected message —
all of them ended with a green step and an approver who never heard about the
deploy.

That is not hypothetical. On 2026-08-01 run 30710528288 sat in 'waiting' with
the log reading 'Approver notified; deployment waits on the production
environment', and no message had arrived. Nothing in the run said otherwise,
so the first signal was a person asking why the deploy had not moved.

The reply is now checked and a rejection fails the job. Exchange's equivalent
step already did this; pwap's did not, because I wrote it without copying the
pattern that was already there and working.
2026-08-01 19:39:11 -07:00
..