mirror of
https://github.com/pezkuwichain/pwap.git
synced 2026-08-12 05:50:56 +00:00
pezkuwichain
658c99b9bb
A user hit "Could not find the function public.upsert_user_profile(...) in the schema cache" when toggling push notifications. The function was missing, and so were the profiles columns it writes — while schema_migrations listed both 002 and 004 as applied. That pattern turned out to be widespread. Comparing every function declared across the migrations against the live database: 25 are missing, from six migrations all recorded as applied. Their tables exist; only the function bodies are absent. Those files carry "Run this in Supabase SQL Editor" headers, so they were pasted in by hand before apply-migrations.sh existed and a run that stopped partway was still recorded. The runner has skipped them ever since, which is why this stayed invisible until it surfaced as a user-facing error. apply-migrations.sh is not at fault: it wraps each migration and its tracking row in one transaction with ON_ERROR_STOP, so it cannot half-record anything. It inherited a dirty history. Three of the 25 are actually reached by the app, so those are repaired here: apply_for_tier_upgrade MerchantApplication.tsx:213 - tier upgrades were dead check_tier_eligibility called by the above update_p2p_reputation shared/lib/p2p-fiat.ts:803 - reputation never updated This is forward-only repair, not a replay of the source files. Replaying them would abort on their bare CREATE POLICY/INDEX/TRIGGER statements now that the tables exist, and 20241117054602 in particular would overwrite 016's newer cancel_expired_trades with its own older definition. Verified before writing: every table the three functions touch is present, and the whole migration was run inside BEGIN/ROLLBACK against production — three functions created, signatures matching what the callers pass, then rolled back leaving nothing behind. The remaining 22 stay missing on purpose and are listed in known-schema-gaps.txt. Nothing calls them, and several are trigger bodies whose triggers were never created either, so creating them would switch on behaviour that has never run. Also adds a drift check to apply-migrations.sh: after applying, it compares declared functions against the database and flags anything missing that is not in the known-gaps list. Being recorded as applied is not proof of having been applied, and that gap should never again be discovered by a user. The check already earned itself — it caught update_p2p_reputation, which my own first pass had missed to a regex that dropped digits from function names. upsert_user_profile and the profiles notification columns were applied directly to the database from their existing migrations (002, 004), which are fully idempotent; no new migration was needed for them.
42 lines
1.6 KiB
Plaintext
42 lines
1.6 KiB
Plaintext
# Functions declared in migrations that are knowingly absent from the database.
|
|
#
|
|
# Six migrations were recorded as applied but only ran partway: their tables
|
|
# exist, their function bodies never ran. Those files carry "Run this in Supabase
|
|
# SQL Editor" headers — they were pasted in by hand before apply-migrations.sh
|
|
# existed, and a run that stopped midway still got recorded.
|
|
#
|
|
# Nothing in the app calls any function listed here, and several are trigger
|
|
# bodies whose triggers were never created either. Creating them now would switch
|
|
# on behaviour that has never been live (P2P notification triggers, fraud
|
|
# counters, stats updaters) rather than restore something that broke — a product
|
|
# decision, not a repair. They stay listed until someone deliberately enables them.
|
|
#
|
|
# The three the app does reach were repaired in 20260730150000 and are not here:
|
|
# apply_for_tier_upgrade, check_tier_eligibility, update_p2p_reputation
|
|
#
|
|
# Remove a line when you actually create the function. Anything missing that is
|
|
# NOT listed here is new drift and the deploy will say so.
|
|
|
|
approve_tier_application
|
|
calculate_merchant_stats
|
|
calculate_user_risk_score
|
|
cancel_expired_offers
|
|
check_trade_allowed
|
|
decrement_escrow_balance
|
|
generate_referral_code
|
|
get_payment_method_details
|
|
increment_escrow_balance
|
|
log_suspicious_activity
|
|
notify_on_dispute_opened
|
|
notify_on_new_message
|
|
notify_on_new_trade
|
|
notify_on_payment_sent
|
|
notify_on_trade_completed
|
|
reset_daily_fraud_counters
|
|
reset_weekly_fraud_counters
|
|
update_discussion_activity
|
|
update_fraud_indicators_on_trade
|
|
update_merchant_stats_on_trade
|
|
update_rating_stats_trigger
|
|
update_user_rating_stats
|