mirror of
https://github.com/pezkuwichain/pwap.git
synced 2026-08-12 05:50:56 +00:00
pezkuwichain
e18ba679be
The migrations did not describe this database, and could not be made to.
Three findings, in the order they surfaced:
* 25 functions declared across six migrations — all recorded as applied — did
not exist. Their tables did. Two were reached by the app, so merchant tier
upgrades and post-trade reputation updates had been quietly dead. This only
came to light because a user hit "Could not find the function
public.upsert_user_profile(...)" while toggling a notification setting.
* admin_roles has three conflicting definitions across the set and production
matches none of them. 001 says (id, user_id, role, granted_by, granted_at),
COMBINED says (user_id, role, created_at), production has
(id, user_id, role, permissions, created_at, updated_at).
* Applied to an empty database, five migrations fail. The legacy 0NN filenames
sort before the 14-digit timestamps they depend on — "013" < "20241117054600"
— so 013 runs before the migration creating the table it alters. The set
could never have been replayed from scratch.
So it could not be tested, could not rebuild the database, and did not match what
was running. Widening or patching it would have been dressing up a history that
was already fiction.
The baseline is a pg_dump of the live public schema, which matches production by
construction. Privileges are included deliberately: the REVOKEs on
lock_escrow_internal, release_escrow_internal, refund_escrow_internal and
request_withdraw are the 20260725030000 hardening, and dropping them would hand
fund movement back to anon.
Verified step by step against production before committing:
- applies to an empty database cleanly, after three real obstacles were fixed
(extensions live in the `extensions` schema, supabase_admin membership,
platform-level ALTER DEFAULT PRIVILEGES that cannot apply outside Supabase)
- produces 83 tables / 39 functions / 222 indexes / 360 policies — identical
counts to production
- recorded as applied in supabase_migrations without touching the 37 existing
rows, then dry-run confirmed "up to date — no pending migrations", so the
next deploy will not try to replay it over live tables
- drift check now reports "every declared function is present"; the known-gaps
list drops from 22 entries to zero
The old files move to migrations/archive/ rather than being deleted — they are
the only record of why parts of this look the way they do. Their README says
plainly not to run them, and why.
CI now applies migrations to an empty Postgres on every PR. That check was
impossible while the old set was the starting point; it is the thing that stops
this class of drift from being discovered by a user again.
32 lines
1.4 KiB
SQL
32 lines
1.4 KiB
SQL
-- Migration: Drop remaining auth.users FK constraints missed in 20260223120000
|
|
-- These tables still reference auth.users(id) but use wallet-based UUID v5 identity
|
|
|
|
-- 1. p2p_messages.sender_id (blocks chat)
|
|
ALTER TABLE public.p2p_messages
|
|
DROP CONSTRAINT IF EXISTS p2p_messages_sender_id_fkey;
|
|
|
|
-- 2. p2p_notifications.user_id (blocks notifications)
|
|
DO $$ BEGIN
|
|
IF EXISTS (SELECT 1 FROM information_schema.tables WHERE table_schema = 'public' AND table_name = 'p2p_notifications') THEN
|
|
ALTER TABLE public.p2p_notifications DROP CONSTRAINT IF EXISTS p2p_notifications_user_id_fkey;
|
|
END IF;
|
|
END $$;
|
|
|
|
-- 3. p2p_ratings.rater_id, rated_id
|
|
DO $$ BEGIN
|
|
IF EXISTS (SELECT 1 FROM information_schema.tables WHERE table_schema = 'public' AND table_name = 'p2p_ratings') THEN
|
|
ALTER TABLE public.p2p_ratings DROP CONSTRAINT IF EXISTS p2p_ratings_rater_id_fkey;
|
|
ALTER TABLE public.p2p_ratings DROP CONSTRAINT IF EXISTS p2p_ratings_rated_id_fkey;
|
|
END IF;
|
|
END $$;
|
|
|
|
-- 4. p2p_audit_log.user_id
|
|
DO $$ BEGIN
|
|
IF EXISTS (SELECT 1 FROM information_schema.tables WHERE table_schema = 'public' AND table_name = 'p2p_audit_log') THEN
|
|
ALTER TABLE public.p2p_audit_log DROP CONSTRAINT IF EXISTS p2p_audit_log_user_id_fkey;
|
|
END IF;
|
|
END $$;
|
|
|
|
-- 5. Drop old auth.uid() RLS policy on p2p_messages (replaced by open policy)
|
|
DROP POLICY IF EXISTS "p2p_messages_trade_participants" ON public.p2p_messages;
|