Compare commits

...

1 Commits

Author SHA1 Message Date
Omar Abdulla 7802a56d47 Better errors in report 2025-08-26 18:29:28 +03:00
3 changed files with 8 additions and 6 deletions
+6 -4
View File
@@ -79,7 +79,9 @@ impl CachedCompiler {
compiler_version_or_requirement, compiler_version_or_requirement,
) )
.await .await
.inspect_err(|err| compilation_failure_report_callback(None, None, None, err.to_string())) .inspect_err(|err| {
compilation_failure_report_callback(None, None, None, format!("{err:#}"))
})
.context("Failed to obtain compiler executable path")?; .context("Failed to obtain compiler executable path")?;
let compiler_version = <P::Compiler as SolidityCompiler>::new(compiler_path.clone()) let compiler_version = <P::Compiler as SolidityCompiler>::new(compiler_path.clone())
.version() .version()
@@ -89,7 +91,7 @@ impl CachedCompiler {
None, None,
Some(compiler_path.clone()), Some(compiler_path.clone()),
None, None,
err.to_string(), format!("{err:#}"),
) )
}) })
.context("Failed to query compiler version")?; .context("Failed to query compiler version")?;
@@ -232,7 +234,7 @@ async fn compile_contracts<P: Platform>(
Some(compiler_version.clone()), Some(compiler_version.clone()),
Some(compiler_path.as_ref().to_path_buf()), Some(compiler_path.as_ref().to_path_buf()),
None, None,
err.to_string(), format!("{err:#}"),
) )
})? })?
// Adding the deployed libraries to the compiler. // Adding the deployed libraries to the compiler.
@@ -260,7 +262,7 @@ async fn compile_contracts<P: Platform>(
Some(compiler_version.clone()), Some(compiler_version.clone()),
Some(compiler_path.as_ref().to_path_buf()), Some(compiler_path.as_ref().to_path_buf()),
Some(compiler_input.clone()), Some(compiler_input.clone()),
err.to_string(), format!("{err:#}"),
) )
}) })
.context("Failed to configure compiler with sources and options")?; .context("Failed to configure compiler with sources and options")?;
+1 -1
View File
@@ -515,7 +515,7 @@ where
.report_test_succeeded_event(steps_executed) .report_test_succeeded_event(steps_executed)
.expect("Can't fail"), .expect("Can't fail"),
Err(error) => reporter Err(error) => reporter
.report_test_failed_event(error.to_string()) .report_test_failed_event(format!("{error:#}"))
.expect("Can't fail"), .expect("Can't fail"),
} }
} }
+1 -1
View File
@@ -55,7 +55,7 @@ if [ -n "$POLKADOT_SDK_DIR" ]; then
if [ ! -x "$REVIVE_DEV_NODE_BIN" ] || [ ! -x "$ETH_RPC_BIN" ] || [ ! -x "$SUBSTRATE_NODE_BIN" ]; then if [ ! -x "$REVIVE_DEV_NODE_BIN" ] || [ ! -x "$ETH_RPC_BIN" ] || [ ! -x "$SUBSTRATE_NODE_BIN" ]; then
echo -e "${YELLOW}Required binaries not found in release target. Building...${NC}" echo -e "${YELLOW}Required binaries not found in release target. Building...${NC}"
(cd "$POLKADOT_SDK_DIR" && cargo build --release --package revive-dev-node --package eth-rpc --package substrate-node) (cd "$POLKADOT_SDK_DIR" && cargo build --release --package staging-node-cli --package pallet-revive-eth-rpc --package revive-dev-node)
fi fi
for bin in "$REVIVE_DEV_NODE_BIN" "$ETH_RPC_BIN" "$SUBSTRATE_NODE_BIN"; do for bin in "$REVIVE_DEV_NODE_BIN" "$ETH_RPC_BIN" "$SUBSTRATE_NODE_BIN"; do