mirror of
https://github.com/pezkuwichain/revive.git
synced 2026-06-18 03:31:03 +00:00
dedicated functions for logging events adds even more code size on 32bit
Signed-off-by: xermicus <cyrill@parity.io>
This commit is contained in:
@@ -1185,6 +1185,12 @@ where
|
|||||||
/// However, we still protect against this possibility here. Heap index
|
/// However, we still protect against this possibility here. Heap index
|
||||||
/// offsets are generally untrusted and potentially represent valid
|
/// offsets are generally untrusted and potentially represent valid
|
||||||
/// (but wrong) pointers when truncated.
|
/// (but wrong) pointers when truncated.
|
||||||
|
///
|
||||||
|
/// TODO: Splitting up into a dedicated function
|
||||||
|
/// could potentially decrease code sizes (LLVM can still decide to inline).
|
||||||
|
/// However, passing i256 parameters is counter productive and
|
||||||
|
/// I've found that splitting it up actualy increases code size.
|
||||||
|
/// Should be reviewed after 64bit support.
|
||||||
pub fn safe_truncate_int_to_xlen(
|
pub fn safe_truncate_int_to_xlen(
|
||||||
&self,
|
&self,
|
||||||
value: inkwell::values::IntValue<'ctx>,
|
value: inkwell::values::IntValue<'ctx>,
|
||||||
|
|||||||
@@ -10,7 +10,8 @@ use crate::polkavm_const::runtime_api;
|
|||||||
///
|
///
|
||||||
/// TODO: Splitting up into dedicated functions (log0..log4)
|
/// TODO: Splitting up into dedicated functions (log0..log4)
|
||||||
/// could potentially decrease code sizes (LLVM can still decide to inline).
|
/// could potentially decrease code sizes (LLVM can still decide to inline).
|
||||||
/// However, passing many i256 parameters could also hurt a bit.
|
/// However, passing i256 parameters is counter productive and
|
||||||
|
/// I've found that splitting it up actualy increases code size.
|
||||||
/// Should be reviewed after 64bit support.
|
/// Should be reviewed after 64bit support.
|
||||||
pub fn log<'ctx, D>(
|
pub fn log<'ctx, D>(
|
||||||
context: &mut Context<'ctx, D>,
|
context: &mut Context<'ctx, D>,
|
||||||
|
|||||||
Reference in New Issue
Block a user