Separate compilation and linker phases (#376)

Separate between compilation and linker phases to allow deploy time
linking and back-porting era compiler changes to fix #91. Unlinked
contract binaries (caused by missing libraries or missing factory
dependencies in turn) are emitted as raw ELF object.

Few drive by fixes:
- #98
- A compiler panic on missing libraries definitions.
- Fixes some incosistent type forwarding in JSON output (empty string
vs. null object).
- Remove the unused fallback for size optimization setting.
- Remove the broken `--lvm-ir`  mode.
- CI workflow fixes.

---------

Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: xermicus <bigcyrill@hotmail.com>
Signed-off-by: xermicus <cyrill@parity.io>

crates/llvm-context/src/debug_config/ir_type.rs

@@ -1,5 +1,9 @@
 //! The debug IR type.
 
+use revive_common::{
+    EXTENSION_LLVM_SOURCE, EXTENSION_OBJECT, EXTENSION_POLKAVM_ASSEMBLY, EXTENSION_YUL,
+};
+
 /// The debug IR type.
 #[allow(clippy::upper_case_acronyms)]
 #[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
@@ -11,22 +15,17 @@ pub enum IRType {
     /// Whether to dump the assembly code.
     Assembly,
     /// Whether to dump the ELF shared object
-    SO,
-    /// Whether to jump JSON
-    #[cfg(debug_assertions)]
-    JSON,
+    Object,
 }
 
 impl IRType {
     /// Returns the file extension for the specified IR.
     pub fn file_extension(&self) -> &'static str {
         match self {
-            Self::Yul => revive_common::EXTENSION_YUL,
-            Self::LLVM => revive_common::EXTENSION_LLVM_SOURCE,
-            Self::Assembly => revive_common::EXTENSION_POLKAVM_ASSEMBLY,
-            #[cfg(debug_assertions)]
-            Self::JSON => revive_common::EXTENSION_JSON,
-            Self::SO => revive_common::EXTENSION_SHARED_OBJECT,
+            Self::Yul => EXTENSION_YUL,
+            Self::LLVM => EXTENSION_LLVM_SOURCE,
+            Self::Assembly => EXTENSION_POLKAVM_ASSEMBLY,
+            Self::Object => EXTENSION_OBJECT,
         }
     }
 }

crates/llvm-context/src/debug_config/mod.rs

@@ -1,8 +1,5 @@
 //! The debug configuration.
 
-pub mod ir_type;
-
-use std::path::Path;
 use std::path::PathBuf;
 
 use serde::Deserialize;
@@ -10,6 +7,8 @@ use serde::Serialize;
 
 use self::ir_type::IRType;
 
+pub mod ir_type;
+
 /// The debug configuration.
 #[derive(Debug, Default, Serialize, Deserialize, Clone)]
 pub struct DebugConfig {
@@ -18,13 +17,7 @@ pub struct DebugConfig {
     /// Whether debug info should be emitted.
     pub emit_debug_info: bool,
     /// The YUL debug output file path.
-    ///
-    /// Is expected to be configured when running in YUL mode.
     pub contract_path: Option<PathBuf>,
-    /// The YUL input file path.
-    ///
-    /// Is expected to be configured when not running in YUL mode.
-    pub yul_path: Option<PathBuf>,
 }
 
 impl DebugConfig {
@@ -34,29 +27,15 @@ impl DebugConfig {
             output_directory,
             emit_debug_info,
             contract_path: None,
-            yul_path: None,
         }
     }
 
-    /// Set the current YUL path.
-    pub fn set_yul_path(&mut self, yul_path: &Path) {
-        self.yul_path = yul_path.to_path_buf().into();
-    }
-
     /// Set the current contract path.
     pub fn set_contract_path(&mut self, contract_path: &str) {
         self.contract_path = self.yul_source_path(contract_path);
     }
 
-    /// Returns with the following precedence:
-    /// 1. The YUL source path if it was configured.
-    /// 2. The source YUL path from the debug output dir if it was configured.
-    /// 3. `None` if there is no debug output directory.
     pub fn yul_source_path(&self, contract_path: &str) -> Option<PathBuf> {
-        if let Some(path) = self.yul_path.as_ref() {
-            return Some(path.clone());
-        }
-
         self.output_directory.as_ref().map(|output_directory| {
             let mut file_path = output_directory.to_owned();
             let full_file_name = Self::full_file_name(contract_path, None, IRType::Yul);
@@ -128,7 +107,7 @@ impl DebugConfig {
     pub fn dump_object(&self, contract_path: &str, code: &[u8]) -> anyhow::Result<()> {
         if let Some(output_directory) = self.output_directory.as_ref() {
             let mut file_path = output_directory.to_owned();
-            let full_file_name = Self::full_file_name(contract_path, None, IRType::SO);
+            let full_file_name = Self::full_file_name(contract_path, None, IRType::Object);
             file_path.push(full_file_name);
             std::fs::write(file_path, code)?;
         }
@@ -136,24 +115,6 @@ impl DebugConfig {
         Ok(())
     }
 
-    /// Dumps the stage output as a json file suitable for use with --recursive-process
-    #[cfg(debug_assertions)]
-    pub fn dump_stage_output(
-        &self,
-        contract_path: &str,
-        contract_suffix: Option<&str>,
-        stage_json: &Vec<u8>,
-    ) -> anyhow::Result<()> {
-        if let Some(output_directory) = self.output_directory.as_ref() {
-            let mut file_path = output_directory.to_owned();
-            let full_file_name = Self::full_file_name(contract_path, contract_suffix, IRType::JSON);
-            file_path.push(full_file_name);
-            std::fs::write(file_path, stage_json)?;
-        }
-
-        Ok(())
-    }
-
     /// Creates a full file name, given the contract full path, suffix, and extension.
     fn full_file_name(contract_path: &str, suffix: Option<&str>, ir_type: IRType) -> String {
         let mut full_file_name = contract_path.replace('/', "_").replace(':', ".");