mirror of
https://github.com/pezkuwichain/revive.git
synced 2026-11-20 17:46:16 +00:00
Implement resolc end-to-end compilation benchmarks (#406)
# Description Closes [#403](https://github.com/paritytech/revive/issues/403) Adds compilation time benchmarks for resolc end-to-end. The benchmarks can be run from the root via: ```sh make bench-resolc ``` HTML reports will be generated under `target/criterion`, and a summary of the results at [crates/resolc/BENCHMARKS_M4PRO.md](https://github.com/paritytech/revive/blob/lj/compilation-benchmarks/crates/resolc/BENCHMARKS_M4PRO.md) (currently from running on a Mac M4 Pro).
This commit is contained in:
24 files changed
+668
-193
No files matched your search
@@ -2,7 +2,10 @@
|
||||
|
||||
use revive_solc_json_interface::CombinedJsonInvalidSelectorMessage;
|
||||
|
||||
use crate::tests::cli::utils;
|
||||
use crate::cli_utils::{
|
||||
assert_command_failure, assert_equal_exit_codes, execute_resolc, execute_solc,
|
||||
SOLIDITY_CONTRACT_PATH, YUL_CONTRACT_PATH,
|
||||
};
|
||||
|
||||
const JSON_OPTION: &str = "--combined-json";
|
||||
const JSON_ARGUMENTS: &[&str] = &[
|
||||
@@ -21,8 +24,8 @@ const JSON_ARGUMENTS: &[&str] = &[
|
||||
#[test]
|
||||
fn runs_with_valid_json_argument() {
|
||||
for json_argument in JSON_ARGUMENTS {
|
||||
let arguments = &[utils::SOLIDITY_CONTRACT_PATH, JSON_OPTION, json_argument];
|
||||
let resolc_result = utils::execute_resolc(arguments);
|
||||
let arguments = &[SOLIDITY_CONTRACT_PATH, JSON_OPTION, json_argument];
|
||||
let resolc_result = execute_resolc(arguments);
|
||||
assert!(
|
||||
resolc_result.success,
|
||||
"Providing the `{json_argument}` argument should succeed with exit code {}, got {}.\nDetails: {}",
|
||||
@@ -36,86 +39,82 @@ fn runs_with_valid_json_argument() {
|
||||
"Expected the output to contain a `contracts` field when using the `{json_argument}` argument."
|
||||
);
|
||||
|
||||
let solc_result = utils::execute_solc(arguments);
|
||||
utils::assert_equal_exit_codes(&solc_result, &resolc_result);
|
||||
let solc_result = execute_solc(arguments);
|
||||
assert_equal_exit_codes(&solc_result, &resolc_result);
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn fails_with_invalid_json_argument() {
|
||||
let arguments = &[
|
||||
utils::SOLIDITY_CONTRACT_PATH,
|
||||
JSON_OPTION,
|
||||
"invalid-argument",
|
||||
];
|
||||
let resolc_result = utils::execute_resolc(arguments);
|
||||
utils::assert_command_failure(&resolc_result, "Providing an invalid json argument");
|
||||
let arguments = &[SOLIDITY_CONTRACT_PATH, JSON_OPTION, "invalid-argument"];
|
||||
let resolc_result = execute_resolc(arguments);
|
||||
assert_command_failure(&resolc_result, "Providing an invalid json argument");
|
||||
|
||||
assert!(resolc_result
|
||||
.stderr
|
||||
.contains(CombinedJsonInvalidSelectorMessage));
|
||||
|
||||
let solc_result = utils::execute_solc(arguments);
|
||||
utils::assert_equal_exit_codes(&solc_result, &resolc_result);
|
||||
let solc_result = execute_solc(arguments);
|
||||
assert_equal_exit_codes(&solc_result, &resolc_result);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn fails_with_multiple_json_arguments() {
|
||||
let arguments = &[
|
||||
utils::SOLIDITY_CONTRACT_PATH,
|
||||
SOLIDITY_CONTRACT_PATH,
|
||||
JSON_OPTION,
|
||||
JSON_ARGUMENTS[0],
|
||||
JSON_ARGUMENTS[1],
|
||||
];
|
||||
let resolc_result = utils::execute_resolc(arguments);
|
||||
utils::assert_command_failure(&resolc_result, "Providing multiple json arguments");
|
||||
let resolc_result = execute_resolc(arguments);
|
||||
assert_command_failure(&resolc_result, "Providing multiple json arguments");
|
||||
|
||||
assert!(resolc_result
|
||||
.stderr
|
||||
.contains(&format!("Error: \"{}\" is not found.", JSON_ARGUMENTS[1])),);
|
||||
|
||||
let solc_result = utils::execute_solc(arguments);
|
||||
utils::assert_equal_exit_codes(&solc_result, &resolc_result);
|
||||
let solc_result = execute_solc(arguments);
|
||||
assert_equal_exit_codes(&solc_result, &resolc_result);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn fails_without_json_argument() {
|
||||
let arguments = &[utils::SOLIDITY_CONTRACT_PATH, JSON_OPTION];
|
||||
let resolc_result = utils::execute_resolc(arguments);
|
||||
utils::assert_command_failure(&resolc_result, "Omitting a JSON argument");
|
||||
let arguments = &[SOLIDITY_CONTRACT_PATH, JSON_OPTION];
|
||||
let resolc_result = execute_resolc(arguments);
|
||||
assert_command_failure(&resolc_result, "Omitting a JSON argument");
|
||||
|
||||
assert!(resolc_result.stderr.contains(
|
||||
"a value is required for '--combined-json <COMBINED_JSON>' but none was supplied"
|
||||
));
|
||||
|
||||
let solc_result = utils::execute_solc(arguments);
|
||||
utils::assert_equal_exit_codes(&solc_result, &resolc_result);
|
||||
let solc_result = execute_solc(arguments);
|
||||
assert_equal_exit_codes(&solc_result, &resolc_result);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn fails_without_solidity_input_file() {
|
||||
let arguments = &[JSON_OPTION, JSON_ARGUMENTS[0]];
|
||||
let resolc_result = utils::execute_resolc(arguments);
|
||||
utils::assert_command_failure(&resolc_result, "Omitting a Solidity input file");
|
||||
let resolc_result = execute_resolc(arguments);
|
||||
assert_command_failure(&resolc_result, "Omitting a Solidity input file");
|
||||
|
||||
assert!(resolc_result.stderr.contains("Error: No input files given"),);
|
||||
|
||||
let solc_result = utils::execute_solc(arguments);
|
||||
utils::assert_equal_exit_codes(&solc_result, &resolc_result);
|
||||
let solc_result = execute_solc(arguments);
|
||||
assert_equal_exit_codes(&solc_result, &resolc_result);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn fails_with_yul_input_file() {
|
||||
for json_argument in JSON_ARGUMENTS {
|
||||
let arguments = &[utils::YUL_CONTRACT_PATH, JSON_OPTION, json_argument];
|
||||
let resolc_result = utils::execute_resolc(arguments);
|
||||
utils::assert_command_failure(&resolc_result, "Providing a Yul input file");
|
||||
let arguments = &[YUL_CONTRACT_PATH, JSON_OPTION, json_argument];
|
||||
let resolc_result = execute_resolc(arguments);
|
||||
assert_command_failure(&resolc_result, "Providing a Yul input file");
|
||||
|
||||
assert!(resolc_result
|
||||
.stderr
|
||||
.contains("Error: Expected identifier but got 'StringLiteral'"));
|
||||
|
||||
let solc_result = utils::execute_solc(arguments);
|
||||
utils::assert_equal_exit_codes(&solc_result, &resolc_result);
|
||||
let solc_result = execute_solc(arguments);
|
||||
assert_equal_exit_codes(&solc_result, &resolc_result);
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user