From e7c761c0688fd08eb11186b56295b52551f3bde4 Mon Sep 17 00:00:00 2001
From: xermicus <cyrill@parity.io>
Date: Fri, 10 Jul 2026 10:43:36 +0200
Subject: [PATCH] new clippies (#571)

Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
---
 crates/common/src/object.rs                 | 2 +-
 crates/llvm-builder/src/revive_llvm/main.rs | 4 ++--
 crates/newyork/src/simplify.rs              | 5 ++---
 3 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/crates/common/src/object.rs b/crates/common/src/object.rs
index 9ba0eed..5fdb5d8 100644
--- a/crates/common/src/object.rs
+++ b/crates/common/src/object.rs
@@ -17,7 +17,7 @@ pub enum ObjectFormat {
 }
 
 impl ObjectFormat {
-    pub const PVM_MAGIC: [u8; 4] = [b'P', b'V', b'M', b'\0'];
+    pub const PVM_MAGIC: [u8; 4] = *b"PVM\0";
     pub const ELF_MAGIC: [u8; 4] = [0x7f, b'E', b'L', b'F'];
 }
 
diff --git a/crates/llvm-builder/src/revive_llvm/main.rs b/crates/llvm-builder/src/revive_llvm/main.rs
index 224bbba..ccff702 100644
--- a/crates/llvm-builder/src/revive_llvm/main.rs
+++ b/crates/llvm-builder/src/revive_llvm/main.rs
@@ -60,7 +60,7 @@ fn main_inner() -> anyhow::Result<()> {
                 .map_err(|platform| anyhow::anyhow!("Unknown platform `{}`", platform))?;
             targets.insert(revive_llvm_builder::Platform::PolkaVM);
 
-            log::info!("build targets: {:?}", &targets);
+            log::info!("build targets: {:?}", targets);
 
             let extra_args_unescaped: Vec<String> = extra_args
                 .iter()
@@ -91,7 +91,7 @@ fn main_inner() -> anyhow::Result<()> {
                 .map_err(|project| anyhow::anyhow!("Unknown LLVM project `{}`", project))?;
             projects.insert(revive_llvm_builder::llvm_project::LLVMProject::LLD);
 
-            log::info!("build projects: {:?}", &projects);
+            log::info!("build projects: {:?}", projects);
 
             revive_llvm_builder::build(
                 build_type,
diff --git a/crates/newyork/src/simplify.rs b/crates/newyork/src/simplify.rs
index 63d0850..10e4ab3 100644
--- a/crates/newyork/src/simplify.rs
+++ b/crates/newyork/src/simplify.rs
@@ -970,10 +970,9 @@ impl Simplifier {
                 let (exponent, value) =
                     if let Some(exponent) = rhs_value.as_ref().and_then(log2_exact) {
                         (exponent, lhs)
-                    } else if let Some(exponent) = lhs_value.as_ref().and_then(log2_exact) {
-                        (exponent, rhs)
                     } else {
-                        return None;
+                        let exponent = lhs_value.as_ref().and_then(log2_exact)?;
+                        (exponent, rhs)
                     };
                 in_range(exponent).then(|| {
                     self.emit_strength_reduce(