Existing test coverage didn't catch a signed remainder overflow semantics edge case behavior where at least one the operators is being constant folded by LLVM instead of solc. This PR fixes the SREM translation bug and adds missing test coverage for division ops with constants. Closes #524 --------- Signed-off-by: xermicus <cyrill@parity.io>
14 KiB
Changelog
Unreleased
- Supported
polkadot-sdkrev:2603
Changed
- Updated
LLVMfrom21.1.8to LLVM22.1.4
Added
- Support for solc v0.8.35.
Fixed
- A constant folding bug causing incorrect translation of a signed remainder edge case. The affected pattern (Solidity % or Yul smod):
- SREM over the two constant operands
type(int256).minand-1. - At least one of the two constants needs folding (i.e. not just
type(int256).min % -1), and is written specifically such that solc doesn't fold but LLVM does, resulting in UB (signed-overflow).
- SREM over the two constant operands
v1.1.0
Supported polkadot-sdk rev: 2603
Added
- Support for solc v0.8.34.
- Inherit
STDERRin recursive processes, allowing debug logs to be printed to the console #485
Fixed
- npm package: The
--binCLI flag was not producing bytecode because theoutputSelectionwas not updated to explicitly requested it. - Yul mode now properly exits when solc reports validation errors (e.g., invalid hex literals), matching
--standard-jsonbehavior. #477 - Fixed a bytecode divergence (yet functionally equivalent) between the resolc Linux/macOS builds and the Windows build for Solidity contracts containing a value multiplied by itself (e.g. via explicit squaring or exponentiation), manifesting primarily when using optimization level
-O0. #500 - Recursive processes use the current executable by default #484
- Work around some LLVM indeterminism problem #500
Changed
- Updated
LLVMfrom18.1.8to LLVM21.1.8 - Updated
muslto1.2.5 - Updated
inkwellto0.8.0 - Updated
polkavm-*to0.31.0 - Updated
EMSDKto5.0.0 - Switched building LLVM for Windows from Visual Studio to MSVC-compatible Clang (clang-cl) and Ninja. #497
- Append optnone and noinline for -O0 optlevel #502
v1.0.0
Supported polkadot-sdk rev: unstable2507
Changed
- Removed the
revive-explorerutility.
Fixed
- OOB access in
calldataloadandcalldatacopyshould always produce zero values instead of consuming all gas. - The superfluous byte swap in
linkersymbol. - Compiling with
--standard-jsonnow compiles to PolkaVM bytecode only for the contracts explicitly requested in theoutputSelection, significantly improving compilation time when none or a subset of files requests bytecode. PR#461 - Compiling with
--standard-jsonnow outputs only the explicitly requested output (e.g.evm.assembly,evm.bytecode,ast, etc.). PR#461
// Example:
{
"settings": {
// ...
"outputSelection": {
"path/to/my/file1.sol": {
// Contracts in this file will generate bytecode.
// Only these fields of the JSON output selection will be in the `contracts` output.
"*": ["abi", "evm.methodIdentifiers", "metadata", "evm.bytecode"],
// Only this field of the JSON output selection will be in the `sources` output.
"": ["ast"]
},
"path/to/my/file2.sol": {
// No contracts in this file will generate bytecode.
"*": ["abi", "evm.methodIdentifiers", "metadata"],
// No `ast` will be in the `sources` output (only the automatically added `id`,
// similar to solc as this is not a configurable output selection).
"": []
},
}
}
}
v0.6.0
This is a development pre-release.
Supported polkadot-sdk rev: unstable2507
Added
- The comprehensive revive compiler book documentation page: https://paritytech.github.io/revive/
- Support for solc v0.8.33.
- Support for the
clzYul builtin.
Changed
- Instruct the LLVM backend and linker to
--relax(may lead to smaller contract code size). - Standard JSON mode: Don't forward EVM bytecode related output selections to solc.
- The supported
polkadot-sdkrelease isunstable2507. - The
INVALIDopcode and OOB memory accesses now consume all remaining gas. - Emit the
call_evmanddelegate_call_evmsyscalls for contract calls. - The
revive-runnercan execute arbitrarily large contract blobs. - Set the default PolkaVM stack and heap size values to 128KB.
Fixed:
- The missing
STOPinstruction at the end ofcodeblocks. - The missing bounds check in the internal sbrk implementation.
- The call gas is no longer ignored.
- The
settings.polkavm.memoryConfigobject and its fields are now in camelCase.
v0.5.0
This is a development pre-release.
Supported polkadot-sdk rev: 2509.0.0
Added
- Support for
SELFDESTRUCT.
Changed
- Emulated EVM heap memory accesses of zero length are never out of bounds.
- Switched to newer and cheaper storage syscalls (omits reads and writes of
0values).
Fixed
- Introduced a workaround avoiding compiler crashes caused by a bug in LLVM affecting
SDIV. - An off-by-one bug affecting
SDIVoverflow semantics.
v0.4.1
This is a development pre-release.
Supported polkadot-sdk rev: 2503.0.1
Changed
- The
astoutput is no longer pruned in standard JSON mode (required for foundry). - Support
standard_json.output_selectionto also look at per file settings.
v0.4.0
This is a development pre-release.
Supported polkadot-sdk rev: 2503.0.1
Changed
- Remove the broken
--llvm-irmode. - Remove the unused fallback for size optimization setting.
- Unlinked contract binaries are emitted as raw ELF objects.
Added
- Line debug information per YUL builtin and for
ifstatements. - Column numbers in debug information.
- Support for the YUL optimizer details in the standard json input definition.
- The
revive-explorercompiler utility. revive-yul: The AST visitor interface.- The
--linkdeploy time linking mode.
Fixed
- The debug info source file matches the YUL path in
--debug-output-dir, allowing tools to display the source line. - Incosistent type forwarding in JSON output (empty string vs. null object).
- The solc automatic import resolution.
- Compiler panic on missing libraries definition.
v0.3.0
This is a development pre-release.
Supported polkadot-sdk rev: 2503.0.1
Fixed
- llvm-context: Bugfix the SAR YUL builtin translation.
- runtime-api: Add the missing
memsetbuiltin. - npm package: Bugfix the exports field defined in the
package.json.
v0.2.0
This is a development pre-release.
Supported polkadot-sdk rev: 2503.0.1
Changed
- Removed the license printer from the
resolcbinary. - EVM bytecode is no longer requested from solc (except in test utils) leading to less compilation work in the pipeline.
Fixed
- solc-json-interface: Serializing of any custom key in the JSON input is only skipped if not provided.
- npm package resolution no longer fails with an 'ERR_PACKAGE_PATH_NOT_EXPORTED' error for packages defining exports fields in the
package.json.
v0.1.0
This is a development pre-release.
Supported polkadot-sdk rev: 2503.0.1
Added
- Add the PolkaVM heap size, stack size and debug info CLI compiler options to the standard JSON settings. This makes the standard JSON input succint for reproducible builds.
Changed
- Supported
polkadot-sdkversion is now2503.0.1 - The
emsdkversion is now4.0.9
Fixed
v0.1.0-dev.16
This is a development pre-release.
Supported polkadot-sdk rev:c29e72a8628835e34deb6aa7db9a78a2e4eabcee
Added
- Move the npm package from paritytech/js-revive, into this repo. The package
@parity/resolcwill be deployed to npm for each release. - Support for solc v0.8.30
Changed
- By default, heavy size optimizations are applied.
Fixed
- @parity/resolc: The solc dependency package is constrained to the latest supported version, preventing breaking the package ever time a new solc package was released.
- The resolc npm package no longer ignores the optimizer settings
v0.1.0-dev.14
This is a development pre-release.
Supported polkadot-sdk rev:c29e72a8628835e34deb6aa7db9a78a2e4eabcee
Added
- The
revive-runnerhelper utility binary which helps to run contracts locally without a blockchain node. - Allow configuration of the EVM heap memory size and stack size via CLI flags and JSON input settings.
Changed
- The default PVM stack memory size was increased from 16kb to 32kb.
Fixed
- Constructors avoid storing zero sized immutable data on exit.
v0.1.0-dev.13
This is a development pre-release.
Supported polkadot-sdk rev:c29e72a8628835e34deb6aa7db9a78a2e4eabcee
Added
- Support for solc v0.8.29
- Decouples the solc JSON-input-output type definitions from the Solidity fronted and expose them via a dedicated crate.
--supported-solc-versionsforresolcbinary to return asemverrange of supportedsolcversions.- Support for passing LLVM command line options via the prcoess input or providing one or more
--llvm-arg='..'resolc CLI flag. This allows more fine-grained control over the LLVM backend configuration.
Changed
- Storage keys and values are big endian. This was a pre-mature optimization because for the contract itself it this is a no-op and thus not observable. However we should consider the storage layout as part of the contract ABI. The endianness of transient storage values are still kept as-is.
- Running
resolcusing webkit is no longer supported.
Fixed
- A missing byte swap for the create2 salt value.
v0.1.0-dev.12
This is a development pre-release.
Supported polkadot-sdk rev: 21f6f0705e53c15aa2b8a5706b208200447774a9
Added
- Per file output selection for
--standard-jsonmode. - The
iroutput selection option for--standard-jsonmode.
Changed
- Improved code size: Large contracts compile to smaller code blobs when enabling aggressive size optimizations (
-Oz).
Fixed
v0.1.0-dev.11
This is a development pre-release.
Supported polkadot-sdk rev: 274a781e8ca1a9432c7ec87593bd93214abbff50
Added
Changed
Fixed
- A bug causing incorrect loads from the emulated EVM linear memory.
- A missing integer truncate after switching to 64bit.
v0.1.0-dev.10
This is a development pre-release.
Supported polkadot-sdk rev: 274a781e8ca1a9432c7ec87593bd93214abbff50
Added
- Support for the
coinbaseopcode. - The resolc web JS version.
Changed
- Missing the
--overwriteflag emits an error instead of a warning. - The
resolcexecutable prints the help by default. - Removed support for legacy EVM assembly (EVMLA) translation.
- integration: identify cached code blobs on source code to fix potential confusions.
- Setting base, include or allow paths in emscripten is now a hard error.
- Employ a heuristic to detect
address.transferandaddress.sendcalls. If detected, the re-entrant call flag is not set and 0 deposit limit is endowed.
Fixed
- Solidity: Add the solc
--librariesfiles to sources. - A data race in tests.
- Fix
broken pipeerrors. - llvm-builder: Allow warnings.
- solidity: Fix the custom compiler warning messages.
v0.1.0-dev.9
This is a development pre-release.
Added
Changed
- Syscalls with more than 6 arguments now pack them into registers.
Fixed
- Remove reloading of the resolc.js file (fix issue with relative path in web worker)
v0.1.0-dev.8
This is a development pre-release.
Added
- The
revive-llvm-buildercrate with therevive-llvmhelper utility for streamlined management of the LLVM framework dependency. - Initial support for running
resolcin the browser.
Changed
- Suported contracts runtime is polkadot-sdk git version
d62a90c8c729acd98c7e9a5cab9803b8b211ffc5. - The minimum supported Rust version is
1.81.0. - Error out early instead of invoking
solcwith invalid base or include path flags.
Fixed
- Decouple the LLVM target dependency from the LLVM host dependency.
- Do not error out if no files and no errors were produced. This aligns resolc closer to solc.
- Fixes input normalization in the Wasm version.
v0.1.0-dev.7
This is a development pre-release.
Added
- Implement the
GASPRICEopcode. - Implement the
BASEFEEopcode. - Implement the
GASLIMITopcode.
Changed
- The
GASopcode now returns the remainingref_time. - Contracts can now be supplied call data input of arbitrary size.
- Some syscalls now return the value in a register, slightly improving emitted contract code.
- Calls forward maximum weight limits instead of 0, anticipating a change in polkadot-sdk where weight limits of 0 no longer interprets as uncapped limit.
Fixed
- A linker bug which was preventing certain contracts from linking with the PVM linker.
- JS: Fix encoding conversion from JS string (UTF-16) to UTF-8.
- The git commit hash slug is always displayed in the version string.
v0.1.0-dev.6
This is a development pre-release.
Added
- Implement the
BLOCKHASHopcode. - Implement delegate calls.
- Implement the
GASPRICEopcode. Currently hard-coded to return1. - The ELF shared object contract artifact is dumped into the debug output directory.
- Initial support for emitting debug info (opt in via the
-gflag)
Changed
- resolc now emits 64bit PolkaVM blobs, reducing contract code size and execution time.
- The RISC-V bit-manipulation target feature (
zbb) is enabled.
Fixed
- Compilation to Wasm (for usage in node and web browsers)
v0.1.0-dev.5
This is development pre-release.
Added
- Implement the
CODESIZEandEXTCODESIZEopcodes.
Changed
- Include the full revive version in the contract metadata.
Fixed
v0.1.0-dev-4
This is development pre-release.
Added
- Support the
ORIGINopcode.
Changed
- Update polkavm to
v0.14.0. - Enable the
a,fast-unaligned-accessandxtheadcondmovLLVM target features, decreasing the code size for some contracts.