Split test newtype_enum into four tests for each variant

(review this commit with "ignore whitespace changes" option on)
This commit is contained in:
Mingun
2024-08-17 14:53:41 +05:00
parent 171c6da57a
commit 0093f74cfe
2 changed files with 80 additions and 46 deletions
+16
View File
@@ -2153,6 +2153,10 @@ mod content {
fn unit_variant(self) -> Result<(), E> { fn unit_variant(self) -> Result<(), E> {
match self.value { match self.value {
Some(value) => de::Deserialize::deserialize(ContentRefDeserializer::new(value)), Some(value) => de::Deserialize::deserialize(ContentRefDeserializer::new(value)),
// Covered by tests/test_annotations.rs
// test_partially_untagged_adjacently_tagged_enum
// Covered by tests/test_enum_untagged.rs
// newtype_enum::unit
None => Ok(()), None => Ok(()),
} }
} }
@@ -2162,6 +2166,11 @@ mod content {
T: de::DeserializeSeed<'de>, T: de::DeserializeSeed<'de>,
{ {
match self.value { match self.value {
// Covered by tests/test_annotations.rs
// test_partially_untagged_enum_desugared
// test_partially_untagged_enum_generic
// Covered by tests/test_enum_untagged.rs
// newtype_enum::newtype
Some(value) => seed.deserialize(ContentRefDeserializer::new(value)), Some(value) => seed.deserialize(ContentRefDeserializer::new(value)),
None => Err(de::Error::invalid_type( None => Err(de::Error::invalid_type(
de::Unexpected::UnitVariant, de::Unexpected::UnitVariant,
@@ -2175,6 +2184,11 @@ mod content {
V: de::Visitor<'de>, V: de::Visitor<'de>,
{ {
match self.value { match self.value {
// Covered by tests/test_annotations.rs
// test_partially_untagged_enum
// test_partially_untagged_enum_desugared
// Covered by tests/test_enum_untagged.rs
// newtype_enum::tuple2
Some(Content::Seq(v)) => { Some(Content::Seq(v)) => {
de::Deserializer::deserialize_any(SeqRefDeserializer::new(v), visitor) de::Deserializer::deserialize_any(SeqRefDeserializer::new(v), visitor)
} }
@@ -2198,6 +2212,8 @@ mod content {
V: de::Visitor<'de>, V: de::Visitor<'de>,
{ {
match self.value { match self.value {
// Covered by tests/test_enum_untagged.rs
// newtype_enum::struct_from_map
Some(Content::Map(v)) => { Some(Content::Map(v)) => {
de::Deserializer::deserialize_any(MapRefDeserializer::new(v), visitor) de::Deserializer::deserialize_any(MapRefDeserializer::new(v), visitor)
} }
+23 -5
View File
@@ -134,8 +134,9 @@ fn newtype_struct() {
assert_de_tokens(&value, &[Token::U32(5)]); assert_de_tokens(&value, &[Token::U32(5)]);
} }
#[test] mod newtype_enum {
fn newtype_enum() { use super::*;
#[derive(Debug, PartialEq, Serialize, Deserialize)] #[derive(Debug, PartialEq, Serialize, Deserialize)]
#[serde(untagged)] #[serde(untagged)]
enum Outer { enum Outer {
@@ -146,10 +147,13 @@ fn newtype_enum() {
enum Inner { enum Inner {
Unit, Unit,
Newtype(u8), Newtype(u8),
Tuple(u8, u8), Tuple2(u8, u8),
Struct { f: u8 }, Struct { f: u8 },
} }
// Reaches crate::private::de::content::VariantRefDeserializer::unit_variant
#[test]
fn unit() {
assert_tokens( assert_tokens(
&Outer::Inner(Inner::Unit), &Outer::Inner(Inner::Unit),
&[Token::UnitVariant { &[Token::UnitVariant {
@@ -157,7 +161,11 @@ fn newtype_enum() {
variant: "Unit", variant: "Unit",
}], }],
); );
}
// Reaches crate::private::de::content::VariantRefDeserializer::newtype_variant_seed
#[test]
fn newtype() {
assert_tokens( assert_tokens(
&Outer::Inner(Inner::Newtype(1)), &Outer::Inner(Inner::Newtype(1)),
&[ &[
@@ -168,13 +176,17 @@ fn newtype_enum() {
Token::U8(1), Token::U8(1),
], ],
); );
}
// Reaches crate::private::de::content::VariantRefDeserializer::tuple_variant
#[test]
fn tuple2() {
assert_tokens( assert_tokens(
&Outer::Inner(Inner::Tuple(1, 1)), &Outer::Inner(Inner::Tuple2(1, 1)),
&[ &[
Token::TupleVariant { Token::TupleVariant {
name: "Inner", name: "Inner",
variant: "Tuple", variant: "Tuple2",
len: 2, len: 2,
}, },
Token::U8(1), Token::U8(1),
@@ -182,7 +194,12 @@ fn newtype_enum() {
Token::TupleVariantEnd, Token::TupleVariantEnd,
], ],
); );
}
// Reaches crate::private::de::content::VariantRefDeserializer::struct_variant
// Content::Map case
#[test]
fn struct_from_map() {
assert_tokens( assert_tokens(
&Outer::Inner(Inner::Struct { f: 1 }), &Outer::Inner(Inner::Struct { f: 1 }),
&[ &[
@@ -197,6 +214,7 @@ fn newtype_enum() {
], ],
); );
} }
}
// Reaches crate::private::de::content::ContentRefDeserializer::deserialize_option // Reaches crate::private::de::content::ContentRefDeserializer::deserialize_option
mod with_optional_field { mod with_optional_field {