From 1fcda0ebdb2cfa050df42fded93ba07c14e4b683 Mon Sep 17 00:00:00 2001
From: David Tolnay <dtolnay@gmail.com>
Date: Thu, 4 Nov 2021 20:21:43 -0700
Subject: [PATCH] Enable pedantic lints on test suite in CI

---
 .github/workflows/ci.yml             | 4 ++--
 test_suite/tests/test_annotations.rs | 1 +
 test_suite/tests/test_borrow.rs      | 2 ++
 test_suite/tests/test_de.rs          | 2 ++
 test_suite/tests/test_gen.rs         | 5 +++++
 test_suite/tests/test_macros.rs      | 6 +++++-
 test_suite/tests/test_self.rs        | 2 ++
 test_suite/tests/test_serde_path.rs  | 2 ++
 test_suite/tests/test_value.rs       | 2 ++
 9 files changed, 23 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index e007acca..dfb764a6 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -159,5 +159,5 @@ jobs:
       - run: cd serde_derive && cargo clippy -- -Dclippy::all -Dclippy::pedantic
       - run: cd serde_derive_internals && cargo clippy -- -Dclippy::all -Dclippy::pedantic
       - run: cd serde_test && cargo clippy -- -Dclippy::all -Dclippy::pedantic -Aclippy::redundant_field_names
-      - run: cd test_suite && cargo clippy --tests --features unstable -- -Dclippy::all -Aclippy::redundant_field_names
-      - run: cd test_suite/no_std && cargo clippy -- -Dclippy::all -Aclippy::redundant_field_names
+      - run: cd test_suite && cargo clippy --tests --features unstable -- -Dclippy::all -Dclippy::pedantic -Aclippy::redundant_field_names
+      - run: cd test_suite/no_std && cargo clippy -- -Dclippy::all -Dclippy::pedantic -Aclippy::redundant_field_names
diff --git a/test_suite/tests/test_annotations.rs b/test_suite/tests/test_annotations.rs
index db4c58f1..c97de81a 100644
--- a/test_suite/tests/test_annotations.rs
+++ b/test_suite/tests/test_annotations.rs
@@ -3,6 +3,7 @@
     clippy::from_over_into,
     // Clippy bug: https://github.com/rust-lang/rust-clippy/issues/7422
     clippy::nonstandard_macro_braces,
+    clippy::too_many_lines,
     clippy::trivially_copy_pass_by_ref
 )]
 
diff --git a/test_suite/tests/test_borrow.rs b/test_suite/tests/test_borrow.rs
index fd8c9651..7810b52b 100644
--- a/test_suite/tests/test_borrow.rs
+++ b/test_suite/tests/test_borrow.rs
@@ -1,3 +1,5 @@
+#![allow(clippy::items_after_statements, clippy::used_underscore_binding)]
+
 use serde::{Deserialize, Deserializer};
 use serde_test::{assert_de_tokens, assert_de_tokens_error, Token};
 
diff --git a/test_suite/tests/test_de.rs b/test_suite/tests/test_de.rs
index 4aaa856d..60fc1c81 100644
--- a/test_suite/tests/test_de.rs
+++ b/test_suite/tests/test_de.rs
@@ -1,6 +1,8 @@
 #![allow(
     clippy::decimal_literal_representation,
+    clippy::empty_enum,
     clippy::manual_assert,
+    clippy::needless_pass_by_value,
     clippy::unreadable_literal
 )]
 #![cfg_attr(feature = "unstable", feature(never_type))]
diff --git a/test_suite/tests/test_gen.rs b/test_suite/tests/test_gen.rs
index 53a1bfe3..fc8c0a6e 100644
--- a/test_suite/tests/test_gen.rs
+++ b/test_suite/tests/test_gen.rs
@@ -6,9 +6,14 @@
 #![allow(
     unknown_lints,
     mixed_script_confusables,
+    clippy::items_after_statements,
+    clippy::missing_errors_doc,
+    clippy::missing_panics_doc,
+    clippy::must_use_candidate,
     // Clippy bug: https://github.com/rust-lang/rust-clippy/issues/7422
     clippy::nonstandard_macro_braces,
     clippy::ptr_arg,
+    clippy::too_many_lines,
     clippy::trivially_copy_pass_by_ref
 )]
 
diff --git a/test_suite/tests/test_macros.rs b/test_suite/tests/test_macros.rs
index 554e5449..47179edf 100644
--- a/test_suite/tests/test_macros.rs
+++ b/test_suite/tests/test_macros.rs
@@ -1,5 +1,9 @@
 #![deny(trivial_numeric_casts)]
-#![allow(clippy::enum_variant_names, clippy::redundant_field_names)]
+#![allow(
+    clippy::enum_variant_names,
+    clippy::redundant_field_names,
+    clippy::too_many_lines
+)]
 
 mod bytes;
 
diff --git a/test_suite/tests/test_self.rs b/test_suite/tests/test_self.rs
index 0c0c0ea3..77fc9a20 100644
--- a/test_suite/tests/test_self.rs
+++ b/test_suite/tests/test_self.rs
@@ -1,3 +1,5 @@
+#![allow(clippy::used_underscore_binding)]
+
 use serde::{Deserialize, Serialize};
 
 #[test]
diff --git a/test_suite/tests/test_serde_path.rs b/test_suite/tests/test_serde_path.rs
index 68971619..eb6c7aba 100644
--- a/test_suite/tests/test_serde_path.rs
+++ b/test_suite/tests/test_serde_path.rs
@@ -1,3 +1,5 @@
+#![allow(clippy::type_repetition_in_bounds)]
+
 #[test]
 fn test_gen_custom_serde() {
     #[derive(serde::Serialize, serde::Deserialize)]
diff --git a/test_suite/tests/test_value.rs b/test_suite/tests/test_value.rs
index 0bb169df..df95e270 100644
--- a/test_suite/tests/test_value.rs
+++ b/test_suite/tests/test_value.rs
@@ -1,3 +1,5 @@
+#![allow(clippy::similar_names)]
+
 use serde::de::value::{self, MapAccessDeserializer};
 use serde::de::{IntoDeserializer, MapAccess, Visitor};
 use serde::{Deserialize, Deserializer};