From 4ad6c4fd56c6d06b27f3fa4362622e6575771a4a Mon Sep 17 00:00:00 2001 From: David Tolnay Date: Tue, 27 Sep 2016 00:02:15 -0700 Subject: [PATCH] Include unknown attribute name in error message --- serde_codegen/Cargo.toml | 2 +- serde_codegen_internals/Cargo.toml | 2 +- serde_codegen_internals/src/attr.rs | 12 ++++++------ 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/serde_codegen/Cargo.toml b/serde_codegen/Cargo.toml index 52bc9554..0a4d6897 100644 --- a/serde_codegen/Cargo.toml +++ b/serde_codegen/Cargo.toml @@ -24,6 +24,6 @@ with-syn = [] clippy = { version = "^0.*", optional = true } quote = "0.1" serde_codegen_internals = { version = "=0.8.9", default-features = false, path = "../serde_codegen_internals" } -syn = { version = "0.7", features = ["aster", "visit"] } +syn = { version = "0.7.1", features = ["aster", "visit"] } syntex = { version = "^0.44.0", optional = true } syntex_syntax = { version = "^0.44.0", optional = true } diff --git a/serde_codegen_internals/Cargo.toml b/serde_codegen_internals/Cargo.toml index f501786f..30534fde 100644 --- a/serde_codegen_internals/Cargo.toml +++ b/serde_codegen_internals/Cargo.toml @@ -15,4 +15,4 @@ unstable-testing = ["clippy"] [dependencies] clippy = { version = "^0.*", optional = true } -syn = "0.7" +syn = "0.7.1" diff --git a/serde_codegen_internals/src/attr.rs b/serde_codegen_internals/src/attr.rs index 44da33e3..6ecbc8ad 100644 --- a/serde_codegen_internals/src/attr.rs +++ b/serde_codegen_internals/src/attr.rs @@ -142,8 +142,8 @@ impl Item { } _ => { - // TODO include name of attr - cx.error("unknown serde container attribute"); + cx.error(format!("unknown serde container attribute `{}`", + meta_item.name())); } } } @@ -208,8 +208,8 @@ impl Variant { } _ => { - // TODO include attribute - cx.error("unknown serde variant attribute"); + cx.error(format!("unknown serde variant attribute `{}`", + meta_item.name())); } } } @@ -353,8 +353,8 @@ impl Field { } _ => { - // TODO include attribute - cx.error("unknown serde field attribute"); + cx.error(format!("unknown serde field attribute `{}`", + meta_item.name())); } } }