From 985725f820a08fbe1c23688422d79200d24502ec Mon Sep 17 00:00:00 2001 From: David Tolnay Date: Sat, 22 May 2021 20:29:29 -0700 Subject: [PATCH] Resolve while_let_on_iterator clippy lint error: this loop could be written as a `for` loop --> serde/src/private/de.rs:2835:9 | 2835 | while let Some(item) = self.iter.next() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for item in &mut self.iter` | note: the lint level is defined here --> serde/src/lib.rs:97:44 | 97 | #![cfg_attr(feature = "cargo-clippy", deny(clippy, clippy_pedantic))] | ^^^^^^ = note: `#[deny(clippy::while_let_on_iterator)]` implied by `#[deny(clippy::all)]` = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator error: this loop could be written as a `for` loop --> serde/src/private/de.rs:2937:9 | 2937 | while let Some(item) = self.iter.next() { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for item in &mut self.iter` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator --- serde/src/private/de.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/serde/src/private/de.rs b/serde/src/private/de.rs index 91998163..a387d404 100644 --- a/serde/src/private/de.rs +++ b/serde/src/private/de.rs @@ -2832,7 +2832,7 @@ where where T: DeserializeSeed<'de>, { - while let Some(item) = self.iter.next() { + for item in &mut self.iter { // Items in the vector are nulled out when used by a struct. if let Some((ref key, ref content)) = *item { self.pending_content = Some(content); @@ -2934,7 +2934,7 @@ where where T: DeserializeSeed<'de>, { - while let Some(item) = self.iter.next() { + for item in &mut self.iter { if let Some((ref key, ref content)) = *item { // Do not take(), instead borrow this entry. The internally tagged // enum does its own buffering so we can't tell whether this entry