diff --git a/serde_derive/src/internals/ast.rs b/serde_derive/src/internals/ast.rs index b654f774..8bcb0ecd 100644 --- a/serde_derive/src/internals/ast.rs +++ b/serde_derive/src/internals/ast.rs @@ -140,8 +140,7 @@ fn enum_from_ast<'a>( variants: &'a Punctuated, container_default: &attr::Default, ) -> Vec> { - let mut seen_untagged = false; - variants + let variants: Vec = variants .iter() .map(|variant| { let attrs = attr::Variant::from_ast(cx, variant); @@ -154,12 +153,21 @@ fn enum_from_ast<'a>( fields, original: variant, } - }).inspect(|variant| { - if !variant.attrs.untagged() && seen_untagged { + }) + .collect(); + + let index_of_last_tagged_variant = variants + .iter() + .rposition(|variant| !variant.attrs.untagged()); + if let Some(index_of_last_tagged_variant) = index_of_last_tagged_variant { + for variant in &variants[..index_of_last_tagged_variant] { + if variant.attrs.untagged() { cx.error_spanned_by(&variant.ident, "all variants with the #[serde(untagged)] attribute must be placed at the end of the enum"); } - seen_untagged = variant.attrs.untagged(); - }).collect() + } + } + + variants } fn struct_from_ast<'a>( diff --git a/test_suite/tests/ui/enum-representation/partially_tagged_wrong_order.stderr b/test_suite/tests/ui/enum-representation/partially_tagged_wrong_order.stderr index 17d3c3f9..08ee2666 100644 --- a/test_suite/tests/ui/enum-representation/partially_tagged_wrong_order.stderr +++ b/test_suite/tests/ui/enum-representation/partially_tagged_wrong_order.stderr @@ -1,5 +1,5 @@ error: all variants with the #[serde(untagged)] attribute must be placed at the end of the enum - --> tests/ui/enum-representation/partially_tagged_wrong_order.rs:7:5 + --> tests/ui/enum-representation/partially_tagged_wrong_order.rs:6:5 | -7 | B(String), +6 | A(u8), | ^