Auto merge of #293 - dtolnay:duplicate, r=oli-obk

feat(codegen): Detect repeated struct field when deserializing Addresses #59. Let me know whether you think we need an escape hatch to opt out of this check.
2026-04-23 00:08:01 +00:00 · 2016-05-11 19:44:34 +09:00
parent 7374ac499d eeb4efc19c
commit a9a4b2d8e2
4 changed files with 49 additions and 0 deletions
@@ -1141,6 +1141,9 @@ fn deserialize_map(
    let value_arms = fields_attrs_names.iter()
        .filter(|&&(_, ref attrs, _)| !attrs.skip_deserializing_field())
        .map(|&(field, ref attrs, name)| {
+            let deser_name = attrs.name().deserialize_name();
+            let name_str = builder.expr().lit().str(deser_name);
+
            let visit = match attrs.deserialize_with() {
                None => {
                    let field_ty = &field.ty;
@@ -1158,6 +1161,9 @@ fn deserialize_map(
            };
            quote_arm!(cx,
                __Field::$name => {
+                    if $name.is_some() {
+                        return Err(<__V::Error as _serde::de::Error>::duplicate_field($name_str));
+                    }
                    $name = Some($visit);
                }
            )