minor cleanup

This commit is contained in:
Erick Tryzelaar
2014-05-24 15:04:45 -07:00
parent 79d3676d1c
commit b90aae619c
+41 -42
View File
@@ -17,26 +17,26 @@ enum Error {
mod decoder { mod decoder {
use std::vec; use std::vec;
use serialize::Decoder; use serialize;
use super::{Error, EndOfStream, SyntaxError}; use super::{Error, EndOfStream, SyntaxError};
pub struct IntsDecoder { pub struct Decoder {
len: uint, len: uint,
iter: vec::MoveItems<int>, iter: vec::MoveItems<int>,
} }
impl IntsDecoder { impl Decoder {
#[inline] #[inline]
pub fn new(values: Vec<int>) -> IntsDecoder { pub fn new(values: Vec<int>) -> Decoder {
IntsDecoder { Decoder {
len: values.len(), len: values.len(),
iter: values.move_iter(), iter: values.move_iter(),
} }
} }
} }
impl Decoder<Error> for IntsDecoder { impl serialize::Decoder<Error> for Decoder {
// Primitive types: // Primitive types:
fn read_nil(&mut self) -> Result<(), Error> { Err(SyntaxError) } fn read_nil(&mut self) -> Result<(), Error> { Err(SyntaxError) }
fn read_uint(&mut self) -> Result<uint, Error> { Err(SyntaxError) } fn read_uint(&mut self) -> Result<uint, Error> { Err(SyntaxError) }
@@ -62,75 +62,74 @@ mod decoder {
fn read_str(&mut self) -> Result<StrBuf, Error> { Err(SyntaxError) } fn read_str(&mut self) -> Result<StrBuf, Error> { Err(SyntaxError) }
// Compound types: // Compound types:
fn read_enum<T>(&mut self, _name: &str, _f: |&mut IntsDecoder| -> Result<T, Error>) -> Result<T, Error> { Err(SyntaxError) } fn read_enum<T>(&mut self, _name: &str, _f: |&mut Decoder| -> Result<T, Error>) -> Result<T, Error> { Err(SyntaxError) }
fn read_enum_variant<T>(&mut self, fn read_enum_variant<T>(&mut self,
_names: &[&str], _names: &[&str],
_f: |&mut IntsDecoder, uint| -> Result<T, Error>) _f: |&mut Decoder, uint| -> Result<T, Error>)
-> Result<T, Error> { Err(SyntaxError) } -> Result<T, Error> { Err(SyntaxError) }
fn read_enum_variant_arg<T>(&mut self, fn read_enum_variant_arg<T>(&mut self,
_a_idx: uint, _a_idx: uint,
_f: |&mut IntsDecoder| -> Result<T, Error>) _f: |&mut Decoder| -> Result<T, Error>)
-> Result<T, Error> { Err(SyntaxError) } -> Result<T, Error> { Err(SyntaxError) }
fn read_enum_struct_variant<T>(&mut self, fn read_enum_struct_variant<T>(&mut self,
_names: &[&str], _names: &[&str],
_f: |&mut IntsDecoder, uint| -> Result<T, Error>) _f: |&mut Decoder, uint| -> Result<T, Error>)
-> Result<T, Error> { Err(SyntaxError) } -> Result<T, Error> { Err(SyntaxError) }
fn read_enum_struct_variant_field<T>(&mut self, fn read_enum_struct_variant_field<T>(&mut self,
_f_name: &str, _f_name: &str,
_f_idx: uint, _f_idx: uint,
_f: |&mut IntsDecoder| -> Result<T, Error>) _f: |&mut Decoder| -> Result<T, Error>)
-> Result<T, Error> { Err(SyntaxError) } -> Result<T, Error> { Err(SyntaxError) }
fn read_struct<T>(&mut self, _s_name: &str, _len: uint, _f: |&mut IntsDecoder| -> Result<T, Error>) fn read_struct<T>(&mut self, _s_name: &str, _len: uint, _f: |&mut Decoder| -> Result<T, Error>)
-> Result<T, Error> { Err(SyntaxError) } -> Result<T, Error> { Err(SyntaxError) }
fn read_struct_field<T>(&mut self, fn read_struct_field<T>(&mut self,
_f_name: &str, _f_name: &str,
_f_idx: uint, _f_idx: uint,
_f: |&mut IntsDecoder| -> Result<T, Error>) _f: |&mut Decoder| -> Result<T, Error>)
-> Result<T, Error> { Err(SyntaxError) } -> Result<T, Error> { Err(SyntaxError) }
fn read_tuple<T>(&mut self, _f: |&mut IntsDecoder, uint| -> Result<T, Error>) -> Result<T, Error> { Err(SyntaxError) } fn read_tuple<T>(&mut self, _f: |&mut Decoder, uint| -> Result<T, Error>) -> Result<T, Error> { Err(SyntaxError) }
fn read_tuple_arg<T>(&mut self, _a_idx: uint, _f: |&mut IntsDecoder| -> Result<T, Error>) -> Result<T, Error> { Err(SyntaxError) } fn read_tuple_arg<T>(&mut self, _a_idx: uint, _f: |&mut Decoder| -> Result<T, Error>) -> Result<T, Error> { Err(SyntaxError) }
fn read_tuple_struct<T>(&mut self, fn read_tuple_struct<T>(&mut self,
_s_name: &str, _s_name: &str,
_f: |&mut IntsDecoder, uint| -> Result<T, Error>) _f: |&mut Decoder, uint| -> Result<T, Error>)
-> Result<T, Error> { Err(SyntaxError) } -> Result<T, Error> { Err(SyntaxError) }
fn read_tuple_struct_arg<T>(&mut self, fn read_tuple_struct_arg<T>(&mut self,
_a_idx: uint, _a_idx: uint,
_f: |&mut IntsDecoder| -> Result<T, Error>) _f: |&mut Decoder| -> Result<T, Error>)
-> Result<T, Error> { Err(SyntaxError) } -> Result<T, Error> { Err(SyntaxError) }
// Specialized types: // Specialized types:
fn read_option<T>(&mut self, _f: |&mut IntsDecoder, bool| -> Result<T, Error>) -> Result<T, Error> { Err(SyntaxError) } fn read_option<T>(&mut self, _f: |&mut Decoder, bool| -> Result<T, Error>) -> Result<T, Error> { Err(SyntaxError) }
#[inline] #[inline]
fn read_seq<T>(&mut self, f: |&mut IntsDecoder, uint| -> Result<T, Error>) -> Result<T, Error> { fn read_seq<T>(&mut self, f: |&mut Decoder, uint| -> Result<T, Error>) -> Result<T, Error> {
f(self, self.len) f(self, self.len)
} }
#[inline] #[inline]
fn read_seq_elt<T>(&mut self, _idx: uint, f: |&mut IntsDecoder| -> Result<T, Error>) -> Result<T, Error> { fn read_seq_elt<T>(&mut self, _idx: uint, f: |&mut Decoder| -> Result<T, Error>) -> Result<T, Error> {
f(self) f(self)
} }
fn read_map<T>(&mut self, _f: |&mut IntsDecoder, uint| -> Result<T, Error>) -> Result<T, Error> { Err(SyntaxError) } fn read_map<T>(&mut self, _f: |&mut Decoder, uint| -> Result<T, Error>) -> Result<T, Error> { Err(SyntaxError) }
fn read_map_elt_key<T>(&mut self, _idx: uint, _f: |&mut IntsDecoder| -> Result<T, Error>) -> Result<T, Error> { Err(SyntaxError) } fn read_map_elt_key<T>(&mut self, _idx: uint, _f: |&mut Decoder| -> Result<T, Error>) -> Result<T, Error> { Err(SyntaxError) }
fn read_map_elt_val<T>(&mut self, _idx: uint, _f: |&mut IntsDecoder| -> Result<T, Error>) -> Result<T, Error> { Err(SyntaxError) } fn read_map_elt_val<T>(&mut self, _idx: uint, _f: |&mut Decoder| -> Result<T, Error>) -> Result<T, Error> { Err(SyntaxError) }
} }
} }
////////////////////////////////////////////////////////////////////////////// //////////////////////////////////////////////////////////////////////////////
mod deserializer { mod deserializer {
use std::num; //use std::num;
use std::vec; use std::vec;
use super::{Error, EndOfStream, SyntaxError}; use super::{Error, EndOfStream, SyntaxError};
use de::Deserializer; use de;
use de::{Token, Int, SeqStart, Sep, End};
#[deriving(Eq, Show)] #[deriving(Eq, Show)]
enum State { enum State {
@@ -139,16 +138,16 @@ mod deserializer {
EndState, EndState,
} }
pub struct IntsDeserializer { pub struct Deserializer {
state: State, state: State,
len: uint, len: uint,
iter: vec::MoveItems<int>, iter: vec::MoveItems<int>,
} }
impl IntsDeserializer { impl Deserializer {
#[inline] #[inline]
pub fn new(values: Vec<int>) -> IntsDeserializer { pub fn new(values: Vec<int>) -> Deserializer {
IntsDeserializer { Deserializer {
state: StartState, state: StartState,
len: values.len(), len: values.len(),
iter: values.move_iter(), iter: values.move_iter(),
@@ -156,22 +155,22 @@ mod deserializer {
} }
} }
impl Iterator<Result<Token, Error>> for IntsDeserializer { impl Iterator<Result<de::Token, Error>> for Deserializer {
#[inline] #[inline]
fn next(&mut self) -> Option<Result<Token, Error>> { fn next(&mut self) -> Option<Result<de::Token, Error>> {
match self.state { match self.state {
StartState => { StartState => {
self.state = SepOrEndState; self.state = SepOrEndState;
Some(Ok(SeqStart(self.len))) Some(Ok(de::SeqStart(self.len)))
} }
SepOrEndState => { SepOrEndState => {
match self.iter.next() { match self.iter.next() {
Some(value) => { Some(value) => {
Some(Ok(Int(value))) Some(Ok(de::Int(value)))
} }
None => { None => {
self.state = EndState; self.state = EndState;
Some(Ok(End)) Some(Ok(de::End))
} }
} }
} }
@@ -182,7 +181,7 @@ mod deserializer {
} }
} }
impl Deserializer<Error> for IntsDeserializer { impl de::Deserializer<Error> for Deserializer {
#[inline] #[inline]
fn end_of_stream_error(&self) -> Error { fn end_of_stream_error(&self) -> Error {
EndOfStream EndOfStream
@@ -221,7 +220,7 @@ fn run_deserializer<
fn bench_decoder_vec_int_000(b: &mut Bencher) { fn bench_decoder_vec_int_000(b: &mut Bencher) {
b.iter(|| { b.iter(|| {
let v: Vec<int> = vec!(); let v: Vec<int> = vec!();
run_decoder(decoder::IntsDecoder::new(v.clone()), v) run_decoder(decoder::Decoder::new(v.clone()), v)
}) })
} }
@@ -229,7 +228,7 @@ fn bench_decoder_vec_int_000(b: &mut Bencher) {
fn bench_deserializer_vec_int_000(b: &mut Bencher) { fn bench_deserializer_vec_int_000(b: &mut Bencher) {
b.iter(|| { b.iter(|| {
let v: Vec<int> = vec!(); let v: Vec<int> = vec!();
run_deserializer(deserializer::IntsDeserializer::new(v.clone()), v) run_deserializer(deserializer::Deserializer::new(v.clone()), v)
}) })
} }
@@ -237,7 +236,7 @@ fn bench_deserializer_vec_int_000(b: &mut Bencher) {
fn bench_decoder_vec_int_003(b: &mut Bencher) { fn bench_decoder_vec_int_003(b: &mut Bencher) {
b.iter(|| { b.iter(|| {
let v: Vec<int> = vec!(1, 2, 3); let v: Vec<int> = vec!(1, 2, 3);
run_decoder(decoder::IntsDecoder::new(v.clone()), v) run_decoder(decoder::Decoder::new(v.clone()), v)
}) })
} }
@@ -245,7 +244,7 @@ fn bench_decoder_vec_int_003(b: &mut Bencher) {
fn bench_deserializer_vec_int_003(b: &mut Bencher) { fn bench_deserializer_vec_int_003(b: &mut Bencher) {
b.iter(|| { b.iter(|| {
let v: Vec<int> = vec!(1, 2, 3); let v: Vec<int> = vec!(1, 2, 3);
run_deserializer(deserializer::IntsDeserializer::new(v.clone()), v) run_deserializer(deserializer::Deserializer::new(v.clone()), v)
}) })
} }
@@ -253,7 +252,7 @@ fn bench_deserializer_vec_int_003(b: &mut Bencher) {
fn bench_decoder_vec_int_100(b: &mut Bencher) { fn bench_decoder_vec_int_100(b: &mut Bencher) {
b.iter(|| { b.iter(|| {
let v: Vec<int> = range(0, 100).collect(); let v: Vec<int> = range(0, 100).collect();
run_decoder(decoder::IntsDecoder::new(v.clone()), v) run_decoder(decoder::Decoder::new(v.clone()), v)
}) })
} }
@@ -261,6 +260,6 @@ fn bench_decoder_vec_int_100(b: &mut Bencher) {
fn bench_deserializer_vec_int_100(b: &mut Bencher) { fn bench_deserializer_vec_int_100(b: &mut Bencher) {
b.iter(|| { b.iter(|| {
let v: Vec<int> = range(0, 100).collect(); let v: Vec<int> = range(0, 100).collect();
run_deserializer(deserializer::IntsDeserializer::new(v.clone()), v) run_deserializer(deserializer::Deserializer::new(v.clone()), v)
}) })
} }