Respect variant skip attribute in inferred bounds

This commit is contained in:
David Tolnay
2018-05-07 21:30:00 -07:00
parent 8c0efc3d77
commit c4181f46be
3 changed files with 26 additions and 10 deletions
+7 -5
View File
@@ -150,13 +150,15 @@ fn build_generics(cont: &Container) -> syn::Generics {
}
// Fields with a `skip_serializing` or `serialize_with` attribute, or which
// belong to a variant with a `serialize_with` attribute, are not serialized by
// us so we do not generate a bound. Fields with a `bound` attribute specify
// their own bound so we do not generate one. All other fields may need a `T:
// Serialize` bound where T is the type of the field.
// belong to a variant with a 'skip_serializing` or `serialize_with` attribute,
// are not serialized by us so we do not generate a bound. Fields with a `bound`
// attribute specify their own bound so we do not generate one. All other fields
// may need a `T: Serialize` bound where T is the type of the field.
fn needs_serialize_bound(field: &attr::Field, variant: Option<&attr::Variant>) -> bool {
!field.skip_serializing() && field.serialize_with().is_none() && field.ser_bound().is_none()
&& variant.map_or(true, |variant| variant.serialize_with().is_none())
&& variant.map_or(true, |variant| {
!variant.skip_serializing() && variant.serialize_with().is_none()
})
}
fn serialize_body(cont: &Container, params: &Parameters) -> Fragment {