pezkuwichain/serde
1
0
Fork 0
mirror of https://github.com/pezkuwichain/serde.git synced 2026-06-12 21:21:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix borrow error on pre-NLL compilers

Browse Source 
error[E0506]: cannot assign to `missing_content` because it is borrowed
        --> serde_derive/src/de.rs:1414:9
         |
    1388 |           .filter_map(|(i, variant)| {
         |                       -------------- borrow of `missing_content` occurs here
    ...
    1414 | /         missing_content = quote! {
    1415 | |             match __field {
    1416 | |                 #(#missing_content_arms)*
    1417 | |                 #missing_content_fallthrough
    1418 | |             }
    1419 | |         };
         | |_________^ assignment to borrowed `missing_content` occurs here

    error[E0502]: cannot borrow `missing_content_fallthrough` as immutable because it is also borrowed as mutable
        --> serde_derive/src/de.rs:1414:27
         |
    1388 |           .filter_map(|(i, variant)| {
         |                       -------------- mutable borrow occurs here
    ...
    1404 |                       missing_content_fallthrough = quote!(_ => #missing_content);
         |                       --------------------------- previous borrow occurs due to use of `missing_content_fallthrough` in closure
    ...
    1414 |           missing_content = quote! {
         |  ___________________________^
    1415 | |             match __field {
    1416 | |                 #(#missing_content_arms)*
    1417 | |                 #missing_content_fallthrough
    1418 | |             }
    1419 | |         };
         | |_________^ immutable borrow occurs here
    ...
    1622 |   }
         |   - mutable borrow ends here
         |
         = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
This commit is contained in:
David Tolnay
2020-05-09 22:32:13 -07:00
parent b97a183e82
commit dda070f45c
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
serde_derive/src/de.rs
+3 -3
View File
@@ -1381,7 +1381,7 @@ fn deserialize_adjacently_tagged_enum(
_serde::export::Err(<__A::Error as _serde::de::Error>::missing_field(#content)) _serde::export::Err(<__A::Error as _serde::de::Error>::missing_field(#content))
}; };
let mut missing_content_fallthrough = quote!(); let mut missing_content_fallthrough = quote!();
let mut missing_content_arms = variants let missing_content_arms = variants
.iter() .iter()
.enumerate() .enumerate()
.filter(|&(_, variant)| !variant.attrs.skip_deserializing()) .filter(|&(_, variant)| !variant.attrs.skip_deserializing())
@@ -1409,8 +1409,8 @@ fn deserialize_adjacently_tagged_enum(
__Field::#variant_index => #arm, __Field::#variant_index => #arm,
}) })
}) })
.peekable(); .collect::<Vec<_>>();
if missing_content_arms.peek().is_some() { if !missing_content_arms.is_empty() {
missing_content = quote! { missing_content = quote! {
match __field { match __field {
#(#missing_content_arms)* #(#missing_content_arms)*