Allow irrefutable let pattern for subscriptions, remove legacy lint

src/lib.rs

@@ -27,7 +27,6 @@
     overflowing_literals,
     path_statements,
     patterns_in_fns_without_body,
-    plugin_as_library,
     private_in_public,
     unconditional_recursion,
     unused_allocation,

src/rpc.rs

@@ -14,6 +14,11 @@
 // You should have received a copy of the GNU General Public License
 // along with substrate-subxt.  If not, see <http://www.gnu.org/licenses/>.
 
+// jsonrpsee subscriptions are interminable.
+// Allows `while let status = subscription.next().await {}`
+// Related: https://github.com/paritytech/substrate-subxt/issues/66
+#![allow(irrefutable_let_patterns)]
+
 use std::convert::TryInto;
 
 use codec::{