pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-06-13 12:51:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

sc-consensus-beefy: fix flaky test beefy_reports_equivocations (#14382)

Browse Source 
Test was using too small a timeout of 250ms to verify equivocation is reported.

If the test machine is loaded with many async tasks running, the voters work
and subsequent gossiping does not fit within the 250ms window.

Do multiple tries to verify equivocation reporting with exponential timeouts,
most times it will be within 250ms, but the test will retry several times up
to 5seconds total before giving up.

Signed-off-by: Adrian Catangiu <adrian@parity.io>
This commit is contained in:
Adrian Catangiu
2023-06-16 10:00:11 +03:00
committed by GitHub
parent 5426b17f9c
commit 4311411133
1 changed files with 21 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
substrate/client/consensus/beefy/src/tests.rs
+21 -5
View File
@@ -1263,18 +1263,34 @@ async fn beefy_reports_equivocations() {
let peers = peers.into_iter().enumerate();
// finalize block #1 -> BEEFY should not finalize anything (each node votes on different MMR).
finalize_block_and_wait_for_beefy(&net, peers, &hashes[1], &[]).await;
let (best_blocks, versioned_finality_proof) = get_beefy_streams(&mut net.lock(), peers.clone());
peers.clone().for_each(|(index, _)| {
let client = net.lock().peer(index).client().as_client();
client.finalize_block(hashes[1], None).unwrap();
});
// Verify neither Bob or Bob_Prime report themselves as equivocating.
assert!(api_bob.reported_equivocations.as_ref().unwrap().lock().is_empty());
assert!(api_bob_prime.reported_equivocations.as_ref().unwrap().lock().is_empty());
// run for up to 5 seconds waiting for Alice's report of Bob/Bob_Prime equivocation.
for wait_ms in [250, 500, 1250, 3000] {
run_for(Duration::from_millis(wait_ms), &net).await;
if !api_alice.reported_equivocations.as_ref().unwrap().lock().is_empty() {
break
}
}
// Verify Alice reports Bob/Bob_Prime equivocation.
// Verify expected equivocation
let alice_reported_equivocations = api_alice.reported_equivocations.as_ref().unwrap().lock();
assert_eq!(alice_reported_equivocations.len(), 1);
let equivocation_proof = alice_reported_equivocations.get(0).unwrap();
assert_eq!(equivocation_proof.first.id, BeefyKeyring::Bob.public());
assert_eq!(equivocation_proof.first.commitment.block_number, 1);
// Verify neither Bob or Bob_Prime report themselves as equivocating.
assert!(api_bob.reported_equivocations.as_ref().unwrap().lock().is_empty());
assert!(api_bob_prime.reported_equivocations.as_ref().unwrap().lock().is_empty());
// sanity verify no new blocks have been finalized by BEEFY
streams_empty_after_timeout(best_blocks, &net, None).await;
streams_empty_after_timeout(versioned_finality_proof, &net, None).await;
}
#[tokio::test]