network-bridge: downgrade log level of benefit rep change (#3068)

* network-bridge: downgrade log level of benefit rep change

* remove it as we log it at higher level

polkadot/node/network/bridge/src/lib.rs

@@ -433,10 +433,12 @@ where
 				}
 				Ok(FromOverseer::Communication { msg }) => match msg {
 					NetworkBridgeMessage::ReportPeer(peer, rep) => {
-						tracing::debug!(
-							target: LOG_TARGET,
-							action = "ReportPeer"
-						);
+						if !rep.is_benefit() {
+							tracing::debug!(
+								target: LOG_TARGET,
+								action = "ReportPeer"
+							);
+						}
 						network_service.report_peer(peer, rep).await?
 					}
 					NetworkBridgeMessage::DisconnectPeer(peer, peer_set) => {

polkadot/node/network/protocol/src/reputation.rs

@@ -55,6 +55,17 @@ impl UnifiedReputationChange {
 		}
 	}
 
+	/// Whether the reputation change is for good behavior.
+	pub const fn is_benefit(&self) -> bool {
+		match self {
+			Self::BenefitMajorFirst(_) |
+			Self::BenefitMajor(_) |
+			Self::BenefitMinorFirst(_) |
+			Self::BenefitMinor(_) => true,
+			_ => false,
+		}
+	}
+
 	/// Convert into a base reputation as used with substrate.
 	pub const fn into_base_rep(self) -> ReputationChange {
 		ReputationChange::new(