pezkuwichain/pezkuwi-subxt
1
0
Fork 0
mirror of https://github.com/pezkuwichain/pezkuwi-subxt.git synced 2026-06-12 22:51:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Only read storage after origin check (#11391)

Browse Source 
* only read storage after origin check

* fmt
This commit is contained in:
Shawn Tabrizi
2022-05-11 07:27:26 -04:00
committed by GitHub
parent 79b1aa5677
commit 479dc63af4
1 changed files with 9 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
substrate/frame/nomination-pools/src/lib.rs
+9 -14
View File
@@ -1854,21 +1854,16 @@ pub mod pallet {
nominator: Option<T::AccountId>,
state_toggler: Option<T::AccountId>,
) -> DispatchResult {
let o1 = origin;
let o2 = o1.clone();
let mut bonded_pool = BondedPool::<T>::get(pool_id).ok_or(Error::<T>::PoolNotFound)?;
let is_pool_root = || -> Result<(), sp_runtime::DispatchError> {
let who = ensure_signed(o1)?;
ensure!(bonded_pool.can_update_roles(&who), Error::<T>::DoesNotHavePermission);
Ok(())
let mut bonded_pool = match ensure_root(origin.clone()) {
Ok(()) => BondedPool::<T>::get(pool_id).ok_or(Error::<T>::PoolNotFound)?,
Err(frame_support::error::BadOrigin) => {
let who = ensure_signed(origin)?;
let bonded_pool =
BondedPool::<T>::get(pool_id).ok_or(Error::<T>::PoolNotFound)?;
ensure!(bonded_pool.can_update_roles(&who), Error::<T>::DoesNotHavePermission);
bonded_pool
},
};
let is_root = || -> Result<(), sp_runtime::DispatchError> {
ensure_root(o2)?;
Ok(())
};
let _ = is_root().or_else(|_| is_pool_root())?;
match root {
None => (),