Fix extrinsic impl. (#1109)

substrate/core/sr-primitives/src/generic/unchecked_extrinsic.rs

@@ -21,7 +21,7 @@ use std::fmt;
 
 use rstd::prelude::*;
 use codec::{Decode, Encode, Codec, Input, HasCompact};
-use traits::{self, Member, SimpleArithmetic, MaybeDisplay, Lookup};
+use traits::{self, Member, SimpleArithmetic, MaybeDisplay, Lookup, Extrinsic};
 use super::CheckedExtrinsic;
 
 #[derive(PartialEq, Eq, Clone, Encode, Decode)]
@@ -73,11 +73,6 @@ where
 			function,
 		}
 	}
-
-	/// `true` if there is a signature.
-	pub fn is_signed(&self) -> bool {
-		self.signature.is_some()
-	}
 }
 
 impl<Address, Index, Signature, Call, AccountId, Context> traits::Checkable<Context>
@@ -113,6 +108,17 @@ where
 	}
 }
 
+impl<
+	Address: Codec,
+	Index: HasCompact + Codec,
+	Signature: Codec,
+	Call,
+> Extrinsic for UncheckedExtrinsic<Address, Index, Call, Signature> {
+	fn is_signed(&self) -> Option<bool> {
+		Some(self.signature.is_some())
+	}
+}
+
 impl<Address: Codec, Index: HasCompact + Codec, Signature: Codec, Call: Decode> Decode
 	for UncheckedExtrinsic<Address, Index, Call, Signature>
 {

substrate/srml/support/src/dispatch.rs

@@ -193,11 +193,8 @@ macro_rules! decl_module {
 		$($rest:tt)*
 	) => {
 		compile_error!("\
-First parameter of dispatch should be marked `origin` only, with no\n\
-type specified (a bit like `self`).\n\
-(For root-matching dispatches, ensure the first parameter does not use\n\
-the `T::Origin` type.)\
-")
+first parameter of dispatch should be marked `origin` only, with no type specified (a bit like `self`)\n\
+(For root-matching dispatches, ensure the first parameter does not use the `T::Origin` type.)")
 	};
 	(@normalize
 		$(#[$attr:meta])*
@@ -211,11 +208,8 @@ the `T::Origin` type.)\
 		$($rest:tt)*
 	) => {
 		compile_error!("\
-First parameter of dispatch should be marked `origin` only, with no\n\
-type specified (a bit like `self`).\n\
-(For root-matching dispatches, ensure the first parameter is not named\n\
-`origin`.)\
-")
+first parameter of dispatch should be marked `origin` only, with no type specified (a bit like `self`)\n\
+(For root-matching dispatches, ensure the first parameter is not named`origin`.)")
 	};
 	(@normalize
 		$(#[$attr:meta])*