be more careful about fusing in select! (#2052)

polkadot/node/collation-generation/src/lib.rs

@@ -84,8 +84,9 @@ impl CollationGenerationSubsystem {
 		// at any point waiting for them all, so instead, we create a channel on which they can
 		// send those messages. We can then just monitor the channel and forward messages on it
 		// to the overseer here, via the context.
-		let (sender, mut receiver) = mpsc::channel(0);
+		let (sender, receiver) = mpsc::channel(0);
 
+		let mut receiver = receiver.fuse();
 		loop {
 			select! {
 				incoming = ctx.recv().fuse() => {
@@ -93,7 +94,7 @@ impl CollationGenerationSubsystem {
 						break;
 					}
 				},
-				msg = receiver.next().fuse() => {
+				msg = receiver.next() => {
 					if let Some(msg) = msg {
 						ctx.send_message(msg).await;
 					}

polkadot/node/core/backing/src/lib.rs

@@ -121,8 +121,6 @@ impl ValidatedCandidateCommand {
 struct CandidateBackingJob {
 	/// The hash of the relay parent on top of which this job is doing it's work.
 	parent: Hash,
-	/// Inbound message channel receiving part.
-	rx_to: mpsc::Receiver<CandidateBackingMessage>,
 	/// Outbound message channel sending part.
 	tx_from: mpsc::Sender<FromJobCommand>,
 	/// The `ParaId` assigned to this validator
@@ -426,7 +424,10 @@ async fn validate_and_make_available(
 
 impl CandidateBackingJob {
 	/// Run asynchronously.
-	async fn run_loop(mut self) -> Result<(), Error> {
+	async fn run_loop(
+		mut self,
+		mut rx_to: mpsc::Receiver<CandidateBackingMessage>,
+	) -> Result<(), Error> {
 		loop {
 			futures::select! {
 				validated_command = self.background_validation.next() => {
@@ -436,7 +437,7 @@ impl CandidateBackingJob {
 						panic!("`self` hasn't dropped and `self` holds a reference to this sender; qed");
 					}
 				}
-				to_job = self.rx_to.next() => match to_job {
+				to_job = rx_to.next() => match to_job {
 					None => break,
 					Some(msg) => {
 						self.process_msg(msg).await?;
@@ -917,7 +918,6 @@ impl util::JobTrait for CandidateBackingJob {
 			let (background_tx, background_rx) = mpsc::channel(16);
 			let job = CandidateBackingJob {
 				parent,
-				rx_to,
 				tx_from,
 				assignment,
 				required_collator,
@@ -934,7 +934,7 @@ impl util::JobTrait for CandidateBackingJob {
 				metrics,
 			};
 
-			job.run_loop().await
+			job.run_loop(rx_to).await
 		}
 		.boxed()
 	}

polkadot/node/network/collator-protocol/src/collator_side.rs

@@ -695,7 +695,7 @@ pub(crate) async fn run(
 				let (relay_parent, validator_id, peer_id) = match res {
 					Some(res) => res,
 					// Will never happen, but better to be safe.
-					None => continue,
+					None => return Ok(()),
 				};
 
 				let _timer = state.metrics.time_handle_connection_request();