Don't mark peers sending expired messages as useless (#1944)

substrate/core/network/src/consensus_gossip.rs

@@ -303,7 +303,6 @@ impl<B: BlockT> ConsensusGossip<B> {
 		protocol: &mut Context<B>,
 		who: NodeIndex,
 		message: ConsensusMessage,
-		is_syncing: bool,
 	) -> Option<(B::Hash, ConsensusMessage)> {
 		let message_hash = HashFor::<B>::hash(&message.data[..]);
 
@@ -332,12 +331,6 @@ impl<B: BlockT> ConsensusGossip<B> {
 				},
 				Some(ValidationResult::Expired) => {
 					trace!(target:"gossip", "Ignored expired message from {}", who);
-					if !is_syncing {
-						protocol.report_peer(
-							who,
-							Severity::Useless(format!("Sent expired consensus message")),
-						);
-					}
 					return None;
 				}
 				None => {

substrate/core/network/src/protocol.rs

@@ -484,7 +484,6 @@ impl<B: BlockT, S: NetworkSpecialization<B>, H: ExHashT> Protocol<B, S, H> {
 					&mut ProtocolContext::new(&mut self.context_data, &self.network_chan),
 					who,
 					msg,
-					self.sync.status().is_major_syncing(),
 				);
 			}
 			other => self.specialization.on_message(