Address David feedback

This commit is contained in:
emostov
2020-12-29 10:58:46 -08:00
parent 900340fafd
commit ce36380a48
2 changed files with 4 additions and 4 deletions
+3 -3
View File
@@ -217,14 +217,14 @@ impl<T: Runtime> ClientBuilder<T> {
runtime_version: runtime_version?,
_marker: PhantomData,
page_size: self.page_size.unwrap_or(10),
signed_options: ClientSignedOptions { mortal_period },
signed_options: SigningOptions { mortal_period },
})
}
}
/// Construction options for a signed extrinsic
#[derive(Copy, Clone)]
struct ClientSignedOptions {
struct SigningOptions {
/// The period of validity, measured in blocks, that an extrinsic will live for, starting from a checkpoint
/// block.
///
@@ -242,7 +242,7 @@ pub struct Client<T: Runtime> {
runtime_version: RuntimeVersion,
_marker: PhantomData<(fn() -> T::Signature, T::Extra)>,
page_size: u32,
signed_options: ClientSignedOptions,
signed_options: SigningOptions,
}
impl<T: Runtime> Clone for Client<T> {
+1 -1
View File
@@ -41,7 +41,7 @@ use sp_core::storage::StorageKey;
use crate::Encoded;
/// 5 min `mortal_period` in milliseconds, to be adjusted based on expected block time
pub const BASELINE_MORTAL_PERIOD: u64 = 5 * 60 * 1000;
const BASELINE_MORTAL_PERIOD: u64 = 5 * 60 * 1000;
/// Metadata error.
#[derive(Debug, thiserror::Error)]