BlockId removal: &Hash to Hash (#1818)

* BlockId removal: &Hash to Hash

It changes &Block::Hash argument to Block::Hash.

This PR is part of BlockId::Number refactoring analysis (paritytech/substrate#11292)

* update lockfile for {"polkadot", "substrate"}

Co-authored-by: parity-processbot <>

cumulus/client/consensus/common/src/parachain_consensus.rs

@@ -102,7 +102,7 @@ where
 
 		// don't finalize the same block multiple times.
 		if parachain.usage_info().chain.finalized_hash != hash {
-			if let Err(e) = parachain.finalize_block(&hash, None, true) {
+			if let Err(e) = parachain.finalize_block(hash, None, true) {
 				match e {
 					ClientError::UnknownBlock(_) => tracing::debug!(
 						target: "cumulus-consensus",

cumulus/client/relay-chain-inprocess-interface/src/lib.rs

@@ -180,7 +180,7 @@ where
 		relay_parent: PHash,
 		key: &[u8],
 	) -> RelayChainResult<Option<StorageValue>> {
-		let state = self.backend.state_at(&relay_parent)?;
+		let state = self.backend.state_at(relay_parent)?;
 		state.storage(key).map_err(RelayChainError::GenericError)
 	}
 
@@ -189,7 +189,7 @@ where
 		relay_parent: PHash,
 		relevant_keys: &Vec<Vec<u8>>,
 	) -> RelayChainResult<StorageProof> {
-		let state_backend = self.backend.state_at(&relay_parent)?;
+		let state_backend = self.backend.state_at(relay_parent)?;
 
 		sp_state_machine::prove_read(state_backend, relevant_keys)
 			.map_err(RelayChainError::StateMachineError)

cumulus/primitives/parachain-inherent/src/mock.rs

@@ -115,7 +115,7 @@ impl MockXcmConfig {
 	) -> Self {
 		let starting_dmq_mqc_head = client
 			.storage(
-				&parent_block,
+				parent_block,
 				&sp_storage::StorageKey(
 					[twox_128(&parachain_system_name.0), twox_128(b"LastDmqMqcHead")]
 						.concat()
@@ -130,7 +130,7 @@ impl MockXcmConfig {
 
 		let starting_hrmp_mqc_heads = client
 			.storage(
-				&parent_block,
+				parent_block,
 				&sp_storage::StorageKey(
 					[twox_128(&parachain_system_name.0), twox_128(b"LastHrmpMqcHeads")]
 						.concat()