The `NeighborPacketWorker` within `client/finality-grandpa` does two
things:
1. It receives neighbor packets from components within
`client/finality-grandpa`, sends them down to the `GossipEngine` in
order for neighboring nodes to receive.
2. It periodically sends out the most recent neighbor packet to the
`GossipEngine`.
In order to send out packets it had a clone to a `GossipEgine` within
an atomic reference counter and a mutex. The `NeighborPacketWorker` was
then spawned onto its own asynchronous task.
Instead of running in its own task, this patch reintegrates the
`NeighborPacketWorker` into the main `client/finality-grandpa` task not
requiring the `NeighborPacketWorker` to own a clone of the
`GossipEngine`.
The greater picture
This is a tiny change within a greater refactoring. The overall goal is
to **simplify** how finality-grandpa interacts with the network and to
**reduce** the amount of **unbounded channels** within the logic.
Why no unbounded channels: Bounding channels is needed for backpressure
and proper scheduling. With unbounded channels there is no way of
telling the producer side to slow down for the consumer side to catch
up. Rephrased, there is no way for the scheduler to know when to favour
the consumer task over the producer task on a crowded channel and the
other way round for an empty channel.
Reducing the amount of shared ownership simplifies the logic and enables
one to use async-await syntax-suggar, given that one does not need to
hold a lock across poll invocations. Using async-await enables one to
use bounded channels without complex logic.
* Implement runtime version checks in `set_code`
Check that the new runtime code given to `set_code` fullfills some
requirements:
- `spec_name` matches
- `spec_version` does not decreases
- `impl_version` does not decreases
- Either `spec_version` and `impl_version` increase
* Make tests almost work
* Some fixes after master merge
* Fix tests
* Add missed file
* Make depedency check happy?
* Remove leftover `sc-executor`
* AHHHHH
* Reset debug stuff
* Remove some 'static
* More 'static
* Some docs
* Update `Cargo.lock`
* Make Proposer instantiation potentially async.
* fix node-service test
* fix basic-authority doc-test
* only block once on futures in test
* use async/await
* reset a couple of versions down from v0.2.0
* Unstablise browser-utils (very new) and grafana-data-source (going to be replaced with prometheus sometime)
* unmark a bunch more client crates for stabilization
* fix versions in Cargo.tomls
* Downgrade network-test
* Set frame-metadata version to `10.0.0`
* Hide and documented storage generator as internal api
* Downgrade `sp-externalities`
* Downgrade `sc-cli`
* Downgrade sc-executor et al to 0.8.0
* Downgrade sp-state-machine to 0.8.0
* Downgrade pallet-contracts et al to 0.8.0
* Downgrade sp-sandbox to 0.8.0
* downgrade pallet-evm to 0.8.0
* Downgrade pallet-staking to 0.8.0
2.0 should be implementation of lazy payout alongside all the fixes of
current module
* Downgrade node-transaction-factory to 0.8.0
* frame pallets are 2.0.0
Co-authored-by: Ashley <ashley.ruglys@gmail.com>
Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Co-authored-by: Sergei Pepyakin <s.pepyakin@gmail.com>
Co-authored-by: Wei Tang <accounts@that.world>
Co-authored-by: thiolliere <gui.thiolliere@gmail.com>
Co-authored-by: Marcio Diaz <marcio@parity.io>
* Switch service to futures03
* Fix tests
* Fix service test and cli
* Re-add Executor trait to SpawnTaskHandle
* Fix node-service
* Update babe
* Fix browser node
* Update aura
* Revert back to tokio-executor to fix runtime panic
* Add todo item
* Fix service tests again
* Timeout test futures
* Fix tests
* nits
* Fix service test
* Remove zstd patch
* Re-add futures01 to aura and babe tests as a dev-dep
* Change failing test to tee
* Fix node
* Upgrade tokio
* fix society
* Start switching grandpa to stable futures
* Revert "Start switching grandpa to stable futures"
This reverts commit 9c1976346237637effc07c13f7d0403daf5e71cf.
* Fix utils
* Revert substrate service test
* Revert gitlab
Co-authored-by: thiolliere <gui.thiolliere@gmail.com>
Instead of having these weird implementation of `BuildStorage for
&ChainSpec` we should just take the `genesis_storage` by ref. The
`BuildStorage` trait changed some time ago to take a self ref anyway,
instead of a self value.
Also fixes warnings in frame-staking
* Select only one zero bid, better ordering of new bids
* Select zero bid as head
* Update comment
* Update frame/society/src/tests.rs
* Add new test, logic not updated yet
* Implement `put_bid` to order same value bids
Note that this extra logic currently does not do anything per the implementation of `binary_search` in Rust.
* Initial sketch of social recovery pallet
* Fix compilation issues
* Use a single total delay, rename stuff
* Check possible overflow
* Copyright bump
* Add mock for tests
* Add basic end to end test
* Add `create_recovery` tests
* Add malicious recovery lifecycle test
* Make clear we check for sorted and unique friends
* Work on some tests, clean up imports
* Change `if let Some(_)` to `ok_or()`
* More tests
* Finish tests, except issue with `on_free_balance_zero`
* Fix `on_free_balance_zero`
* Pallet docs
* Add function/weight docs
* Fix merge master
* OnReapAccount for System too
* Update weight docs
* Allow passthrough to support fee-less extrinsics
* fork-tree: rebalance fork tree by maximum branch height
* fork-tree: add docs for tree rebalancing
* fork-tree: add test
* babe: rebalance epoch changes tree on deserialization
* fork-tree: fix doc
* fork-tree: fix test
We don't use any explicit `#[lang = ...]` items anymore (`panic_fmt`
is replaced with now-stable `#[panic_implementation]`, OOM is handled
via `alloc_error_handler` directly etc.), so I thought it'd be good to
remove it for clarity to limit used nightly features.
* Introduce efficient Hash-based RNG streamer
* Initial draft of the society module
* Introduce a test
* Dual-pot logic
* Vouching
* Use chacha
* Half way through moving to cliff payout.
* Fixes
* Add some tests
* Remove printlns
* Merge remote-tracking branch 'origin/gav-verified-id' into gav-verified-id
# Conflicts:
# frame/identity/src/lib.rs
* Merge remote-tracking branch 'origin/gav-verified-id' into gav-verified-id
# Conflicts:
# frame/identity/src/lib.rs
* Fix `slash_payout`, add test
* Test for multi-slash_payout
* Add docs to `put_bid` function and `bidding_works` test
* Add strikes to test
* Add comments to `rotate_period`
* Implement `suspend_member`
* Off chain iteration of suspended members using linked_map
* Half of suspended candidate
* Finish suspend_candidate, need tests
* Resolve mistakes and feedback, add `suspended_candidate_rejected` test
* Remove logic which increases payout time after un-suspension
* Fix error in `slash_suspended_candidates`, add member check to `vote`
* Fix vouch rewards, dont create zero payouts, add tests for vouch
* Test unvouch
* Unbid tests
* Add lifecycle events, fix `add_member` to update `MembershipChanged`
* Head cannot be removed from society
* Use `add_member` in `found` to ensure `MembershipChanged` is triggered
* Use `Judgement` enum for suspended candidate judgement
* Make society instantiable
* Implement challenges
* Remove extra text in test
* Remove `BlockNumber` return from `slash_payout`
* Add bad vote causes slash test
* Update frame/society/src/lib.rs
Co-Authored-By: thiolliere <gui.thiolliere@gmail.com>
* Add consts to module metadata
* Check `suspended_member` cant bid
* Increase strength of payout check, **must** be a member.
* Start pallet documentation
* Finish docs
* Update library names, use decl_error
* Prevent double bids, add test
* Use `map` for vouching member, and introduce banned vouchers
* Remove leftover docs
* Vouching handles removed member lifecycles w/ tests
* `take` the votes when tallying, add comprehensive checks before vouch or bid
* Check votes are cleaned up
* Check vote is for a valid candidate, add vote event
* Defender vote event
* Fix `judge_suspended_candidate`, add weight docs
* First pass fixes (blank lines, formatting, no operational)
* Bump copyright year
* Make `add_member` infallible
* More feedback updates
* Add storage access complexity
* Fix logic for AutoUnbid
* Complete weight documentation
* Optimize logic which used to result in double storage read.
* Use Bid struct rather than tuple
* Introduce `MaxMembers` configuration constant
* Add comment about fringe scenario where `MaxMembers` could go over, NBD
* Change MaxMembership to configurable storage item with ability for root to update
* Make membership challenges skew toward failure.
If no one at all votes, or the vote is tied, the user will be suspended from society. This means, that the user simply needs to vote for themselves to stay in society assuming no one else participates.
* Refactor `is_candidate`as to avoid possible double storage reads in the future.
* Blank lines
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: thiolliere <gui.thiolliere@gmail.com>
André Silva