Commit Graph

2930 Commits

Author SHA1 Message Date
Stanislav Tkach 2403cf320c Migrate election-phragmen, election contracts and authorship to decl_error (#4479)
* Migrate election-phragmen

* Migrate elections

* Migrate contracts module

* Update authorship module

* Apply suggestions from code review

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2019-12-24 11:11:57 +01:00
gabriel klawitter 9051945505 ci: increase git cloning depth to 100 (#4481)
* ci: increase git cloning depth to 100

* check_runtime: verify shallow git clones to contain origin/master

* check_runtime: fetch master branch
2019-12-23 19:43:05 +01:00
Stanislav Tkach f4a3056167 Change log level for DhtEvent::ValueNotFound from warn to debug (#4485) 2019-12-23 17:23:35 +01:00
Nikolay Volf 10cd358e40 fix warnings in grafana module (#4486) 2019-12-23 17:41:43 +03:00
Gavin Wood 205ddec344 Twitter field for IdentityInfo (in a back-compat way) (#4476) 2019-12-22 23:11:34 +01:00
Gavin Wood 3c70800eab Extend Utility pallet with multisig and pseudonyms (#4462)
* Add subaccounts functionality

* More work

* Multisig prototyped with tests

* Add timepoints to prevent replay

* Remove TODO

* Check for the right owner in cancel.

* Test the timepoint stuff

* Batch works with any origin

* Refactor tuples into structs.

* Finalise function docs/complexity and also add proper weights.

* Fix wasm

* Module-level docs

* Fix typo

* Runtime fix

* Better deposit system; more tests.

* Fix typo

* Switch +1 for -1

* Add Blake2_128Concat; fix insecurity; change return policy.

* Fix typo

* Update frame/utility/src/lib.rs

Co-Authored-By: Shawn Tabrizi <shawntabrizi@gmail.com>

* Update frame/utility/src/lib.rs

Co-Authored-By: Shawn Tabrizi <shawntabrizi@gmail.com>

* Update bin/node/runtime/src/lib.rs

Co-Authored-By: Sergei Pepyakin <sergei@parity.io>

Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
Co-authored-by: Sergei Pepyakin <s.pepyakin@gmail.com>
2019-12-22 20:41:55 +01:00
Wei Tang c3413fdea3 Clean up definition for custom ss58 address formats (#4470)
* Clearer definition for custom ss58 address formats

* Fix subkey compile
2019-12-21 15:34:36 +01:00
Stanislav Tkach 2c2e0d772d Migrate generic-asset, identity and im-online to decl_error (#4473)
* Migrate generic-asset, identity and im-online to decl_error

* Update democracy tests

* Update nicks test
2019-12-21 15:10:29 +01:00
Joshy Orndorff f6cbf4421f Rename ChainSpec field (#4471)
* initial rename

* nitpick: add space in "chain spec"

* Add comment to client spec.
2019-12-20 21:50:18 +01:00
Gavin Wood e6b8a69656 Add ProposalRejected event to Treasury (#4468)
Closes #4467

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2019-12-20 21:35:51 +01:00
Tomasz Drwięga 14a08d430c Add Clone bound to the Origin. (#4472) 2019-12-20 18:43:04 +01:00
Stanislav Tkach 328563f8d4 Migrate membership, nicks, scored-pool and session to decl_error (#4463)
* Migrate membership, nicks, scored-pool and session to decl_error

* Fix tests

* Update frame/scored-pool/src/tests.rs

Co-Authored-By: Shawn Tabrizi <shawntabrizi@gmail.com>

* Remove InsufficientBalance error from scored-pool

* Replace Error::<Test, DefaultInstance> with Error::<Test, _>

Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
2019-12-20 17:12:21 +01:00
Arkadiy Paronyan 9950ea98fc Shared params in CLI API (#4466)
* Common shared parames getter

* Expose more types from `service-builder`

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2019-12-20 16:05:01 +01:00
Bastian Köcher bfad5f3ffc Fix warnings and make CI working again (#4469)
* Fix warnings and make CI working again

* Fix test
2019-12-20 14:47:19 +01:00
Svyatoslav Nikolsky 7d4c6354df use multiple threads in integration tests (#4379) 2019-12-20 12:37:21 +01:00
Bastian Köcher 054607f092 Subkey add support for interactive password (#4465)
* Subkey add support for interactive password

* Support inserting the URI from tty as well
2019-12-20 12:36:55 +01:00
Shawn Tabrizi 4fffe19c28 Update Balances Pallet for decl_error! (#4405)
* Update balances for `decl_error!`

* Update for new `decl_error`

* Fix staking tests

* Use `ok_or` over `match`
2019-12-20 00:23:20 +01:00
André Silva dfe87ec61e babe: remove unused slot_duration variable (#4461) 2019-12-19 17:38:01 +00:00
Stanislav Tkach d46eaf79aa Warn about using --rpc-external and --ws-external options (#4448)
* Warn about using --rpc-external and --ws-external options

* Apply review comments

* Remove links placeholders

* Add links to wiki
2019-12-19 17:57:42 +01:00
Gavin Wood bbda30c7dd Add new event for registering deposits. (#4459) 2019-12-19 17:57:20 +01:00
Shawn Tabrizi 1d04d5a05e Fix Fees in Substrate (#4421)
* Fix fees

* Add comment to explain saturated multiply accumulate

* Fix final fee calculation

* Fix doc

* improve doc

* grumble

* Update tests

* Fix executor tests
2019-12-19 14:03:00 +01:00
Ashley 9a1bb75809 Update grafana-data-source to tokio 0.2 (#4441) 2019-12-19 14:02:07 +01:00
Bastian Köcher 8e393aa5a8 Make decl_error! errors usable (#4449)
* Make `decl_error!` errors usable

This pr implements support for returning errors of different pallets in
a pallet. These errors need to be declared with `decl_error!`.

The pr changes the following:

- Each dispatchable function now returns a `DispatchResult` which is an
alias for `Result<(), DispatchError>`.
- `DispatchError` is an enum that has 4 variants:
  - `Other`: For storing string error messages
  - `CannotLookup`: Variant that is returned when something returns a
  `sp_runtime::LookupError`
  - `BadOrigin`: Variant that is returned for any kind of bad origin
  - `Module`: The error of a specific module. Contains the `index`,
  `error` and the `message`. The index is the index of the module in
  `construct_runtime!`. `error` is the index of the error in the error
  enum declared by `decl_error!`. `message` is the message to the error
  variant (this will not be encoded).
- `construct_runtime!` now creates a new struct `ModuleToIndex`. This
struct implements the trait `ModuleToIndex`.
- `frame_system::Trait` has a new associated type: `ModuleToIndex` that
expects the `ModuleToIndex` generated by `construct_runtime!`.
- All error strings returned in any module are being converted now to `DispatchError`.
- `BadOrigin` is the default error returned by any type that implements `EnsureOrigin`.

* Fix frame system benchmarks
2019-12-19 14:01:52 +01:00
Kian Paimani 0aab5c659e Few extra tests for phragmen (#4451) 2019-12-19 09:24:17 +01:00
Tomasz Drwięga 216f77d91f Document TransactionStatus and fix termination conditions. (#4446)
* Document TransactionStatus and fix termination conditions.

* Update client/rpc-api/src/author/mod.rs

Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>
2019-12-18 21:28:25 +01:00
Leo Arias 06e382b0d4 Fix typo in comment (#4433) 2019-12-18 21:17:22 +01:00
André Silva 1e550b3dac grandpa: fix slow gossip test (#4440) 2019-12-18 14:32:09 +01:00
André Silva 1fc3060feb grandpa: log everything under afg target (#4443) 2019-12-18 14:18:29 +01:00
Robert Habermeier 8f1b5b840d client: Do not set fork sync request via network-gossip (#4439)
The finality-grandpa module needs two sets of functionalities from the
network:

1. Everything gossip related, e.g. event_stream, write_notification, ...

2. The ability to set a fork sync request for a specific block hash.

Instead of embedding (2) inside of (1) this patch extracts (2) from (1)
having finality-grandpa depend on a `Network` that fulfills the
`network_gossip::Network` trait and that can set block sync requests.

On the one hand this improves the overall structure splitting things
that don't logically belong together. On the other hand it does
reintroduce a lot of trait bounds within finality-grandpa.
2019-12-18 14:17:13 +01:00
Robert Habermeier da87c3c1e3 RPCs for reserved peers (#4423)
* RPC forwarders for adding reserved peers

* implement service side of reserved-peer RPCs

* Clean up unnecessary format! invocation

Co-Authored-By: Niklas Adolfsson <niklasadolfsson1@gmail.com>

* add some tests for the new RPC methods

* remove redundant `data` field

Co-Authored-By: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
2019-12-18 14:12:15 +01:00
Weiliang Li 637d95e5ea Add dyn for slog::SerdeValue in telemetry (#4435) 2019-12-18 13:13:59 +01:00
Wei Tang 7af81c29c4 pallet-evm: default implementation for FeeCalculator and ConvertAccountId and separate gas price (#4424)
* Default implementation for FeeCalculator and ConvertAccountId and separate gas price

* Styling fixes and some docs addition

* TruncateConvertAccountId -> HashTruncateConvertAccountId

* Fix compile
2019-12-18 13:13:47 +01:00
Drew Stone d6ce5ae20e Add Edgeware network ID to core/crypto and subkey (#4426)
* Add linear back-off for aura slot workers

* logging

* Use slot from header

* Get network id for Edgeware and add to subkey
2019-12-18 12:51:24 +03:00
Shawn Tabrizi 57c19bcf4e More decl_error! migrations (#4427)
* Update assets to `decl_error`

* Update aura to `decl_error`

* Update authority discovery to `decl_error`

* Update collective to `decl_error`

* Update evm to `decl_error!`

* Fix error with replace

* Revert "Update authority discovery to `decl_error`"

This reverts commit 26e8f3c56656963d847e984c6f2c8e1f88014899.

* Revert "Update aura to `decl_error`"

This reverts commit 8f17c44ca8375a4a755710aaab7ad4d9522c4376.

* Update democracy to `decl_error`

* Update finality-tracker to `decl_error`

* Update grandpa to `decl_error`

* `assert` to `ensure` in dispatchable function
2019-12-18 12:50:21 +03:00
Gavin Wood 9550c845f3 Fix the subkey error message (#4428)
* Fix the subkey error message

* Fix check_benchmarks
2019-12-18 12:48:34 +03:00
Gavin Wood 608d633455 Remove incorrect assumption that runners-up were sorted by account (#4429)
* Remove incorrect assumption that runners-up were sorted by account

* Fix

* Update lib.rs
2019-12-18 12:48:15 +03:00
joe petrowski e6e9faaed6 minor typos in traits docs (#4425) 2019-12-17 21:33:11 +01:00
Shawn Tabrizi 337cae1dde Update Balances Pallet events to help block explorers (#4389)
* Dust moves from reserved <-> free if below ED

* Add dust information to `ReapedAccount` event

* Introduce `BalanceSet` event

* More cleanly written `set_balance` logic
2019-12-17 23:49:00 +08:00
Benjamin Kampmann 9200bfa997 Setting versions locally towards 2.0 release (#4404)
* clean up cargo.toml syntax

* bumping versions to 2.0

* bump networking to 0.8

* move consensus down to 0.8

* bump consensus pallets to 0.8.0, too

* Upping babe and aura pallets

* add remaining, missing version definitions

* missed some
2019-12-17 22:05:50 +08:00
Wei Tang 33fa445db0 docs: fix link to babe (#4418) 2019-12-17 14:04:57 +01:00
Niklas Adolfsson 7c6ad9dd1c [client cli] generic blocknumber (#4376)
* rewrite me

* [cli]: make `BlockNumber` generic

* cleanup
2019-12-17 11:45:20 +01:00
Bastian Köcher e19f5adfb7 Fix frame_system renaming in contruct_runtime (#4412)
* Fix contruct_runtime

* Update lib.rs

* Update event.rs

* Update event.rs

* Update event.rs

* Update event.rs

* Update event.rs

* Update event.rs

* Update event.rs

Back to where we started

* Update chain_spec.rs

* Update genesis.rs

* Fix it properly
2019-12-17 10:54:50 +01:00
Svyatoslav Nikolsky cd718cd77d recover light client integration tests (#4377) 2019-12-17 08:45:04 +01:00
Gavin Wood 48860a768b Fix naming of utility crate (it's a legit pallet) (#4408)
* Fix naming of utility crate (it's a legit pallet)

* Additional bits
2019-12-17 14:25:52 +08:00
Stanislav Tkach f20bb8b196 Use decl_error in stacking module (#4387) 2019-12-17 14:03:24 +08:00
Stanislav Tkach 7e9253d35d Use decl_error in the treasure module (#4370) 2019-12-17 14:03:08 +08:00
thiolliere 583b0e3c69 impl iter_prefix on doublemap (#4388) 2019-12-17 13:41:25 +08:00
Shawn Tabrizi 7e3872c064 Make sudo use decl_error! (#4369)
* Make sudo use `decl_error`

* copy pasta error

* Update to use `as_str`

* Add doc

* Add back `decl_error`
2019-12-17 00:32:40 +01:00
Tomasz Drwięga 8778ca7dc8 [big refactor] Remove crate aliasing. (#4395)
* Rename: Phase 1.

* Unify codec.

* Fixing: Phase 2

* Fixing: Phase 3.

* Fixing: Phase 4.

* Fixing: Phase 5.

* Fixing: Phase 6.

* Fixing: Phase 7.

* Fixing: Phase 8. Tests

* Fixing: Phase 9. Tests!!!

* Fixing: Phase 10. Moar tests!

* Finally done!

* More fixes.

* Rename primitives:: to sp_core::

* Apply renames in finality-grandpa.

* Fix benches.

* Fix benches 2.

* Revert node-template.

* Fix frame-system in our modules.
2019-12-16 20:36:49 +08:00
Gavin Wood f14d98a439 Identity module enhancements (#4401)
* Updates; not yet tested.

* Fix and add tests

* Add test

* Update a few comments
2019-12-16 20:36:08 +08:00