29d7e0e6c1
Remove waterfall CI trigger ( #7519 )
...
* fix (CI): fix the triggered project name
* fix (CI): debug run
* fix (CI): debug run 2
* fix (CI): revert debug2
* Revert "fix (CI): debug run"
This reverts commit 96866a953da797ef6e0689374eecc0d8cba4627d.
* CI: remove the trigger
2020-12-08 18:53:22 +01:00
679a9bac5a
Pin md link checker's version ( #7697 )
...
* CI: pin md link checker's version to the previous release
* CI: add a whitelist for allowed GH actions pins
* CI: try master tip [skip ci]
* CI: return to a previous markdown-link-check dependency version [skip ci]
* CI: substitute %20 for a literal space [skip ci]
* CI: substitute %20 for a literal space
2020-12-08 18:00:36 +01:00
48d5156357
client: remove duplicate implementation of block_status ( #7694 )
2020-12-08 14:07:24 +01:00
39a776cd00
Streamline frame_system weight parametrization ( #6629 )
...
* Basic weights builder.
* Fixing WiP
* Make the tests work.
* Fix weights in node/runtime.
* WiP.
* Update pallets with new weights parameters.
* Validate returns a Result now.
* Count mandatory weight separately.
* DRY
* BREAKING: Updating state root, because of the left-over weight-tracking stuff
* Update tests affected by Mandatory tracking.
* Fixing tests.
* Fix defaults for simple_max
* Update frame/system/src/weights.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Rework the API a bit.
* Fix compilation & tests.
* Apply suggestions from code review
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Add extra docs & rename few things.
* Fix whitespace in ASCII art.
* Update frame/system/src/limits.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Fix max_extrinsic calculations.
* Fix conflicts.
* Fix compilation.
* Fix new code.
* re-remove generic asset
* Fix usage.
* Update state root.
* Update proxy.
* Fix tests.
* Move weights validity to integrity_test
* Remove redundant BlockWeights.
* Add all/non_mandatory comment
* Add test.
* Remove fn block_weights
* Make the macro prettier.
* Fix some docs.
* Make max_total behave more predictabily.
* Add BlockWeights to metadata.
* fix balances test
* Fix utility test.
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
Co-authored-by: Benjamin Kampmann <ben@gnunicorn.org >
Co-authored-by: thiolliere <gui.thiolliere@gmail.com >
2020-12-08 13:18:34 +01:00
f6198b4c1b
implement more convertion on NumberOrHex ( #7682 )
2020-12-08 10:10:46 +01:00
588461f52a
Make sure the companion CI test fails on any error ( #7683 )
2020-12-07 16:48:54 +01:00
8e9f9057fe
Update Cargo.toml ( #7627 )
...
On behalf of dependabot, because we use 1.4.x in it clashes with this.
2020-12-07 15:32:16 +00:00
22fdd3a6ea
Fix #7629 ( #7680 )
...
* Fix #7629
* Update client/network/src/service.rs
Co-authored-by: Max Inden <mail@max-inden.de >
Co-authored-by: Max Inden <mail@max-inden.de >
2020-12-07 15:04:32 +01:00
1ca5e8856b
Fix two potential connection poisonings ( #7677 )
2020-12-07 10:10:21 +01:00
d9b1b14769
Adds support for tuples in runtime-interface ( #7672 )
2020-12-06 15:14:19 +01:00
4b8cee9e55
Add Standard Error to Weight Template ( #7652 )
...
* Add standard error to weight template
* fix test compile
2020-12-04 22:09:19 +01:00
80af50b830
Features needed for reserve-backed stablecoins ( #7152 )
...
* Features needed for reserve-backed stablecoins
* Builds & tests.
* Double map for an efficient destroy.
* Update frame/assets/src/lib.rs
Co-authored-by: Nikolay Volf <nikvolf@gmail.com >
* ED/zombie-count/refs
Feature: ED/minimum balance enforcement
Feature: enforce zombie count
Feature: allow system-alive accounts to exist, but add reference
* Update frame/assets/src/lib.rs
Co-authored-by: Nikolay Volf <nikvolf@gmail.com >
* Update frame/assets/Cargo.toml
Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com >
* Docs
* Some tests
* More tests
* Allow for max_zombies to be adjusted
* Test for set_max_zombies
* Tests and a couple of fixes
* First few benchmarks
* Benchmarks.
* Fix error message in test
* Fixes
* Fixes
* Fixes
* cargo run --release --features runtime-benchmarks --manifest-path bin/node/cli/Cargo.toml -- benchmark --chain dev --steps 50 --repeat 20 --extrinsic * --execution=wasm --wasm-execution=compiled --output ./bin/node/runtime/src/weights --header ./HEADER --pallet pallet_assets
* Update frame/assets/src/lib.rs
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com >
* Fixes
* Fixes
* Fixes
* cargo run --release --features runtime-benchmarks --manifest-path bin/node/cli/Cargo.toml -- benchmark --chain dev --steps 50 --repeat 20 --extrinsic * --execution=wasm --wasm-execution=compiled --output ./bin/node/runtime/src/weights --header ./HEADER --pallet pallet_assets
* Fixes
* Update default weight
* Add proper verification to benchmarks
* minor improvements to tests
* Update frame/assets/src/benchmarking.rs
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Fix
* New weights system
* fix compile
* cargo run --release --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_assets --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/assets/src/weights.rs --template=./.maintain/frame-weight-template.hbs
Co-authored-by: Nikolay Volf <nikvolf@gmail.com >
Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com >
Co-authored-by: Parity Benchmarking Bot <admin@parity.io >
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com >
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
2020-12-04 16:57:09 +01:00
947b82df68
Don't panic on a sink error ( #7666 )
2020-12-03 17:11:49 +01:00
2877c038cf
Use block requests to check if block responses are correct ( #7653 )
...
* Use block requests to check if block responses are correct
Before this pr sync relied on recently announced blocks to check if a
given peer response is correct. However this could lead to situations
where we requested a block from a peer and it gave us the requested, but
we rejected the response because this peer never send us an announcement
for the given block. See the added tests for a reproduction of the
problem.
With this pr, we now take the block request to check if a given response
matches the request. A node should not send us a block response
without a request anyway.
Essentially there is still a bug, because as you see in the test, we are
requesting block 2, while we already have this block imported. It even
happens that we request a block from the network that we have authored.
However a fix for this would require some more refactoring of the sync code.
* Revert change
* Give the test a proper name
* Add moar logging
* Move cheaper checks
* Move checks to common place
2020-12-03 15:49:23 +01:00
56c97ce604
RPC to allow setting the log filter ( #7474 )
...
* Add filter reload handle
* add RPC, move logging module from cli to tracing
* remove dup fn
* working example
* Update client/rpc-api/src/system/mod.rs
Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com >
* Prefer "set" to "reload"
* Re-enable the commented out features of the logger
* Remove duplicate code
* cleanup
* unneeded lvar
* Bump to latest patch release
* Add new CLI option to disable log filter reloading,
Move profiling CLI options to SharedParams
* Apply suggestions from code review
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Applied suggestions from reviews
* Fix calls to init_logger()
* Handle errors when parsing logging directives
* Deny `system_setLogFilter` RPC by default
* One more time
* Don't ignore parse errors for log directives set via CLI or RPC
* Improve docs
* Apply suggestions from code review
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/config.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* fix merge errors
* include default directives with system_setLogFilter RPC,
implement system_rawSetLogFilter RPC to exclude defaults
* docs etc...
* update test
* refactor: rename fn
* Add a test for system_set_log_filter – NOTE: the code should likely change to return an error when bad directives are passed
* Update client/cli/src/lib.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Address review grumbles
* Add doc note on panicking behaviour
* print all invalid directives before panic
* change RPCs to: addLogFilter and resetLogFilter
* make CLI log directives default
* add comments
* restore previous behaviour to panic when hard-coded directives are invalid
* change/refactor directive parsing
* fix line width
* add test for log filter reloading
* Apply suggestions from code review
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* finish up suggestions from code review
* improve test
* change expect message
* change fn name
* Apply suggestions from code review
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Apply suggestions from code review
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* add docs, remove unused fn
* propagate Err on invalid log directive
* Update tracing-subscriber version
* Improve docs for `disable_log_reloading` CLI param
Co-authored-by: Matt <mattrutherford@users.noreply.github.com >
Co-authored-by: David <dvdplm@gmail.com >
Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com >
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
2020-12-03 13:17:44 +00:00
f717a20446
Changed map to filter map so that Phragmen ignores empty voters ( #7378 )
...
* Changed map to filter map so that Phragmen ignores empty voters
* Resolve flaws and added test case
* Updated test
2020-12-03 12:44:53 +00:00
3ce406c140
Update ss58 registry for Phala network ( #7654 )
2020-12-03 12:22:03 +01:00
7e83b7a7f2
Refactor StorageInstance trait to be usable more easily ( #7659 )
...
* refactor StorageInstance to be usable without macros
* better description
* update types doc
* Update frame/support/src/traits.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
2020-12-03 10:51:08 +00:00
b149b1fdc0
*: Update to libp2p v0.31.2 ( #7658 )
2020-12-02 17:45:49 +00:00
610585d17f
Remove sc_network::NetworkService::register_notifications_protocol and partially refactor Grandpa tests ( #7646 )
...
* Remove sc_network::NetworkService::register_notifications_protocol
* Missing calls to .into()
* Wrong crate name
* [WIP] Fix Grandpa tests
* One more passing
* One more. Two to go.
* This one was actually already passing 🎉
* Last one compiles
* Progress
* grandpa: fix voter_persists_its_votes test
* Restore other tests
* Try spawn future later
Co-authored-by: André Silva <andrerfosilva@gmail.com >
2020-12-02 16:35:48 +00:00
3761fe3161
Show reputation changes when dropping peer ( #7655 )
...
* Show reputation changes when dropping peer
* Print all
2020-12-02 16:34:05 +00:00
9d43568e4e
Use unreleased trybuild to fix CI ( #7656 )
2020-12-02 16:53:44 +01:00
b737ebba6d
fork-tree: fix tree rebalancing ( #7616 )
...
* fork-tree: rebalance tree when inserting inner node
* fork-tree: fix tests for new rebalancing behavior
* fork-tree: fix node iterator initial state
* grandpa: fix tests
2020-12-01 18:49:09 +00:00
6079fabdd3
Remove a stray file. ( #7649 )
2020-12-01 13:40:53 -05:00
e2b486cfb1
minor fix and improvements on localkeystore ( #7626 )
...
* minor fixes and improvements on localkeystore
* fixing tests
* update docs
2020-12-01 14:35:06 +00:00
e0016473a9
remove unused deps pulled by parity-util-mem ( #7635 )
...
* remove unused deps pulled by parity-util-mem
* fix a warning about unused Cargo key
2020-12-01 12:50:27 +00:00
22a28db957
Fix cargo clippy warning in peerset. ( #7641 )
...
* Fix cargo clippy warning in peerset.
* Update client/peerset/src/lib.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Apply suggestions from code review
Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com >
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com >
2020-12-01 10:58:00 +00:00
762b4b25d0
Fix CI Link Check ( #7639 )
...
* fix trigger fingers
* more
* Update frame/example-offchain-worker/README.md
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com >
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com >
2020-11-30 22:01:18 +00:00
15b0dece54
Renames of Trait to Config in README.md, weight templates and few minor ones ( #7636 )
...
* manual rename
* renamse in README.md
* fix template
2020-11-30 20:33:49 +00:00
35efc8e4b0
Fix bad state transition with DisabledPendingEnable+OpenDesiredByRemote ( #7638 )
2020-11-30 17:43:47 +00:00
4ccf6672b1
resolve unresolved error nits of #7617 ( #7631 )
...
* handle executor should_panic test better
* Revert "reduce should panic, due to extended error messages"
This reverts commit c0805940184a62cd9302603ad911c3591e70a60c.
* remove excessive constraints
* remove duplicate documentation messages for error variants
* reduce T: constraints to the abs minimum
* whoops
* fewer bounds again
Co-authored-by: Bernhard Schuster <bernhard@parity.io >
2020-11-30 16:53:33 +01:00
1cbfc9257f
Rename pallet trait Trait to Config ( #7599 )
...
* rename Trait to Config
* add test asserting using Trait is still valid.
* fix ui tests
2020-11-30 14:34:54 +00:00
dd3c84c362
Fix wrong value put for pending_opening ( #7633 )
...
* Fix wrong value put for pending_opening
* Oops, didn't even try compiling it
2020-11-30 15:05:01 +01:00
7753a2250f
sudo_as should return a result (#7620 )
2020-11-30 13:57:15 +01:00
007254c957
Bump console_log from 0.1.2 to 0.2.0 ( #7623 )
...
Bumps [console_log](https://github.com/iamcodemaker/console_log ) from 0.1.2 to 0.2.0.
- [Release notes](https://github.com/iamcodemaker/console_log/releases )
- [Commits](https://github.com/iamcodemaker/console_log/commits )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-11-30 13:51:54 +01:00
a2b14d10fb
sc-network: Log outgoing notifications too ( #7624 )
...
* Log outgoing notifications too
* Update client/network/src/protocol/generic_proto/handler.rs
Co-authored-by: Max Inden <mail@max-inden.de >
Co-authored-by: Addie Wagenknecht <addie@nortd.com >
Co-authored-by: Max Inden <mail@max-inden.de >
2020-11-30 10:52:08 +00:00
f6dc35284f
Change TRACING_SET to static ( #7607 )
...
* change TRACING_SET to static
* Update primitives/io/src/lib.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* modify test with nested spans
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
2020-11-28 09:40:24 +01:00
96461be248
network: don't force send block announcements ( #7601 )
2020-11-27 22:37:38 +00:00
8c7d217091
chore/error: remove from str conversion and add deprecation notificat… ( #7472 )
...
* chore/error: remove from str conversion and add deprecation notifications
* fixup changes
* fix test looking for gone ::Msg variant
* another test fix
* one is duplicate, the other is not, so duplicates reported are n-1
* darn spaces
Co-authored-by: Andronik Ordian <write@reusable.software >
* remove pointless doc comments of error variants without any value
* low hanging fruits (for a tall person)
* moar error type variants
* avoid the storage modules for now
They are in need of a refactor, and the pain is rather large
removing all String error and DefaultError occurences.
* chore remove pointless error generic
* fix test for mocks, add a bunch of non_exhaustive
* max line width
* test fixes due to error changes
* fin
* error outputs... again
* undo stderr adjustments
* Update client/consensus/slots/src/lib.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* remove closure clutter
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* more error types
* introduce ApiError
* extract Mock error
* ApiError refactor
* even more error types
* the last for now
* chore unused deps
* another extraction
* reduce should panic, due to extended error messages
* error test happiness
* shift error lines by one
* doc tests
* white space
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Into -> From
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* remove pointless codec
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* avoid pointless self import
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: Bernhard Schuster <bernhard@parity.io >
Co-authored-by: Andronik Ordian <write@reusable.software >
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
2020-11-27 18:37:53 +00:00
6722a83ba6
Forward storage changes in manual seal ( #7614 )
...
This prevents nodes from executing the same block 2 times.
2020-11-27 17:36:58 +01:00
07c173af63
Add Key Subcommand to node-template ( #7615 )
2020-11-27 16:54:45 +01:00
b4ee48ee18
Upgrade to libp2p-0.31. ( #7606 )
...
* Upgrade to libp2p-0.31.
* Address line width.
* Add generous incoming connection limit.
* Remove old noise configuration.
2020-11-27 14:29:18 +00:00
4f97481da7
Remove RpcMetrics weirdness ( #7608 )
...
* Remove `RpcMetrics` weirdness
The metrics was returning an error when prometheus was not given. This
was a really weird setup, especially when compared to all other metrics
that just do nothing if there is no registry.
* Fix browser build
2020-11-27 10:24:34 +01:00
6af3283bc4
Bump directories from 2.0.2 to 3.0.1 ( #7609 )
...
Bumps [directories](https://github.com/soc/directories-rs ) from 2.0.2 to 3.0.1.
- [Release notes](https://github.com/soc/directories-rs/releases )
- [Commits](https://github.com/soc/directories-rs/commits )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-11-27 09:40:11 +01:00
d698d01378
Inform sync explicitly about new best block ( #7604 )
...
* Inform sync explicitly about new best block
Instead of "fishing" the new best block out of the processed blocks, we
now tell sync directly that there is a new best block. It also makes
sure that we update the corresponding sync handshake to the new best
block. This is required for parachains as they first import blocks and
declare the new best block after being made aware of it by the relay chain.
* Adds test
* Make sure async stuff had time to run
2020-11-26 16:33:17 +00:00
769f1981cb
Add small header cache ( #7516 )
...
* Remove header query
* Header cache
* Fix potential race issue
* Simplify status query
2020-11-25 23:07:51 +00:00
f590b06fab
remove std feature flags for assert macros ( #7600 )
...
* remove std feature flags for assert macros
* re-add note about availability in no_std envs
2020-11-25 23:48:47 +01:00
5774fea2f7
Bump rpassword from 4.0.5 to 5.0.0 ( #7597 )
...
Bumps [rpassword](https://github.com/conradkleinespel/rpassword ) from 4.0.5 to 5.0.0.
- [Release notes](https://github.com/conradkleinespel/rpassword/releases )
- [Commits](https://github.com/conradkleinespel/rpassword/compare/v4.0.5...v5.0.0 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-11-25 10:59:13 +01:00
31f9a6812a
Fix notifications sometimes not being sent ( #7594 )
...
* Fix notifications sometimes not being sent
* Add comment
2020-11-25 09:15:37 +00:00
4885992d7b
node-template: add aura to light block import pipeline ( #7595 )
...
added aura to block import pipeline
2020-11-25 09:50:13 +01:00
Denis Pisarev