4c984500a7
Storage benchmarking ( #10897 )
...
* WIP
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* WIP: DB benchmarking
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* WIP
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* WIP
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Simplify code
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Remove old files
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Remove old files
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Minimize changes
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add license
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Remove dependencies
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Extend template
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Linter
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Linter
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Beauty fixes
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Remove default
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Add feature
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Remove seed
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* CI wakeup
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Review fixes
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Adding doc
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Adding doc
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Improve template
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Do not expose columns
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix ColumnId
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Nicer template prints
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Cleanup
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix json path
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Simplify `bench_write` logic
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Invert tx before the second commit
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2022-02-25 19:30:57 +00:00
d551fe6613
sc-cli: Fix bugs after switching to clap3 ( #10920 )
...
* sc-cli: Fix bugs after switching to clap3
Before switching to clap3 we support cli options like `--reserved-nodes A B` and after you needed to
pass `--reserved-nodes` cli option multiple times `--reserved-nodes A --reserved-nodes B`. This is
fixed by setting `multiple_occurrences(true)` option. This also done for all the other `Vec` cli
options in `sc-cli`. Besides that `--sync` wasn't supporting case insensitive parsing of the value.
This is now also supported. For both regressions a test is added. Besides that the pr removes all
the `rename_all = PascalCase` attributes, because they are not needed. All other `ArgEnum`s were
checked and all are already using `ignore_case(true)`.
* Bring back `PascalCase`, because otherwise it falls back to `kebab-case`...
2022-02-25 16:01:33 +01:00
535325d2e6
Upgrading parity-scale-codec to v3 ( #10825 )
...
* Upgraded dependencies
* Adapting code to scale v3
* Empty commit to trigger CI
* Triggering CI
* Fixing UI test
* Remove superfluous dev-dep added by #9228
* Cryout for CI
2022-02-24 15:34:34 +01:00
eeb267e1d6
No longer generate specs with consensus_engine field ( #10346 )
...
* No longer generate specs with consensus_engine field
* #[allow(unused)]
2022-02-24 12:05:08 +00:00
ba81ba8048
Get rid of unnecessary use of async-std in non-test code ( #10891 )
2022-02-24 11:30:25 +00:00
9552835ccd
Factor DB weights out into their own files ( #10908 )
...
* Factor DB weights out into their own files
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Review fixes
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix CI
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Weights in own mod
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2022-02-23 19:58:53 +00:00
26ec5d71c8
Clean obsolete BABE's weight data ( #10748 )
...
* Clean obsolete BABE weight data
* Take out test assertion from check closure
* Optimize metadata access using `HeaderMetadata` trait
* Apply suggestions from code review
* Introduce finalize and import pre-commit synchronous actions
* Do not hold locks between internal methods calls
* Remove unused generic bound
* Apply suggestions from code review
* Register BABE's pre-commit actions on `block_import` instead of `start_babe`
* PreCommit actions should be `Fn` instead of `FnMut`
* More robust safenet in case of malformed finality notifications
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com >
2022-02-23 19:58:33 +01:00
a2b80edf12
Replace libsecp256k1 with k256 in FRAME related code ( #10883 )
...
* Replace libsecp256k1 with k256 in beefy-mmr
* Port of FRAME `contracts` benchmarking from `libsecp256k1` to `k256`
* Newtype to allow `Pcg32` rng usage with `k256` in contracts benchmarks
* Use `sp-io::crypto` to generate dummy keys in `contracts` bechmarks
* More compact code
* Cargo fmt
* Build `sp-keystore` only for dev profile
* Move public key generation back to the `map`
2022-02-23 10:17:47 +01:00
2561e11ed7
consensus-slots: cleanup SlotDuration config ( #10878 )
...
* consensus-slots: cleanup the SlotDuration config
* fix tests
* address review comments
2022-02-22 19:39:16 +00:00
f00404bfd6
staking: Remove SessionInterface supertrait ( #10901 )
2022-02-22 14:38:34 +00:00
19e42a88a1
state-machine: Move all functionality from trie backend to the essence ( #10904 )
...
* state-machine: Move all functionality from trie backend to the essence
This is required for some future changes of me and it also makes more sense to have all the
functionality inside the essence. Besides that it changes the child root cache to directly
cache the hash.
* Update primitives/state-machine/src/trie_backend_essence.rs
Co-authored-by: cheme <emericchevalier.pro@gmail.com >
* FMT
Co-authored-by: cheme <emericchevalier.pro@gmail.com >
2022-02-22 14:15:57 +00:00
939d1b089c
Rename Uniques Error::Unknown to something more sensible ( #10895 )
...
* Rename Uniques Error::Unknown to something more sensible
* Typos
* Typos
* fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* Fix tests
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
* fmt
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io >
2022-02-22 10:42:46 +00:00
eb5f07a2e5
contracts: Allow stack height metering to be disabled ( #10877 )
...
* Allow stack height metering to be disabled
* cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_contracts --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/contracts/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_contracts --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/contracts/src/weights.rs --template=./.maintain/frame-weight-template.hbs
Co-authored-by: Parity Bot <admin@parity.io >
2022-02-22 09:10:38 +00:00
2893be8321
make submissions pub ( #10899 )
2022-02-22 09:20:29 +01:00
7e8ff788b0
tracing: Adds init_for_tests ( #10893 )
...
This function is useful for tests. It will enable `TRACE` logging and also uses the libtest aware writer.
2022-02-21 13:08:24 +01:00
8159c85b85
staking: Clarify reward calc docs ( #10890 )
2022-02-21 00:50:25 +00:00
9e12a0e86d
Slots: Log total proposing duration as milliseconds ( #10886 )
...
Parachains have currently a total proposing time of 500ms, so it this
currently always prints `0`. While actually the value is not `0` ;)
2022-02-20 01:49:49 +00:00
f3f617bd35
Introduce BoundedVec::iter_mut ( #10884 )
...
* Introduce iters into BoundedVec
* Fix
* Remove unneeded funcs
* Update frame/support/src/storage/bounded_vec.rs
* Update frame/support/src/storage/bounded_vec.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
2022-02-19 12:02:47 +01:00
b9a20ce86b
Further reduce the CPU overhead of networking metrics ( #10875 )
...
* Simplify `num_connected_peers`
* Track requested peer counts
* Revert "Track requested peer counts"
This reverts commit 9f1c8704353df6afc17ed7e9f4ab8d8e29466ae4.
* Remove `substrate_sub_libp2p_peerset_num_requested` metric
* Remove two unused functions that I forgot to get rid of in previous commit
2022-02-18 12:35:43 +00:00
2777d4a154
Remove old lock file ( #10879 )
2022-02-18 09:03:18 +00:00
c498215866
Slots: Ensure that a race betwen finalized and best number is taken care off ( #10876 )
2022-02-17 17:05:18 +01:00
f5af00fe1b
Track allowed requests for state/warp sync ( #10843 )
...
* Track allowed requests for state/warp sync
* Added missing allowed_requests resets
* Apply suggestions from code review
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* fmt
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
2022-02-17 11:37:54 +00:00
1a61cd40fa
sc-executor: Improve logging ( #10869 )
...
Improves the logging by switching to `tracing` for a better log output. Besides that, it also adds a
trace for the function being executed.
2022-02-16 19:39:22 +00:00
ba8c882a7a
Tidy Democracy ( #10867 )
...
* add test
* Assorted refactorings
* complete test
* saturating math
* final check
* use `default`
Co-authored-by: Gav Wood <gavin@parity.io >
2022-02-16 15:57:54 +00:00
1a744befd4
Measure per byte and not kb for certain benchmarks ( #10863 )
2022-02-16 10:49:31 +00:00
6b7eb2e2d7
refactor election score ( #10834 )
...
* refactor election score
* Test for ord
* remove reference
* vec -> slice
* change iter to iter_by_significance
* improve doc
* fix typo
* add explanation about [u128; 3]
* consolidate threshold and epsilon
* random fixes
* rename
* remove Into
* make iter_by_sig private
* remove vec
* Fix tests
2022-02-16 10:40:16 +00:00
9d8e5639d5
add llvm ( #10864 )
2022-02-16 10:02:35 +00:00
db5da0950b
Use fully qualified sytnax for retain_mut ( #10865 )
2022-02-16 10:53:10 +01:00
962cab60d6
sp-core-hashing: use the digest::Digest trait to handle the hashing function uniformly ( #10835 )
...
* sp-core-hashing: use sha3 instead of tiny-keccak
Signed-off-by: koushiro <koushiro.cqx@gmail.com >
* use blake2 instead of blake2-rfc
Signed-off-by: koushiro <koushiro.cqx@gmail.com >
* improve som hashing of sp-core and sp-api-proc-macro
Signed-off-by: koushiro <koushiro.cqx@gmail.com >
* Some nits
Signed-off-by: koushiro <koushiro.cqx@gmail.com >
* cargo fmt
Signed-off-by: koushiro <koushiro.cqx@gmail.com >
2022-02-16 08:26:53 +00:00
ee6223327c
Reduce CPU overhead of gossip ( #10859 )
2022-02-16 04:14:00 +00:00
9a78839696
Mark sync_state_genSyncSpec JSON-RPC as safe ( #10832 )
...
* Mark sync_state_genSyncSpec JSON-RPC as safe
* Note that parameter is unused
* Ideally I'd wait for compilation to be finished before pushing, but it's really taking a long time
* Remove deny_unsafe parameter
* Remove unused dependency
2022-02-15 21:21:34 +00:00
6f53b974b2
Fix beefy mock ecdsa keys ( #10854 )
...
Compressed ECDSA keys requires to have 0x02 or 0x03 as their first byte
in order to allow public key recovery.
Nevertheless the test was working because of the `unwrap_or_default()`
at the end of the conversion routine (i.e. the invalid keys were
converted to an empty vector).
2022-02-15 14:19:39 +01:00
4519145df5
[ci] fix publish-rustdocs ( #10858 )
2022-02-15 13:29:26 +01:00
43c3e709f9
Enable the parking_lot feature for tokio ( #10855 )
2022-02-15 11:53:45 +00:00
b82cfbac4d
contracts: Fix seal_call weights ( #10796 )
...
* Fix call weights
* Fix instantiate benchmark
* cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_contracts --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/contracts/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* Remove stale and superflous comments
* `decrement_refcount` should be infallible
* Don't hardcode increment_refcount, decrement_refcount
* Rename CopyIn/CopyOut
* Fix warning in tests
Co-authored-by: Parity Bot <admin@parity.io >
2022-02-15 08:56:22 +00:00
47622d6912
wasm-builder: Support latest nightly ( #10837 )
...
* wasm-builder: Support latest nightly
With latest nightly, aka rust version 1.60+ namespaced features are added. This changes the handling
of optional dependencies. We currently have features that enable optional dependencies when `std` is
enabled. This was before no problem, but now the wasm-builder detects them as enabled. To support
the transition period until 1.60 is released as stable, this pr adds an heuristic to not enable these
optional crates in the wasm build when they are enabled in the `std` feature. This heuristic fails
when someones enables these optional dependencies from the outside as well as via the `std` feature,
however we hope that no one is doing this at the moment. When namespaced features are enabled, these
dependencies needs to be enabled using `dep:dependency-name` to solve this properly.
https://doc.rust-lang.org/cargo/reference/unstable.html#namespaced-features
* Remove accidentally added features
2022-02-14 21:12:48 +01:00
fdd49f072c
Remove u32_trait ( #10850 )
...
* Remove `u32_trait`
This trait only existed because there wasn't any const generic support at time of creation. However,
we now have support for it :)
* FMT
2022-02-14 20:12:25 +00:00
888131b651
subkey: Support --version cli command ( #10853 )
...
* subkey: Support `--version` cli command
* FMT 🤦
2022-02-14 20:31:52 +01:00
ac841927b8
fix broken link ( #10846 )
2022-02-13 23:14:32 +01:00
89d218448c
Don't create DB leaves when syncing historic blocks ( #10844 )
...
* Don't create DB leaves when syncing historic blocks
* Changed leaves check and added test
* fmt
2022-02-11 22:28:10 +01:00
7393076df2
build-script-utils: allow reading the git commit hash from env var ( #10845 )
...
* build-script-utils: allow reading the git commit hash from env var
* build-script-utils: make the env var name substrate specific
2022-02-11 19:38:39 +00:00
89dfae9530
allow trailing comma ( #10841 )
2022-02-11 14:38:58 +00:00
b932e27e5b
Fix reentrancy of FrozenBalance::died hook ( #10473 )
...
* assets: execute `died` hook outside of mutate
Signed-off-by: Oliver Tale-Yazdi <oliver@tasty.limo >
* assets: extend tests for `died` hook
Signed-off-by: Oliver Tale-Yazdi <oliver@tasty.limo >
* assets: update doc of FrozenBalance::died
Signed-off-by: Oliver Tale-Yazdi <oliver@tasty.limo >
* assets: review fixes
- fix cases where `died` should not have been called
- use `Option<DeadConsequence>` instead of `DeadConsequence`
Signed-off-by: Oliver Tale-Yazdi <oliver@tasty.limo >
* assets: update comment in mock.rs
Signed-off-by: Oliver Tale-Yazdi <oliver@tasty.limo >
* assets: return `Remove` in dead_account
The return value is ignored in the only case that it is produced
by a call, but having it this way makes it more understandable.
Signed-off-by: Oliver Tale-Yazdi <oliver@tasty.limo >
2022-02-11 13:17:38 +00:00
e026077505
Reduce overhead of generating network event metrics ( #10839 )
2022-02-11 11:35:35 +00:00
b4b69798f3
Show Network ID when creating and inspecting ( #10838 )
...
Signed-off-by: Antonio Yang <yanganto@gmail.com >
2022-02-11 09:14:13 +00:00
145abd7991
Separate wasmi and wasmer sandbox implementations into their own modules ( #10563 )
...
* Moves wasmi specific `ImportResolver` and `MemoryTransfer` impls to submodule
* Splits context store environmental, moves impl `Externals` to wasmi backend
* Adds wasmer sandbox backend stub module
* Move sandbox impl code to backend specific modules
* Moves wasmi stuff
* Fixes value conversion
* Makes it all compile
* Remove `with_context_store`
* Moves `WasmerBackend` to the impl
* Reformat the source
* Moves wasmer MemoryWrapper
* Reformats the source
* Fixes mutability
* Moves backend impls to a submodule
* Fix visibility
* Reformat the source
* Feature gate wasmer backend module
* Moves wasmi memory allocation to backend module
* Rename WasmerBackend to Backend
* Refactor dispatch result decoding, get rid of Wasmi types in common sandbox code
* Reformat the source
* Remove redundant prefixes in backend functions
* Remove wasmer-sandbox from default features
* Post-review changes
* Add conversion soundness proof
* Remove redundant prefix
* Removes now redundant clone_inner
* Add `Error::SandboxBackend`, refactor invoke result
* Fix comments
* Rename `Error::SandboxBackend` to `Sandbox`
* Simplifies logic in `wasmer_backend::invoke`
* Fixes memory management
2022-02-11 08:32:06 +00:00
e70ffbf44d
Upgradable contracts using set_code function ( #10690 )
...
* poc logic
* set_code_hash impl, tests, benchmark
* Address @xgreenx's comments
* Move func defs closer to set_storage
* Check if code exists
- increment/decrement codehash refcount
* Document error for non-existing code hash
* Revert unrelated change
* Changes due to @athei's review
* Fix error handling
- comment errors: ReturnCodes
- update mock ext implementation
- return Error::CodeNotFound when no code for such hash
* Emit ContractCodeUpdated when setting new code_hash
* Address @athei's comments
* Move related defs to the bottom
* Minor comment update
Co-authored-by: Alexander Theißen <alex.theissen@me.com >
* Improve docs
* Improve docs
* Update frame/contracts/src/wasm/runtime.rs
Co-authored-by: Alexander Theißen <alex.theissen@me.com >
* Refactor set_code_hash test
* Minor change to benchmark
Co-authored-by: Alexander Theißen <alex.theissen@me.com >
* Minor change to benchmark
Co-authored-by: Alexander Theißen <alex.theissen@me.com >
* Minor comment refactor
Co-authored-by: Alexander Theißen <alex.theissen@me.com >
* Address @HCastano's comments
* Update seal_set_code_hash comment
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com >
* Move set_code_hash after delegate_call
* Move function to the bottom
* Moved and changed banchmark, added verify block
* Bring back previous benchmark
* Remove skip_meta for seal_set_code_hash
* Bring back skip_meta for seal_set_storage_per_new_kb
* Apply weights
Co-authored-by: Alexander Theißen <alex.theissen@me.com >
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com >
2022-02-11 07:46:51 +00:00
83eed8018b
pallet-staking: Add extrinsic force_apply_min_commission ( #10786 )
...
* pallet-staking: Add extrinsic `force_apply_min_commission`
* Add benchmarks
* cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* Bound iteration by max_validator_count
* cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* Only apply to 1 validator
* Update doc comments
* Uncomment tests
* cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* Accept signed origins
* cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* Remove contains_key check
* Add test for try_mutate_exists
* Impove try_mutate_exists docs
* Delete redundant try_mutate_exists tests;
* Delete residual from removed test
* cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_staking --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/staking/src/weights.rs --template=./.maintain/frame-weight-template.hbs
* Return an error when the stash does not exist
* Update try_mutate_exist doc wording
* Update frame/staking/src/pallet/mod.rs
* Apply suggestions from code review
Co-authored-by: Parity Bot <admin@parity.io >
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
2022-02-10 21:22:26 +00:00
20b2bba1cd
UncheckedExtrinsic: Harden decode and clarify EXTRINSIC_FORMAT_VERSION ( #10829 )
...
* UncheckedExtrinsic: Harden decode and clarify `EXTRINSIC_FORMAT_VERSION`
* Apply suggestions from code review
2022-02-10 12:34:35 +00:00
8d783038c8
Allow SetBalance to handle error when trying to kill acount with reference counter. ( #10826 )
...
* bug found
* fix logic
* a little simpler
* add test
2022-02-10 11:08:05 +00:00
Oliver Tale-Yazdi