8e0d01570f
Post-condition checking for some pallets ( #5591 )
...
* add pre/post condition check to elections
* Tests for staking
* Better intersection fn
* Fix build
2020-04-11 13:12:59 +02:00
877a7ab531
Add metrics for the events in the network output channels ( #5597 )
...
* Add metrics for the events in the network output channels
* Documentation fixes
* A couple fixes
* Fix panic at destruction
* Rework for direct Prometheus integration
* Don't lock on the Receiver
* Another review address
* Address review
* Update client/network/src/service/out_events.rs
Co-Authored-By: Max Inden <mail@max-inden.de >
* Fix bad event name
* Fix descriptions
* Fix names
* client/network/service/out_events: Apply remaining suggestions
Co-authored-by: Max Inden <mail@max-inden.de >
2020-04-09 20:30:34 +02:00
effc9bae92
Hide benchmarking CLI behind the feature flag ( #5600 )
...
* Hide benchmarking CLI behind the feature flag
* Add a message
2020-04-09 18:50:47 +02:00
ac9a852028
Update to libp2p 0.18 ( #5602 )
...
* Update to libp2p 0.18
* Update Cargo.lock
* Also bump in browser-utils
2020-04-09 18:41:21 +02:00
98b2f46a89
CI: Release - monitor gitlab pipeline ( #5460 )
...
* Initial commit of gitlab pipeline monitoring
* increase max job time
* Improve debug output
* s/PR/issue/
Co-authored-by: Benjamin Kampmann <ben@parity.io >
2020-04-09 12:58:28 +02:00
40c56deea3
Do not prematurely emit CustomProtocolClosed on connection close. ( #5595 )
2020-04-09 12:41:34 +02:00
7da995214e
Forcing-aware offchain Phragmén. ( #5580 )
...
* Make it force-aware
* Fix merge issues
2020-04-09 11:30:33 +02:00
e7e7e89e71
Collection of enhancement for staking/phragmen. ( #5534 )
...
* Collection of enhancement for staking phragmen.
* Ditch signed extension
* Fix build
* Update frame/staking/src/lib.rs
Co-Authored-By: thiolliere <gui.thiolliere@gmail.com >
* Update frame/staking/src/tests.rs
Co-Authored-By: thiolliere <gui.thiolliere@gmail.com >
* Fix reward limits
* Disallow payout_stakers
* Remove unused import
Co-authored-by: thiolliere <gui.thiolliere@gmail.com >
2020-04-09 11:29:11 +02:00
92b39365e3
Benchmarks now use in-memory db & cache ( #5586 )
...
* in-mem state for benchmarks
* Use caching state
* Update Cargo.lock
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
2020-04-09 11:27:39 +02:00
cebd073649
Report local force-closing connections to Prometheus ( #5575 )
...
* Report local force-closing connections to Prometheus
* Also report ping timeouts separately
* Address concerns of #5571
2020-04-09 11:24:01 +02:00
2faabff007
Fix benchmarks: set cache_size to higher value ( #5585 )
...
* 128 -> 1024
* add trace and set = 512
* fix doc comment
2020-04-09 10:37:26 +02:00
5913969f8d
client/authority-discovery: Terminate when network does ( #5562 )
...
* client/authority-discovery: Add test ensure termination on network termi
* client/authority-discovery: Terminate when network does
When the dht event stream returns Poll::Ready(None) it is likely due to
the network terminating. When the network terminates due to the node
itself shutting down or due to a fatal error, there is no purpose in
continuing to run the authority discovery module.
* client/authority-discovery/src/lib: Apply suggestions
Co-Authored-By: André Silva <123550+andresilva@users.noreply.github.com >
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com >
2020-04-09 10:34:51 +02:00
8576937f44
Move contracts wasm test code into separate files ( #5337 )
...
* Move contracts wasm test code into separate files
* Move crypto_hashes into a separate file
* Load wasm code at runtime
* Move wasm files
* Fix wasm formatting
* Update crypto_hashes file
2020-04-09 00:16:49 +02:00
7e5424ddad
Don't fail the build when no git is found ( #5589 )
2020-04-08 22:20:47 +02:00
7cdfaff12b
Add new RPC method to get the chain type ( #5576 )
...
* Add new RPC method to get the chain type
This adds a new RPC method to get the chain type of the running chain.
The chain type needs to be specified in the chain spec. This should make
it easier for tools/UI to display extra information without needing to
rely on parsing the chain name.
* Update client/rpc-api/src/system/mod.rs
Co-Authored-By: Tomasz Drwięga <tomusdrw@users.noreply.github.com >
* Primitive crate
* Feedback
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com >
2020-04-08 20:41:51 +02:00
1d2cbfbdf9
Update .editorconfig ( #5578 )
2020-04-08 20:11:30 +02:00
0629f999ff
Reuse wasmtime instances, the PR ( #5567 )
...
* Preserve a single wasmtime instance.
* Sketch of wasm instance reusing.
* Refactor and docs.
* Rename state_snapshot to util module.
* Renaming.
* Comments.
* Error handling
* More fixes.
2020-04-08 18:45:25 +02:00
01cb097ab4
Don't always recompile the node binary on cargo run ( #5577 )
...
There was a bug in determining the correct git files that should be
tracked. The ref extracted from `.git/HEAD` pointed to a relative path
and thus could not be found by cargo and resulted in always recompiling
the binary.
2020-04-08 15:05:29 +02:00
0cc2e4df89
Fix #5516 ( #5560 )
...
* Add a failing test
* Make test not freeze
* Fix the bug
* Fix spaces
* Fix tests
* Apply suggestions from code review
Co-Authored-By: Toralf Wittner <tw@dtex.org >
* Make sure test doesn't succeed if nothing happened
* Fix build
* Do the events change
Co-authored-by: Toralf Wittner <tw@dtex.org >
2020-04-08 13:32:22 +02:00
7cc095ec9f
Add verify block to benchmark tests ( #5551 )
...
* Add verify block to benchmarks macro.
* Update all benchmarks.
* Add tests, add params.
* Should panic.
* ups, add closures
* Update tests.rs
* update macro syntax
* Revert benchmark syntax change
* verify only in tests
* Update tests.rs
* Uncomment staking
* Fix tests for benchmark instance
* Add docs
* Update frame/benchmarking/src/lib.rs
* add trace logs to benchmarks
* Verify returns closure
Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com >
2020-04-08 12:55:06 +02:00
c73398ab03
remove flakiness ( #5572 )
2020-04-08 11:49:32 +02:00
762bcbab03
Unsigned Validation best practices ( #5563 )
...
* Configurable Unsigned Priority.
* Use the new builder.
* Fix tests.
* Fix benches.
* Remove unused import.
* Rename for_pallet
2020-04-08 11:17:21 +02:00
571f1daa49
Add more Prometheus metrics ( #5571 )
...
* Add more Prometheus metrics
* Update client/network/src/service.rs
Co-Authored-By: Max Inden <mail@max-inden.de >
* Update client/network/src/service.rs
Co-Authored-By: Max Inden <mail@max-inden.de >
Co-authored-by: Gavin Wood <gavin@parity.io >
Co-authored-by: Max Inden <mail@max-inden.de >
2020-04-08 11:14:35 +02:00
30ae26074c
Refactor SignedExtension ( #5540 )
...
* Refactor SignedExtension
* Move DispatchInfo Associated type to Dispatchable
* Bound Call: Dispatchable
* Pass PostDispatchInfo to post_dispatch
* Pass DispatchInfo by reference to avoid clones
* Whitespace fix
Co-Authored-By: Tomasz Drwięga <tomusdrw@users.noreply.github.com >
* Style changes from code review
Co-Authored-By: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
* Only decalre in test mod to remove warning
* Deduplicate Call definition
* Bound frame_system::trait::Call by Dispatchable
* Introduce DispatchInfoOf type alias
* Whitespace fix from review
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com >
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com >
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
2020-04-08 11:12:09 +02:00
f8c8355ac7
libp2p-next ( #5278 )
...
* Adapt to rust-libp2p#1440.
* Further adapt to libp2p/master.
* Update to libp2p-0.17
* Finishing touches.
* Remove stray TODO.
* Incorporate review feedback.
* Remove unused import.
2020-04-08 09:23:21 +02:00
1a9c0fee30
babe, grandpa: restrict info logging during initial sync ( #5564 )
...
* babe: restrict info logging during initial sync
* grandpa: restrict info logging during initial sync
* grandpa: fix test compilation
* grandpa: remove afg_log macro mod
2020-04-07 22:11:22 +02:00
6a87e1d1af
sc-consensus-manual-seal uses Finalizer trait for finalization instead of Backend. ( #5469 )
...
* manual-seal uses Finalizer trait for finalization instead of Backend
* fix tests
* use Transaction type
* refactor import_queue
* ugh
* line-width
* Update client/consensus/manual-seal/src/lib.rs
Co-Authored-By: Joshy Orndorff <JoshOrndorff@users.noreply.github.com >
* fix tests
* update docs
* Update client/consensus/manual-seal/src/seal_new_block.rs
Co-Authored-By: André Silva <123550+andresilva@users.noreply.github.com >
* Don't auto-finalize on verification
* Explicity don't finalize on import.
Co-authored-by: Joshy Orndorff <JoshOrndorff@users.noreply.github.com >
Co-authored-by: Joshy Orndorff <admin@joshyorndorff.com >
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com >
2020-04-07 20:08:54 +02:00
f202c58bbb
Fix compilation of service metrics on Windows ( #5548 )
...
* Fix compilation of service metrics on Windows
* Fix browser node
* Ahh
* Remove duplicate code...
2020-04-07 19:32:21 +02:00
dcc0a41331
Make application-crypto std feature internal ( #5558 )
...
* Make `application-crypto` `std` feature internal
The macros should not generate code that requires that the calling crate
has a feature with the name `std` defined.
* Use a proper panic!
2020-04-07 19:31:45 +02:00
0253793d90
More emoji ( #5556 )
2020-04-07 11:55:46 +01:00
3da069e359
CLI: refactoring: remove Options from sc_service::Configuration's fields ( #5271 )
...
* WIP
Forked at: d6aa8e954cd6aa8e954cd6aa8e954cd6aa8e954cd6aa8e954cd6aa8e954cd6aa8e954cseunlanlege@gmail.com >
* Fail if using proc_macro and build.rs is not set properly
* Dropped all get_ in front of methods
* Clean-up
* Fixing proc macro missing env var
* Get the configuration inside the Runtime (needed for polkadot)
* Clean-up
* Get is_dev from argument like the others
* Get chain ID instead of chain spec from shared params
* &self is passed to spec_factory/load_spec
* Wrong text
* Fix example
* Officialize macro and made a cool doc
* Renamed spec_factory to load_spec (substrate_cli_configuration)
* Removed not so useful ChainSpec
* Renamed SubstrateCLI to SubstrateCli
* Added changelog for impl_version being full now
* Renamed Runtime to Runner
* Update changelog to show example
* Removed option on database cache size
* WIP
Forked at: d6aa8e954cd6aa8e954cd6aa8e954cd6aa8e954cd6aa8e954cd6aa8e954cd6aa8e954cbkchr@users.noreply.github.com >
* Update client/cli/src/commands/runcmd.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/commands/export_blocks_cmd.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/commands/check_block_cmd.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update bin/node/cli/src/command.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update bin/node/cli/src/command.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/commands/export_blocks_cmd.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Revert "Update client/cli/src/commands/export_blocks_cmd.rs"
This reverts commit 5906776953392c02beac6bc0bf50f8cbe1a12a01.
* Revert "Update client/cli/src/commands/check_block_cmd.rs"
This reverts commit f705f42b7f3d732be001141afee210fe46a1ef47.
* Revert "Update client/cli/src/commands/export_blocks_cmd.rs"
This reverts commit 8d57c0550164449e6eb2d3bacb04c750c714fcea.
* Revert "Update client/cli/src/commands/runcmd.rs"
This reverts commit 93e74cf5d2e1c0dc49cdff8608d59fc40fc59338.
* Revert "Update client/cli/src/commands/runcmd.rs"
This reverts commit 11d527ba345c0d79f0d3b5b071933d95474d0614.
* Update client/cli/src/commands/export_blocks_cmd.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/commands/import_blocks_cmd.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/commands/purge_chain_cmd.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Changed ::sc_cli to $crate in the macro
* fixed tests
* fixed conflicts
* Fixing test
* Update client/cli/src/commands/purge_chain_cmd.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/params/pruning_params.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Remove comment as suggested
* Apply suggestion
* Update client/cli/src/commands/purge_chain_cmd.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/commands/purge_chain_cmd.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/commands/purge_chain_cmd.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update utils/frame/benchmarking-cli/src/command.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/runner.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/runner.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/runner.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/params/pruning_params.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/params/node_key_params.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/params/network_params.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/lib.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/config.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Added doc
* Fixed error introduced after applying suggestion
* Revert "Update client/cli/src/params/pruning_params.rs"
This reverts commit 0574d06a4f1efd86e94c1214420a12e7a4be0099.
* Print error
* Apply suggestions from code review
* Remove useless Results
* Fixed CI failing on polkadot approval
Co-authored-by: Seun Lanlege <seunlanlege@gmail.com >
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
2020-04-07 11:38:07 +02:00
fb9bbf306d
Benchmark Offences Pallet ( #5411 )
...
* Add initial report_ofence bench.
* Remove unused imports
* Style nit
* Add nominators
* Remove logs.
* Nits.
* Add nominators param.
* Reorg, comment.
* Remove whitespaces.
* Apply review suggestion: move benchmark to own crate.
* Remove import.
* Remove line.
* Add feature flag.
* Pass can_report.
* Cleaning up.
* More cleaning
2020-04-07 11:36:57 +02:00
d3cc051419
Generate Unit Tests for Benchmarks ( #5527 )
...
* Update to latest staking
* generate tests for benchmarking
* add tests, fix warnings
* starting on democracy
* impl_benchmark_tests
* Way more readable
* add test feature flag (does this work?)
* Fix `successful_origin` impl
* democracry benchmark tests
* Fix example benchmarks, add tests
* identity benchmark tests
* Update im-online benchmark tests
* try to add session benchmarking tests (problem with mock)
* staking and timestamp
* add test for treasury, issue with dynamic contains
* utility
* Vesting
* test instead of check
* hide until we figure out what is wrong
* add docs
* close code
* Create custom mock for session-pallet-benchmarking
* Use refcell pattern
* make un-pub
* test-linux-stable includes `runtime-benchmarks` feature
* Revert "test-linux-stable includes `runtime-benchmarks` feature"
This reverts commit a2dab38abd18ac3eb8a6220e4a00e687740bd38c.
* run tests in `--release`
* undo balance change
* build wasm
2020-04-07 11:35:00 +02:00
3e9e5e1bac
change (ci): merge check warnings into test linux job ( #5546 )
...
* change (ci): merge check warnings into test linux job
* change (ci): newline doesn't make sense here
2020-04-07 09:25:57 +02:00
64811e4df3
Add call hash as parameters of multisig related event ( #5499 )
...
* Add call hash as parameters of multisig related event
* update docs
2020-04-06 22:45:20 +02:00
8bdf5da0b0
Remove myself. ( #5544 )
2020-04-06 19:57:19 +02:00
dba0fcbaea
Prometheus Metrics: Turn notifications_total counter into notifications_sizes histogram ( #5535 )
...
* Turn notifications_total into notifications_sizes
* Address review
2020-04-06 18:36:46 +02:00
84a9c17b4e
Update Externalities docs ( #5537 )
...
* update externalities docs
* Update primitives/externalities/src/lib.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update primitives/externalities/src/lib.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update primitives/externalities/src/lib.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Update primitives/externalities/src/lib.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
2020-04-06 15:09:49 +02:00
15f8078e1f
Revert "prepopulate CARGO_HOME caches ( #5505 )" ( #5533 )
...
This reverts commit 9dbcb11f66
2020-04-06 10:45:27 +02:00
308dbf1c7a
Make verbosity level mandatory with telemetry opt ( #5057 )
...
* Make verbosity level mandatory instead of defaulting to 0 when using --telemetry-url
* Update README docs
* Change TelemetryError struct to enum
* Return TelemetryParsingError instead of a Boxed dyn error
* Replace spaces by tabs
* Add example of expected format for telemetry-url
* Remove UrlParsingError; Call to_string instead of parse for TelemetryEndpoints url
2020-04-05 14:36:45 +02:00
3420598d0a
Sort members in elections-phragmen genesis ( #5522 )
...
* Sort members in elections-phragmen genesis
* panic if duplicate member
* print duplicate member
2020-04-05 14:28:37 +02:00
abd822692d
Mandatory dispatch class ( #5515 )
...
* Mandatory dispatch class
* Tweaks
* Docs
* Fix test
* Update frame/support/src/weights.rs
Co-Authored-By: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
* Introduce logic that was stated in PR.
* Use
* Docs.
* Fix test
* Fix merge
* Update frame/support/src/weights.rs
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com >
* Fix.
* Fix
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com >
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
2020-04-05 14:27:30 +02:00
392571d78c
Fix Benchmarks to enable batch run ( #5523 )
...
* some fixes
* Update tips benchmark to be resiliant to genesis
* Update Cargo.lock
2020-04-05 14:27:17 +02:00
d155a9d97d
Fix non-linux build of sc-client ( #5524 )
...
* procfs is linux only
* also for the import
* fixup non-linux build
2020-04-04 19:52:19 +02:00
247822bb33
Additional Metrics collected and exposed via prometheus ( #5414 )
...
This PR refactors the metrics measuring and Prometheus exposing entity in sc-service into its own submodule and extends the parameters it exposes by:
- system load average (over one, five and 15min)
- the TCP connection state of the process (lsof), refs #5304
- number of tokio threads
- number of known forks
- counter for items in each unbounded queue (with internal unbounded channels)
- number of file descriptors opened by this process (*nix only at this point)
- number of system threads (*nix only at this point)
refs #4679
Co-authored-by: Max Inden <mail@max-inden.de >
Co-authored-by: Ashley <ashley.ruglys@gmail.com >
2020-04-04 15:13:35 +02:00
6847f8452e
Simple Staking Payouts ( #5406 )
...
* Simple Payouts
* explicit test for out of order claiming
* Add `payout_all` benchmark
* Fix merge
* add docs
* change event to controller
* Fix timestamp test warnings
* Revert "change event to controller"
This reverts commit 5d4a97832d47fe1273602d5410774d5421940c4e.
* Update Reward event doc
* Add "non-production" test
* add unlock chunk to test
* fix merge
* End payout early if no reward points
* payout_validator -> payout_stakers
* bring back payout nominator/validator, but limit their use to before migration era
* Add test for before migration
* New payout works for the era that we migrate
* Fix logic, check that migration era works
* Migrate Era tests (copypasta)
* Move comment
* Add mock back to external functions
* Fixes based on review from gui
* Update Cargo.lock
* Update Cargo.lock
* small docs update
Co-authored-by: joepetrowski <joe@parity.io >
2020-04-04 14:50:08 +02:00
7c0fa83720
EnsureOrigin is a frame abstraction - it should be in frame_support ( #5521 )
...
* EnsureOrigin is a frame abstraction - it should be in frame_support
* Fixes
2020-04-04 12:58:05 +02:00
f0375a858f
support: add lateness trait ( #5519 )
...
* support: add lateness trait
* babe: implement the lateness trait
* babe: add docs about lateness entry lifetime
* babe: don't use option for lateness storage entry
2020-04-04 09:59:15 +02:00
8c03a4fcef
Split the Roles in three types ( #5520 )
...
* Split the Roles bitfield in three
* Forgot to include some changes
* Fix cli test
* More test fixes
* Oh God, merging master broke other tests
* Didn't run the doctests
* Address review
* I'm trying to fix the build blindly because it's taking a good hour to compile on my machine
* Address some review
* Also update the peerset's API to make sense
* Fix peerset tests
* Fix browser node
* client: distinguish between local and network authority
Co-authored-by: André Silva <andre.beat@gmail.com >
2020-04-03 19:08:14 +02:00
9dbcb11f66
prepopulate CARGO_HOME caches ( #5505 )
...
* test (ci): prepopulate caches with debug
* test (ci): error in path
* optimization (ci): CARGO_HOME cache prepopulation
2020-04-03 16:48:07 +02:00
Kian Paimani