Commit Graph
55 Commits
Author SHA1 Message Date
Joshy OrndorffandJoshy Orndorff ec18933384 Remove #[macro_use] annotation from mod service in all nodes. (#2456)
This PR removes `#[macro_use]` from the service module in each of the
Substrate nodes in the repo.

* Parachain Template
* Polkadot Parachain
* Minimal Node
* Node Template
* Kitchen Sink Node

IDK why this annotation was present, maybe from when we had the
`new_partial!` macro?

---------

Co-authored-by: Joshy Orndorff <git-user-email.h0ly5@simplelogin.com>
2023-11-23 00:21:20 +02:00
bdf186870d polkadot-parachain-primitives should not depend on frame-support. (#1897)
This PR does not make any functional changes to the code. Rather, it
restructures the dependency graph.

Before this PR, the crate `polkadot-parachain-primitives` depended
directly on the crate `frame-support`. This is wrong in principal
because a parachain does not necessarily have anything to do with frame.

This dependency was only for the `Weight` type which was just a
re-export from `sp-weights` anyway. So this PR changes the dependency to
be directly on the much lighter `sp-weights`.

---------

Co-authored-by: Joshy Orndorff <git-user-email.h0ly5@simplelogin.com>
Co-authored-by: command-bot <>
2023-10-25 22:32:18 +02:00
Joshy OrndorffandJoshy Orndorff ec9274eea6 remove unnecessary hash string (#1722)
This PR removes some unnecessary `r#`...`#` around a string and the
corresponding comment that it was done because rustfmt wasn't working
for "some reason". It seems to work fine now and clippy prefers it this
way.

---------

Co-authored-by: Joshy Orndorff <git-user-email.h0ly5@simplelogin.com>
2023-09-27 18:48:24 +03:00
Joshy Orndorff f6b982d7bc sc-consensus-slots: rename client -> select_chain (#11375)
* rename `client` -> `select_chain`

* missed one

* `cargo fmt` (only the file I touched)

* Missed another one

* Revert "`cargo fmt` (only the file I touched)"

This reverts commit 96a0c6cd131cdc08013f7ddb9e7bf2af34ae3ee3.

* `cargo fmt` (again) (only the LINES I touched)
2022-05-10 18:18:56 +02:00
Joshy Orndorffandtgmichel 2178cb1939 Manual Seal: Calculate the block's post hash (#10498)
* calculate the post hash

* Add test

Co-authored-by: tgmichel <telmo@purestake.com>
2022-01-10 11:55:05 +00:00
a01004e143 Add vote and seconded events to Democracy pallet. (#10352)
* add the events

* spec_version

* Update bin/node/runtime/src/lib.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

Co-authored-by: Alan Sapede <alan.sapede@gmail.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
2021-11-30 14:02:32 +01:00
Joshy Orndorff bc47cfeefb remove crate visibility limitation (#9565) 2021-08-26 16:24:14 +00:00
Joshy OrndorffandDenis Pisarev 7978b18613 Publish rustdocs to github pages (#562)
* Publish rustdocs to github pages

* @TriplEight 's suggestions from code review

Co-authored-by: Denis Pisarev <denis.pisarev@parity.io>

Co-authored-by: Denis Pisarev <denis.pisarev@parity.io>
2021-08-09 17:00:32 +02:00
Joshy OrndorffandBastian Köcher c8969e1762 Add public accessor for tip amount (#9219)
* Add public accessor for tip amount.

* Update frame/transaction-payment/src/lib.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2021-06-28 22:13:19 +02:00
Joshy Orndorff a8c3f11c44 Adds a mock provider for the parachain inherent (#484)
* Bring in code from moonbeam

* move it to mock.rs

* Actually build it 🤦
2021-06-23 10:37:50 +02:00
Joshy Orndorff 5e0f922db4 remove explicit unit return type (#9053) 2021-06-09 14:36:41 +00:00
Joshy OrndorffandBastian Köcher 2641c5b830 Make --collator reusable and imply --validator (#380)
* Reusable RunCmd struct

* wire new run command through service

* Fill in the rest of the methods

* attempt normalization

* Settle on the borrowing approach

* add the normalize call

* bump substrate

* Update client/cli/src/lib.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* Update docs

* Update client/cli/src/lib.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2021-05-06 14:38:25 +00:00
Joshy OrndorffandBastian Köcher 196b9a94c6 Expose paras config in rococo runtime (#2886)
* Add it in rococo runtime

* Add to rococo chain spec

* bump spec version

* Update runtime/rococo/src/lib.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2021-04-15 00:43:19 +02:00
Joshy Orndorff 2516e06927 Make set_validation_data public (#399) 2021-04-13 21:20:10 +02:00
Joshy Orndorff 849b5117f9 rename EPOCH_DURATION_IN_BLOCKS -> EPOCH_DURATION_IN_SLOTS (#2674) 2021-04-12 14:40:44 +00:00
Joshy Orndorff 2c771e2cae Minor fixes and clarifications (#333) 2021-02-18 18:55:43 +01:00
Joshy Orndorff 73386a4215 better formatting for doc comments (#8030) 2021-02-02 16:57:31 +00:00
Joshy OrndorffandBastian Köcher 04704ceee4 Clarify and expand ProvideInherent docs (#7941)
* Clarify and expand docs.

* clarify that a pallet can verify an inherent without providing one.

* Clarify what calls `is_inherent_required`.

* caution and link to issue

* typo

* Apply suggestions from code review

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2021-01-28 19:44:56 +00:00
Joshy Orndorff ed8fc4f4a3 remove borrowed box (#272) 2021-01-05 22:34:57 +01:00
Joshy Orndorff dd8e7587cb Lazily evaluate error string (#7802) 2020-12-29 07:51:17 +00:00
Joshy Orndorff cd15cbe605 Add workshop link to readme (#211) 2020-09-08 11:54:35 +02:00
Joshy OrndorffandDan Forbes aba092e8be Node template complete import pipeline (#7014)
* Use complete import pipeline

* Line length

Co-authored-by: Dan Forbes <dan@danforbes.dev>
2020-09-07 12:15:01 +02:00
Joshy Orndorff a936771c0f Update pinned wasm-bindgen dependency (#6861)
* Update dependency.

* Update readme docs

* update python webserver command
2020-08-10 07:52:21 +00:00
d8aabf0c32 Separate ParachainId injection to its own pallet (#183)
* Separate paraid injection to own pallet

* Move token dealer to a crate

* Move to rococo-parachains

* Remove parameter_types hack

* Fix chainspec

* fix build

* remove commented code

* Update contracts runtime to match other runtime

* Apply suggestions from code review

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* Alphebetize workspace members

* Parachain info to own crate

* prune system = frame_system

Co-authored-by: Ricardo Rius <ricardo@parity.io>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2020-08-07 21:52:15 +02:00
Joshy Orndorff e4280858dc De-alias pallets in node template runtime (#6836)
* dealias pallets

* Restore accidentally deleted code blocks
2020-08-06 21:23:31 +02:00
Joshy Orndorff 07c56a9be9 De-alias frame_system in node template runtime (#6829)
* de-alias frame_system in node template

* Fix line length

* Fix chainspec
2020-08-06 16:18:35 +00:00
Joshy Orndorff 071d7a11c4 Allow custom polkadot chainspec. (#122) 2020-06-18 09:54:47 +02:00
Joshy OrndorffandBastian Köcher 518348b88d impl FindAuthor<T::AuthorityId> for Aura (#6205)
* Something compiles

* compiles _and_ maintains old version

* Comments

* try to pass CI

* Update frame/aura/src/lib.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* Update frame/aura/src/lib.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2020-06-02 15:21:12 +02:00
Joshy Orndorff 1d8ddd7a98 Make GrandpaBlockImport public (#6068) 2020-05-18 20:13:30 +00:00
Joshy Orndorff 2ae3fe121c Fix light clients in manual seal nodes (#5955)
* WIP

* WIP
2020-05-08 11:18:32 +02:00
Joshy Orndorff c844ba9163 Remove extra backtick in comments (#5898) 2020-05-05 15:35:56 +02:00
Joshy Orndorff 313288208d Update docs for BeforeBestBlockBy (#5849) 2020-04-30 16:07:25 +01:00
Joshy Orndorff a08bf89662 Support Justification and FinalityProof import in pow import queue. (#5781) 2020-04-25 10:57:06 +00:00
Joshy Orndorff 723ee05a73 Move AuraPair import to new_full_start! macro (#5709) 2020-04-21 10:52:34 +02:00
Joshy Orndorff d05dc090a8 Revise docs on randomness (#5497)
* Initial attempt to revise docs.

* Remove incorrect warning from Babe pallet

* Add more hints that collective flip is for low security
2020-04-19 11:57:16 +02:00
Joshy Orndorff a42d87483c remove rustdocs script (#5675) 2020-04-17 10:35:50 +02:00
Joshy Orndorff 7983a8184b Remove unused dependency on safe-mix (#5495) 2020-04-03 01:25:13 +02:00
Joshy Orndorff 0505e93733 Remove package aliases from node template (#5389)
* delias outer node template

* dealias pallet template

* Fix mock

* attempt to fix warning

* Revert "attempt to fix warning"

This reverts commit 3d39142b877fb7ae2bd9bd0b31442a00d4c8f0bf.

* Add call to test interface.
2020-03-25 19:44:13 +01:00
Joshy Orndorff 91c1e1a85e Increase node template max block weight (#5171) 2020-03-06 18:32:00 +01:00
Joshy Orndorff 991911ec4c Minor fix to readme instructions (#51) 2020-02-03 09:36:33 +01:00
Joshy Orndorff e0ac148444 Add decl_error to template module (#4743)
* Update template to use decl_error

* Test for error on template

* Comments

* Reorder decl_* blocks: storage, event, error, module

* Remove TODOs

* Clarify comment on type Error = Error<T>
2020-01-28 19:33:50 +01:00
Joshy Orndorffandthiolliere 957ea8ba46 Remove references to frame_consensus from docs (#4582)
* Simply remove references to frame_consensus

* More thorough re-write

* Update frame/session/src/lib.rs

Co-Authored-By: thiolliere <gui.thiolliere@gmail.com>

* on_initialize is not dispatchable

* Attempt to fix test.

* Actually fix test.

* Actually ran passing test.

* Update frame/session/src/lib.rs

Co-Authored-By: thiolliere <gui.thiolliere@gmail.com>

Co-authored-by: thiolliere <gui.thiolliere@gmail.com>
2020-01-27 17:14:10 +01:00
Joshy Orndorff 6b57c7181f typo: lead -> leave (#4546) 2020-01-06 20:55:39 +01:00
Joshy Orndorff f6cbf4421f Rename ChainSpec field (#4471)
* initial rename

* nitpick: add space in "chain spec"

* Add comment to client spec.
2019-12-20 21:50:18 +01:00
Joshy Orndorff 512c86a72f Fix typo: to -> from (#4163) 2019-11-21 00:22:05 +01:00
Joshy Orndorff 1789ed732f Fix minor comment typo "do" -> "do not" (#4054) 2019-11-08 21:37:38 +01:00
Joshy Orndorff 44696f46c3 Change dependency name "node-template-runtime" -> "runtime" (#3910) 2019-10-25 06:25:33 +02:00
Joshy Orndorff 99da0232ee Grammar (#3754) 2019-10-04 09:12:06 +02:00
Joshy Orndorff 210290f8ca Remove unused key types sr25 and ed25 (#3659)
* Remove unused key types sr25 and ed25.

* Restore in specific files to fix build.

* Fix runtime tests

* Fix keystore test

* Revert typo

* Move keytypes to primitives/src/testing.rs

* More missed items.

* Getting close now.

* Fix example in documentation.

* Update core/application-crypto/src/ed25519.rs

* Update core/application-crypto/src/sr25519.rs

* Bump impl version.
2019-09-21 12:48:03 +08:00
Joshy Orndorff ea8831b15f Minor typo fix. bu -> by (#3402) 2019-08-14 18:33:50 +02:00
Joshy Orndorff eac4ed412e Move Council and Democracy logic to block initialization (#2806)
* s/on_finalize/on_initialize

* bump impl_version
2019-06-06 22:16:24 +02:00
Joshy Orndorff 9700029203 WIP: Treasury reference docs (#2557)
* Some initial re-organization.

* Text looking decent. No Example Yet.

* Clarify that using block rewards is jsut an example.

* Clarify the purpose of OnDilution.

* Update lib.rs
2019-06-04 18:48:50 +02:00
Joshy Orndorff 5d205935a0 Typo fix Substate -> Substrate (#2754) 2019-06-01 06:50:05 +02:00
Joshy Orndorff 3b534c1cc6 Changed all occurences of referendums to referenda. Updated spec versions. (#2545) 2019-05-13 11:37:47 +02:00
Joshy Orndorff 5d82cf243e Fix minor error in chain-spec generation command in readme (#1644)
* Fix minor error in chainspec generation command in readme

* Fixed up remaining typo
2019-01-31 22:36:55 +01:00