Commit Graph
14 Commits
Author SHA1 Message Date
Javier Bullrich e41a0e728b upgraded review bot to 2.3.0 (#2549)
Upgraded to version 2.3.0 which includes:
- paritytech/review-bot#103
- paritytech/review-bot#102
2023-11-30 09:03:47 +01:00
Javier Bullrich 0317501758 Decomissioned PR-Custom-Review (#2503)
This PR decomissions
[`PR-Custom-Review`](https://github.com/paritytech/pr-custom-review) in
replacement for
[`Review-bot`](https://github.com/paritytech/review-bot).
2023-11-27 12:33:36 +02:00
Javier BullrichandChevdor f5ad32e406 added action to pass review bot on merge queue (#2414)
This action will trigger when a merge queue is created and will add a
positive status check under the `review-bot` account, allowing the PR to
pass the required check for the merge.

---------

Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
2023-11-21 17:49:47 +02:00
Javier Bullrich 8d2637905b review-bot: trigger only on review approvals (#2289)
Moved the review event of review-bot to only be triggered in approvals.

Because we only update the required reviews when someone approves, this
will stop the bot from immediately requesting a new review when someone
comments or request changes as they should have been already notified in
the first batch.
2023-11-13 22:17:36 +02:00
Javier Bullrich e9987401f3 skip trigger for review bot on draft PRs (#2145)
Added if condition on review-bot's trigger so it does not trigger in
`draft` PRs.
2023-11-03 13:43:29 +01:00
Javier Bullrich b2bb8cbcf3 review-bot: prevent request review of core-devs (#2121)
This will remove `core-devs` from being required reviewers of PRs,
2023-11-01 16:16:13 +01:00
Javier Bullrich 9ca267328e upgraded review-bot to 2.2.0 (#2097)
This version includes paritytech/review-bot#97 which can assign
reviewers.

It will be the final step required to replace PRCR.

It also moves the secrets to the environment master.
2023-11-01 12:28:16 +01:00
Javier Bullrich 1cf7d3aafa upgraded review bot to v2.1.0 (#1908)
Upgraded to version 2.1.0 which has paritytech/review-bot#94, a change
in the logic of the action to overcome some problems with permissions
coming from PRs from forks

For this, we needed to divide the actions into two files:
- A first action that triggers on PRs and reviews and uploads the PR
number.
- A second action which is triggered under the completion of the first
one and runs as the action normally runs (but won't have any problems
regarding permissions because it is triggered from the master branch)
2023-10-18 14:04:39 +02:00
Javier Bullrich cd076d7044 Upgraded review-bot to version 2.0.1 (#1784)
## [Updated review bot
version](https://github.com/paritytech/polkadot-sdk/commit/677610ba330a8e03f24b46889787e0475f354954)

updated version to version `2.0.1` which contains
https://github.com/paritytech/review-bot/pull/90, a fix for the team
members not being fetch in its totality.

## [Updated review-bot.yml minApprovals
convention](https://github.com/paritytech/polkadot-sdk/commit/b1446832ddd14f55b2720a65b0ff86b139999419)

Renamed `min_approvals` to `minApprovals`. A breaking change in
https://github.com/paritytech/review-bot/pull/86 which was done to
standarize all the cases (so now everything is camelCase)
2023-10-04 10:07:20 +03:00
Javier Bullrich 4384c613af Added review-bot to fine tune review requirements (#1673)
Created a Github Action that uses the [Review-Bot
app](https://github.com/paritytech/review-bot) to require more fine
tuned requirements to review pull requests before allowing the PR to be
merged.

This uses
[`pull_request_target`](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target)
for the event, not `pull_request`. This is a security measure so that an
attacker doesn’t have access to the secrets.

All the rules have been copied from the original
`.github/pr-custom-review.yml` file.

I want to clarify, this particular commit is **not intended to replace
PRCR yet**.

# Advantages it brings over `PRCR`

Most of the features available in `PRCR` have been duplicated and
enhanced. For a complete detailed write up, please see:
- paritytech/pr-custom-review#114 -> Proposal for the rewrite
- [Review Bot
Documentation](https://github.com/paritytech/review-bot/blob/main/README.md)

The most important features are:
- `include` and `exclude` fields now accept an array, making it easier
to read the regular expressions.
- Ability to skip a rule
- We can set that PRs coming from a particular user or team will cause
the rule to be skipped.
- This is used in the `Audit rule`, which was requested by
@the-right-joyce.
  - This resolves paritytech/pr-custom-review#136
- Ability to request fellows instead of teams
- As requested in polkadot-fellows/runtimes#7, this bot has the ability
to request fellows by rank instead of users.
- We currently have polkadot-fellows/runtimes#31 which is using that
feature.

Aside from all the rules available in `PRCR` I have added a particular
rule to lock the review-bot files and require a review from the
`locks-review` team, the @paritytech/ci team and the
@paritytech/opstooling team to ensure that the file has been written
correctly.

## Next steps

The next steps will consist on paritytech/review-bot#53, once this issue
has been resolved, and `review-bot` has worked without any issues on
this repository for a while, we will upgrade it to be able to fully
replace `PRCR`.
2023-09-28 13:59:35 +03:00
Javier Bullrich 6bb9ad4b1a PRCR - temporary disabled Audit rule (#1239)
@the-right-joyce has requested to disable the Audit rule until we can fix the problem that it always request reviewers (even if the user belongs to the `prevent-review-request` field.
2023-08-29 18:49:00 +03:00
Javier Bullrich 70ab64bd15 PRCR - Reduced required reviews for srlabs (#1203)
As requested by @the-right-joyce and @louismerlin, the amount of required reviews from the `srlabs` team has been reduced to 1.

See related discussion: https://github.com/paritytech/pr-custom-review/issues/136#issuecomment-1695262664
2023-08-28 12:25:16 +02:00
Javier Bullrich 1c5729c2de fixed one member of two teams prs counting individually (#2770)
Fixed the problem that, if a member of two of the required teams reviews a Pr that belongs to `^parachains/runtimes/assets/(asset-hub-kusama|asset-hub-polkadot)/src/[^/]+\.rs$|^parachains/runtimes/bridge-hubs/(bridge-hub-kusama|bridge-hub-polkadot)/src/[^/]+\.rs$|^parachains/runtimes/collectives/collectives-polkadot/src/[^/]+\.rs$|^parachains/common/src/[^/]+\.rs$` it won't count as enough reviews.

By changing the `all_distinct` to `all` this will allow one member of both teams to fulfill the requirements for the PR
2023-06-22 17:01:57 +02:00
Javier Bullrich e15776146e fixed one member of two teams prs counting individually (#7398) 2023-06-22 10:19:36 +00:00