Commit Graph

3877 Commits

Author SHA1 Message Date
Jon Häggblad b99033368b Fix minor clippy lints in grandpa (#5988)
* grandpa: fix clippy lints about identity conversions

* grandpa: fix clippy lints about unwrap_or_default

* grandpa: fix clippy lints about explicit return

* grandpa: fix clippy lints about unnecessary intermediary

* grandpa: fix clippy lints about to_string

* grandpa: fix clippy lints about unused imports

* grandpa: fix clippy lints about increments

* grandpa: fix clippy lints about unnecessary matches

* grandpa: fix clippy lints about struct arguments

* Fix clippy::redundant_clone

* Fix clippy::clone_on_copy

* Fix clippy::or_fun_call

* Fix clippy::identity_conversion
2020-05-13 17:40:52 +01:00
Pierre Krieger 10492c0689 Add mitigation for the state inconsistency issue (#5996)
* Add mitigation for the state inconsistency issue

* Add logging
2020-05-13 14:54:59 +02:00
Rakan Alhneiti eb344a1739 Add CRYPTO_ID to AppKey (#6011) 2020-05-13 14:26:31 +02:00
Bastian Köcher 7b19d3c4ce Give more meaningful error on missing feature when opening a db (#5999) 2020-05-13 11:40:10 +01:00
Igor Żuk eadf28881d Monitor transactions rejected from the pool as invalid (#5992) 2020-05-13 12:02:14 +02:00
Alexander Theißen 8110205820 Fix gitlab line-width CI check (#5994)
* Run script in strict mode

* Add proper seperator between revision and file

* Fix copy paste error

* Do not repeat limit number in error text

* Fix bad revision error

* Do not mask pipe errors

* Fix typo

* Remove unnecessary ... syntax

* Do not fetch all commits of master

* Fetching one commit is enough
2020-05-13 10:47:27 +02:00
joe petrowski b718c45dbd Change BlockHashCount Parameter in Node/Node Template (#5990)
* change BlockHashCount param

* fix test and lock
2020-05-13 10:46:39 +02:00
Bastian Köcher e4edd502bf Only send last finalized block to telemetry (#6003)
Instead of informing the telemetry about each block that is finalized,
we only need to send the last finalized block. This removes log spam on
initial sync.
2020-05-12 22:08:24 +01:00
Paweł Nguyen 9a163aae52 Fix minor typos in im-online documentation (#5997)
* Fix minor typos on im-online documentation

* Update frame/im-online/src/lib.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2020-05-12 21:58:27 +02:00
Pierre Krieger 0a11c48aa1 Turn an error! into a debug! (#6000) 2020-05-12 19:22:41 +02:00
Max Inden 1ede6d1e36 client/network: Remove default Kademlia DHT in favor of per protocol DHT (#5993)
Substrate was previously running both a chain specific Kademlia DHT as
well as the `/ipfs/kad/1.0.0` Kademlia DHT for backwards compatibility.
(See 4db45a8 for details.)

With the end of the transition period this commit removes the former
only leaving the latter and thus preventing the discovery of
incompatible nodes via Kademlia.
2020-05-12 19:07:36 +02:00
Pierre Krieger 9220bdf361 Spawn the network worker with spawn_blocking (#5909)
* Spawn the network worker with spawn_blocking

* Some comment adjustments

* Fix shutdown not working
2020-05-12 17:12:32 +02:00
Pierre Krieger b4b1293c78 Restore the reputation penalty for timeouts (#5984) 2020-05-12 17:08:05 +02:00
Svyatoslav Nikolsky 246f7ae368 get tx_hashes from watcher (#5981) 2020-05-12 15:46:05 +02:00
André Silva c91e681db2 babe: minor rpc nits (#5974)
* babe: fix formatting

* babe: re-use same epoch data in epoch_authorship rpc method
2020-05-12 15:18:15 +02:00
Ashley 3a8b40ebda Update and pin node-browser-testing wasm-bindgen version (#5987) 2020-05-12 15:16:07 +02:00
André Silva ab208837fa grandpa: missing equivocation reporting nits (#5953)
* primitives: move reporting key type to common key types

* session: remove useless methods on MembershipProof

* grandpa: remove std special-casing when checking signatures

* grandpa: add some more docs

* grandpa: use proper error types rather than strings
2020-05-12 12:17:33 +01:00
André Silva 871761694e grandpa: update to finality-grandpa v0.12.3 (#5972) 2020-05-12 12:16:46 +01:00
Max Inden 1ce85590ff client/finality-granpda/until_imported: Rework pinning (#5983)
An `UntilImported` stream wraps a `Stream` of incoming messages and
waits for blocks those messages are based on before passing the messages
on.

The above `Stream` of incoming messages implements `Unpin`, thus there
is no need to use `pin_project` on the `UntilImported` struct. Instead
one only has to add the `Unpin` trait bound on the `I` trait parameter.
2020-05-12 11:48:28 +01:00
Shawn Tabrizi 6013522ab0 Split Operational and Normal weight (#5954)
* Split operational and normal weight

* Update other parts of the code

* relatively minor changes to add/fix behavior

* Limit reported block weight for fee adjustment

* fix test

* explicit match

* Move common logic out

* Update frame/system/src/lib.rs

Co-authored-by: Gavin Wood <gavin@parity.io>

* API improvement @bkchr

Co-authored-by: Gavin Wood <gavin@parity.io>
2020-05-12 12:18:32 +02:00
Bastian Köcher 22db788c08 Optimize decode_len (#5975)
* Optimize `decode_len`

Instead of reading the full storage value into the runtime, we only read
at maximum `5bytes` from the storage into the runtime. Furthermore this
drops any handling with regards to set default values in
`decl_storage!`. If the value does not exists or the decoding of the
length fails, it will return `None`. To prevent people from messing
stuff up, this feature relies on the `StorageDecodeLength` trait that is
sealed by `frame-support` (aka only implementable inside this crate).

* Some clean ups

* Update frame/support/src/storage/mod.rs

Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>

Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
2020-05-12 12:13:28 +02:00
Pierre Krieger 0690bb51a8 Allow passing multiple --log CLI options (#5982)
* Allow passing multiple --log CLI options

* Comment typo
2020-05-12 11:46:06 +02:00
Bastian Köcher 70923cdf7c Update initialize tests for latest rust stable (#5971)
* Update initialize tests for latest rust stable

* Update more tests

* AHHH

* Fix `runtime-interface` test

* ------------------------______________----------------------

* ...
2020-05-11 23:33:32 +02:00
Jimmy Chu 97259789dd Minor update on example-offchain-worker code and comment (#5970)
* Minor update on example-offchain-worker code and comment

Signed-off-by: Jimmy Chu <jimmychu0807@gmail.com>

* Update frame/system/src/offchain.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2020-05-11 17:44:20 +02:00
Pierre Krieger e5a36c8fa9 Small fix to block response completion reporting (#5967)
* Small fix to block response completion reporting

* while -> if
2020-05-11 17:39:39 +02:00
Rakan Alhneiti 3123622cbe Add crypto identifier to RuntimeAppPublic (#5965)
* Add crypto identifier to RuntimeAppPublic

* Update primitives/application-crypto/src/traits.rs

Co-authored-by: Gavin Wood <github@gavwood.com>

Co-authored-by: Gavin Wood <github@gavwood.com>
2020-05-11 14:32:29 +02:00
Pierre Krieger ed6c5bb190 Properly log when we discard a sync response (#5969) 2020-05-11 14:31:56 +02:00
Denis Pisarev ec4494ef3a hotfix Docker release (#5968) 2020-05-11 12:29:19 +02:00
Jon Häggblad 66931028f4 Don't repeatedly lookup keys in babe_epochAuthorship rpc function (#5962)
* babe: don't repeatedly lookup keys in authorship rpc function

Expose a new function `claim_slot_using_keypars` in Babe so that the `babe_epochAuthorship` can
lookup authorship for all slots in the epoch without repeatedly looking up keys in the keystore.

Time to run the `babe_epochAuthorship` RPC call goes from 7s to 25ms on a local dev chain on my
machine.

* babe: pass reference to slice instead of ref to Vec

* babe: fix bunch of clippy warnings
2020-05-11 10:48:34 +02:00
Kian Paimani b21b70f830 Fix very wrong staking test (#5952)
* fix this damn wrong staking test.

* Update frame/staking/src/tests.rs

* assert on balnce as well

* Make it a bit better.
2020-05-11 10:41:33 +02:00
Nikolay Volf 679c91e18c Refactor network transactions handling (#5939)
* change propagation

* add bound
2020-05-11 10:36:00 +02:00
Alexander Popiak f028c84a5b weight adjustments for identity and timestamp pallets (#5946) 2020-05-11 10:20:46 +02:00
Nikolay Volf 08302bc556 Add database type for import benchmarks (#5959)
* add database type for impot benchmarks

* add backend to name
2020-05-10 13:23:50 +02:00
Jaco Greeff c298b61375 Expose BlockHashCount on system metadata constants (#5960) 2020-05-09 13:44:40 +02:00
Arkadiy Paronyan e0b17dd7a9 Bump wasmtime again (#5950)
* Update wasmtime (#5822)

* update wasmtime

* update tests

* Update client/executor/wasmtime/src/host.rs

Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>

* wip

* use master-candidate

* update with patches

* update versions

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* Bump version

* Added parallel execution test

Co-authored-by: Nikolay Volf <nikvolf@gmail.com>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2020-05-08 22:22:54 +02:00
Joshy Orndorff 2ae3fe121c Fix light clients in manual seal nodes (#5955)
* WIP

* WIP
2020-05-08 11:18:32 +02:00
Wei Tang 9ecc1180fc Remove "simple declaration of the Module type" comments (#5944)
* Remove "simple declaration of the `Module` type" comments

* Bump runtime impl version

* Update bin/node/runtime/src/lib.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2020-05-07 22:10:57 +02:00
Bastian Köcher 6a6f2554b4 Make sure config_mut returns a mutable reference (#5942) 2020-05-07 22:07:46 +02:00
Pierre Krieger a8fac92396 Disconnect node after sync request cancelled (#5945) 2020-05-07 15:07:52 +02:00
thiolliere 0360080126 Fix and add benchs for democracy pallet (#5897)
* fix and add benchs

* Update frame/democracy/src/benchmarking.rs

Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>

* bump spec version

* Revert "bump spec version"

This reverts commit 01233117dee575490bc71a4730cdc4351a4013ad.

Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
2020-05-07 14:52:56 +02:00
Shawn Tabrizi b0d17b02ea Update System Weights (#5888)
* Update system weights

* Use maximum block weight for scheduler

* Update offences to use full block

* Move weight inside if statement

* Add one read to offences `on_initialize`

* Delete factory test

* Revert "Delete factory test"

This reverts commit 8f95aacd63a028ef1b415185b45367b4140d86fd.

* Revert "Add one read to offences `on_initialize`"

This reverts commit 7df7ebc73625ed79b14086f13c247d4058ee87d6.

* Revert "Move weight inside if statement"

This reverts commit 87277d07913a7d1868eeee85ef4673f51ee4013b.

* Revert "Update offences to use full block"

This reverts commit 0bbe0ce18e9419b032157f7d37dea6481078cdc0.

* Use scheduler in Sudo

* Apply suggestions from code review

Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>

* Revert "Use scheduler in Sudo"

This reverts commit 95bd2768dfea100bdf682cf4fe6c0f46e8e1f66e.

* remove max extrinsic weight (it does nothing useful)

* fix tests

* introduce `sudo_unchecked_weight`

* bump spec version

* scheduler 80 percent of maximum

* Update `set_changes_trie_config` weight

* Update bin/node/runtime/src/lib.rs

* Update frame/democracy/src/tests.rs

* Update tests.rs

* update based on feedback

Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
2020-05-07 14:33:33 +02:00
Bastian Köcher 99a80da757 Relase wasm-builder and wasm-builder-runner (#5934) 2020-05-07 14:32:27 +02:00
Bastian Köcher 05cb63dd70 Merge Substrate master before checking Polkadot companion (#5916)
* Merge Substrate master before checking Polkadot companion

* Also merge polkadot/master into the companion pr branch

* Set email and user name
2020-05-07 12:50:25 +02:00
Nikolay Volf ffb2d09aa1 change to vecdeque (#5937) 2020-05-07 12:50:07 +02:00
Arkadiy Paronyan 427c33f16f Use header cache for blockhain cache (#5929) 2020-05-07 12:49:30 +02:00
Bastian Köcher eff1680aed Revert "Update wasmtime (#5822)" (#5935)
This reverts commit e5163380e7.

We found some bugs that we first need to fix.
2020-05-07 11:47:38 +02:00
Shawn Tabrizi d8b7520a90 Extend Schedule Pallet for Root Scheduling/Canceling (#5907)
* Add root dispatch to scheduler

* Move encode operation upwards

* fix benchmark

* extend extrinsics

* add some clarifying comments

* start to add benchmarking

* finish weights

* remove double encode

* bump spec

* Update weights

* more accurate weights

* bump base weight
2020-05-07 11:47:23 +02:00
Shawn Tabrizi a9523dbc37 unify spacing on state trace logs (#5932) 2020-05-07 09:24:07 +02:00
Dan Forbes 848803aba2 Fix docs (#5928)
* Fix docs

* Update frame/support/src/dispatch.rs

Prettier link

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* Update primitives/runtime/src/traits.rs

Prettier link

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2020-05-06 23:22:35 +02:00
Bastian Köcher 7ee35f29dc Make Digest support StorageAppend (#5922)
* Make `Digest` support `StorageAppend`

This adds support for `StorageAppend` to `Digest`. Digest is just a
wrapper around a `Vec` and we abuse the fact that SCALE does not puts
any special marker into the encoding for structs. So, we can just append
to the encoded Digest. A test is added that ensures, if the `Digest`
format ever changes, we remove this optimization.

* Update weight

* Update frame/support/src/storage/mod.rs

Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>

* Update frame/system/src/lib.rs

Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>

Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
2020-05-06 23:16:54 +02:00