947b82df68
Don't panic on a sink error ( #7666 )
2020-12-03 17:11:49 +01:00
2877c038cf
Use block requests to check if block responses are correct ( #7653 )
...
* Use block requests to check if block responses are correct
Before this pr sync relied on recently announced blocks to check if a
given peer response is correct. However this could lead to situations
where we requested a block from a peer and it gave us the requested, but
we rejected the response because this peer never send us an announcement
for the given block. See the added tests for a reproduction of the
problem.
With this pr, we now take the block request to check if a given response
matches the request. A node should not send us a block response
without a request anyway.
Essentially there is still a bug, because as you see in the test, we are
requesting block 2, while we already have this block imported. It even
happens that we request a block from the network that we have authored.
However a fix for this would require some more refactoring of the sync code.
* Revert change
* Give the test a proper name
* Add moar logging
* Move cheaper checks
* Move checks to common place
2020-12-03 15:49:23 +01:00
16a43d9e93
companion for substrate#7474 ( #1985 )
...
* include new parameter in test `Configuration`
* update calls to `init_logger`
* "Update Substrate"
* cargo update -p sp-io
Co-authored-by: Matt <mattrutherford@users.noreply.github.com >
Co-authored-by: parity-processbot <>
2020-12-03 15:32:56 +01:00
56c97ce604
RPC to allow setting the log filter ( #7474 )
...
* Add filter reload handle
* add RPC, move logging module from cli to tracing
* remove dup fn
* working example
* Update client/rpc-api/src/system/mod.rs
Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com >
* Prefer "set" to "reload"
* Re-enable the commented out features of the logger
* Remove duplicate code
* cleanup
* unneeded lvar
* Bump to latest patch release
* Add new CLI option to disable log filter reloading,
Move profiling CLI options to SharedParams
* Apply suggestions from code review
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Applied suggestions from reviews
* Fix calls to init_logger()
* Handle errors when parsing logging directives
* Deny `system_setLogFilter` RPC by default
* One more time
* Don't ignore parse errors for log directives set via CLI or RPC
* Improve docs
* Apply suggestions from code review
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Update client/cli/src/config.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* fix merge errors
* include default directives with system_setLogFilter RPC,
implement system_rawSetLogFilter RPC to exclude defaults
* docs etc...
* update test
* refactor: rename fn
* Add a test for system_set_log_filter – NOTE: the code should likely change to return an error when bad directives are passed
* Update client/cli/src/lib.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Address review grumbles
* Add doc note on panicking behaviour
* print all invalid directives before panic
* change RPCs to: addLogFilter and resetLogFilter
* make CLI log directives default
* add comments
* restore previous behaviour to panic when hard-coded directives are invalid
* change/refactor directive parsing
* fix line width
* add test for log filter reloading
* Apply suggestions from code review
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* finish up suggestions from code review
* improve test
* change expect message
* change fn name
* Apply suggestions from code review
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Apply suggestions from code review
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* add docs, remove unused fn
* propagate Err on invalid log directive
* Update tracing-subscriber version
* Improve docs for `disable_log_reloading` CLI param
Co-authored-by: Matt <mattrutherford@users.noreply.github.com >
Co-authored-by: David <dvdplm@gmail.com >
Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com >
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
2020-12-03 13:17:44 +00:00
f717a20446
Changed map to filter map so that Phragmen ignores empty voters ( #7378 )
...
* Changed map to filter map so that Phragmen ignores empty voters
* Resolve flaws and added test case
* Updated test
2020-12-03 12:44:53 +00:00
3ce406c140
Update ss58 registry for Phala network ( #7654 )
2020-12-03 12:22:03 +01:00
7e83b7a7f2
Refactor StorageInstance trait to be usable more easily ( #7659 )
...
* refactor StorageInstance to be usable without macros
* better description
* update types doc
* Update frame/support/src/traits.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
2020-12-03 10:51:08 +00:00
3f4d405a30
Bump color-eyre from 0.5.8 to 0.5.10 ( #2066 )
...
Bumps [color-eyre](https://github.com/yaahc/color-eyre ) from 0.5.8 to 0.5.10.
- [Release notes](https://github.com/yaahc/color-eyre/releases )
- [Changelog](https://github.com/yaahc/color-eyre/blob/v0.5.10/CHANGELOG.md )
- [Commits](https://github.com/yaahc/color-eyre/compare/v0.5.8...v0.5.10 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-12-03 08:27:29 +01:00
76169aef3d
Bump serde_json from 1.0.59 to 1.0.60 ( #2065 )
...
Bumps [serde_json](https://github.com/serde-rs/json ) from 1.0.59 to 1.0.60.
- [Release notes](https://github.com/serde-rs/json/releases )
- [Commits](https://github.com/serde-rs/json/compare/v1.0.59...v1.0.60 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-12-03 07:25:44 +00:00
c01e7c0aa1
Update lib.rs ( #2064 )
2020-12-03 07:40:14 +01:00
54061cd815
Fix locked ksm in council votes. ( #1832 )
...
* Fix locked ksm in council votes.
* Fix accuracy.
* use exact values.
* Fix build
2020-12-02 19:48:30 +01:00
b149b1fdc0
*: Update to libp2p v0.31.2 ( #7658 )
2020-12-02 17:45:49 +00:00
cb17a8d47f
Companion PR for removing register notif protocol ( #2048 )
...
* Companion PR for removing register notif protocol
* Missing .into()
* "Update Substrate"
Co-authored-by: parity-processbot <>
2020-12-02 17:00:26 +00:00
610585d17f
Remove sc_network::NetworkService::register_notifications_protocol and partially refactor Grandpa tests ( #7646 )
...
* Remove sc_network::NetworkService::register_notifications_protocol
* Missing calls to .into()
* Wrong crate name
* [WIP] Fix Grandpa tests
* One more passing
* One more. Two to go.
* This one was actually already passing 🎉
* Last one compiles
* Progress
* grandpa: fix voter_persists_its_votes test
* Restore other tests
* Try spawn future later
Co-authored-by: André Silva <andrerfosilva@gmail.com >
2020-12-02 16:35:48 +00:00
3761fe3161
Show reputation changes when dropping peer ( #7655 )
...
* Show reputation changes when dropping peer
* Print all
2020-12-02 16:34:05 +00:00
5a97db73fb
Update ( #253 )
2020-12-02 17:16:23 +01:00
9d43568e4e
Use unreleased trybuild to fix CI ( #7656 )
2020-12-02 16:53:44 +01:00
87e0b6fe65
remove unused code ( #2058 )
2020-12-02 14:18:18 +00:00
890ae589d4
Make it possible for the adder collator to calculate any state ( #2056 )
...
* Make it possible for the adder collator to calculate any state
This is very useful for when wanting to have multiple running or when
wanting to restart the collator.
* Update parachain/test-parachains/adder/collator/src/lib.rs
Co-authored-by: Sergei Shulepov <sergei@parity.io >
2020-12-02 14:15:30 +00:00
709f990fb2
be more careful about fusing in select! ( #2052 )
2020-12-02 14:52:51 +01:00
b13052de12
Use correct logging target for network bridge ( #2057 )
2020-12-02 13:00:23 +00:00
26b8dbe120
Bump wasm-bindgen-futures from 0.4.18 to 0.4.19 ( #2054 )
...
Bumps [wasm-bindgen-futures](https://github.com/rustwasm/wasm-bindgen ) from 0.4.18 to 0.4.19.
- [Release notes](https://github.com/rustwasm/wasm-bindgen/releases )
- [Changelog](https://github.com/rustwasm/wasm-bindgen/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rustwasm/wasm-bindgen/commits )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-12-02 08:54:36 +01:00
996219d6ec
Update parachain registration script to new extrinsic ( #252 )
...
* Update parachain registration script to new extrinsic
* Update parachain registration script
2020-12-02 08:53:45 +01:00
9071120de1
guide: Availability Recovery ( #2011 )
...
* expand description
* basics of availability recovery
* finish availability recovery
* fill out missing text
* Update roadmap/implementers-guide/src/node/availability/availability-recovery.md
Co-authored-by: Fedor Sakharov <fedor.sakharov@gmail.com >
* fix signal handling
Co-authored-by: Fedor Sakharov <fedor.sakharov@gmail.com >
2020-12-01 14:58:31 -05:00
b737ebba6d
fork-tree: fix tree rebalancing ( #7616 )
...
* fork-tree: rebalance tree when inserting inner node
* fork-tree: fix tests for new rebalancing behavior
* fork-tree: fix node iterator initial state
* grandpa: fix tests
2020-12-01 18:49:09 +00:00
d5a39dffef
Cadidate selection check assignment ( #2042 )
...
* Cadidate selection check assignment
* Apply suggestions from code review
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com >
* Review fixes
* Punish collator for wrong announcements
* Update node/core/candidate-selection/src/lib.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: Peter Goodspeed-Niklaus <coriolinus@users.noreply.github.com >
2020-12-01 13:43:00 -05:00
6079fabdd3
Remove a stray file. ( #7649 )
2020-12-01 13:40:53 -05:00
f27b7acb8f
Update polkadot to the latest master ( #251 )
...
* update cumulus to latest polkadot
* s/Trait/Config
To be more consistent with the new naming.
* Update Cargo.lock
* fix network tests
2020-12-01 19:21:40 +01:00
917a5cce62
adder-collator cli flags ( #2051 )
...
* Accept --parachain-id in adder-collator
* adder-collator: Support a file chainspec
This change is to make it more similar to what we have in cumlus.
2020-12-01 19:20:20 +01:00
e2b486cfb1
minor fix and improvements on localkeystore ( #7626 )
...
* minor fixes and improvements on localkeystore
* fixing tests
* update docs
2020-12-01 14:35:06 +00:00
e8c43576d4
execute_with_client: add 'static bound for Backend ( #2049 )
...
This is not a big change since the user definition AbstractClient already is 'static.
2020-12-01 14:22:24 +00:00
e0016473a9
remove unused deps pulled by parity-util-mem ( #7635 )
...
* remove unused deps pulled by parity-util-mem
* fix a warning about unused Cargo key
2020-12-01 12:50:27 +00:00
36c11201cc
Bump wasm-bindgen from 0.2.68 to 0.2.69 ( #2044 )
...
Bumps [wasm-bindgen](https://github.com/rustwasm/wasm-bindgen ) from 0.2.68 to 0.2.69.
- [Release notes](https://github.com/rustwasm/wasm-bindgen/releases )
- [Changelog](https://github.com/rustwasm/wasm-bindgen/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rustwasm/wasm-bindgen/compare/0.2.68...0.2.69 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-12-01 13:18:30 +01:00
22a28db957
Fix cargo clippy warning in peerset. ( #7641 )
...
* Fix cargo clippy warning in peerset.
* Update client/peerset/src/lib.rs
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
* Apply suggestions from code review
Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com >
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: Pierre Krieger <pierre.krieger1708@gmail.com >
2020-12-01 10:58:00 +00:00
9d961e2023
Bump structopt from 0.3.20 to 0.3.21 ( #2046 )
...
Bumps [structopt](https://github.com/TeXitoi/structopt ) from 0.3.20 to 0.3.21.
- [Release notes](https://github.com/TeXitoi/structopt/releases )
- [Changelog](https://github.com/TeXitoi/structopt/blob/master/CHANGELOG.md )
- [Commits](https://github.com/TeXitoi/structopt/compare/v0.3.20...v0.3.21 )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-12-01 09:41:36 +01:00
762b4b25d0
Fix CI Link Check ( #7639 )
...
* fix trigger fingers
* more
* Update frame/example-offchain-worker/README.md
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com >
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com >
2020-11-30 22:01:18 +00:00
414acdfc54
small improvements for parachains consensus ( #2040 )
...
* introduce a waiting period before selecting candidates and bitfields
* add network_bridge=debug tracing for rep
* change to 2.5s timeout in proposer
* pass timeout to proposer
* move timeout back to provisioner
* grumbles
* Update node/core/provisioner/src/lib.rs
* Fix nitpicks
* Fix bug
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com >
Co-authored-by: Bastian Köcher <git@kchr.de >
2020-11-30 22:52:30 +01:00
15b0dece54
Renames of Trait to Config in README.md, weight templates and few minor ones ( #7636 )
...
* manual rename
* renamse in README.md
* fix template
2020-11-30 20:33:49 +00:00
0f4395fc44
parachains runtime: configurable maximum validators per core ( #2043 )
...
* parachains runtime: configurable maximum validators per core
* update guide and add test
2020-11-30 20:18:02 +00:00
8081c54428
Update Substrate again ( #2041 )
2020-11-30 19:26:44 +01:00
35efc8e4b0
Fix bad state transition with DisabledPendingEnable+OpenDesiredByRemote ( #7638 )
2020-11-30 17:43:47 +00:00
1008465413
Move candidate validation to the background ( #2028 )
...
* refactor some functions to not rely on `self`
* factor out common elements of seconding and attesting
* Add Spawn to backing FromJob
* do candidate validation in background
* tests
* address grumbles
2020-11-30 17:01:03 +00:00
536dceb4f6
Simplify subsystem jobs ( #2037 )
...
* Simplify subsystem jobs
This pr simplifies the subsystem jobs interface. Instead of requiring an
extra message that is used to signal that a job should be ended, a job
now ends when the receiver returns `None`. Besides that it changes the
interface to enforce that messages to a job provide a relay parent.
* Drop ToJobTrait
* Remove FromJob
We always convert this message to FromJobCommand anyway.
2020-11-30 17:01:26 +01:00
4ccf6672b1
resolve unresolved error nits of #7617 ( #7631 )
...
* handle executor should_panic test better
* Revert "reduce should panic, due to extended error messages"
This reverts commit c0805940184a62cd9302603ad911c3591e70a60c.
* remove excessive constraints
* remove duplicate documentation messages for error variants
* reduce T: constraints to the abs minimum
* whoops
* fewer bounds again
Co-authored-by: Bernhard Schuster <bernhard@parity.io >
2020-11-30 16:53:33 +01:00
2d4aa3a42e
Companion: Rename pallet trait Trait to Config ( #2014 )
...
* rename Trait -> Config
* revert diener changes
* rename HostConfig to ActiveConfig as more meaningful
* fix merge
* "Update Substrate"
* cargo update -p sp-io
Co-authored-by: parity-processbot <>
2020-11-30 15:13:43 +00:00
7df537fcdd
cargo update -p sp-io ( #2038 )
2020-11-30 14:47:23 +00:00
1cbfc9257f
Rename pallet trait Trait to Config ( #7599 )
...
* rename Trait to Config
* add test asserting using Trait is still valid.
* fix ui tests
2020-11-30 14:34:54 +00:00
dd3c84c362
Fix wrong value put for pending_opening ( #7633 )
...
* Fix wrong value put for pending_opening
* Oops, didn't even try compiling it
2020-11-30 15:05:01 +01:00
7753a2250f
sudo_as should return a result (#7620 )
2020-11-30 13:57:15 +01:00
007254c957
Bump console_log from 0.1.2 to 0.2.0 ( #7623 )
...
Bumps [console_log](https://github.com/iamcodemaker/console_log ) from 0.1.2 to 0.2.0.
- [Release notes](https://github.com/iamcodemaker/console_log/releases )
- [Commits](https://github.com/iamcodemaker/console_log/commits )
Signed-off-by: dependabot[bot] <support@github.com >
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-11-30 13:51:54 +01:00
Bastian Köcher