Commit Graph

5239 Commits

Author SHA1 Message Date
Gavin Wood f935dfc1a1 Allow lossless matching for Origin (#8576)
* Allow lossless matching for Origin

Without these changes, it's difficult/impossible to not lose any filters
when making fine-grained matches against origin.

* whilespace

* Apply suggestions from code review

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2021-04-08 20:06:09 +02:00
Vladimir Istyufeev d440ef322b Introduce node-bench-regression-guard to Substrate's pipeline (#8519)
* Integrate `node-bench-regression-guard` into the pipeline

* Apply @TriplEight's review suggestions
2021-04-08 19:14:36 +02:00
Pierre Krieger 1b939bcb53 Check every minute whether authority-discovery key has changed (#8575)
* Check every minute whether authority-discovery key has changed

* Fix test

* Fix comment

* Use HashSet for latest_published_keys

* More fixing

* God I'm tired, sorry
2021-04-08 16:41:23 +00:00
Robert Habermeier 1f67933afc remove real-overseer from polkadot compilation flags (#8560)
* remove real-overseer

* remove unneeded
2021-04-08 15:13:12 +02:00
Kian Paimani 524fc7d500 Add DefaultNoBound (#8542)
* Add DefaultNoBound

* Add tests

* Fix
2021-04-08 11:23:55 +00:00
Shawn Tabrizi c04b44b0a3 Add PoV Tracking to Benchmarking Pipeline (#8559)
* Added a function to estimate proof size for benchmarking

* integrate proof_size into benchmarking pipeline

* Update client/db/src/bench.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* Update client/db/src/bench.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* fix tests

* one more test

* Update bench.rs

* Update utils/frame/benchmarking-cli/src/writer.rs

Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>

* Update utils/frame/benchmarking-cli/src/command.rs

Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>

Co-authored-by: arkpar <arkady.paronyan@gmail.com>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
2021-04-08 12:54:46 +02:00
Falco Hirschenberger e932c3ecd2 Add more asserts and debug_asserts (#8541)
* Add more asserts and debug_asserts

fixing #8106

* Remove assignments

* convert debug_assert to runtime assert
2021-04-07 21:40:28 +00:00
Robert Habermeier a600e278ed Support code blobs compressed with zstd (#8549)
* begin maybe-compressed-blob

* fix build

* implement blob compression / decompression

* add some tests

* decode -> decompress

* decompress code if compressed

* make API of compresseed blob crate take limit as parameter

* use new API in sc-executro

* wasm-builder: compress wasm

* fix typo

* simplify

* address review

* fix wasm_project.rs

* Update primitives/maybe-compressed-blob/Cargo.toml

Co-authored-by: Andronik Ordian <write@reusable.software>

Co-authored-by: Andronik Ordian <write@reusable.software>
2021-04-07 20:44:45 +00:00
Shawn Tabrizi d8c1a1d12b Add an INDEX to the Instance trait (#8555)
* Add an index to the Instance trait

* Update frame/support/procedural/src/storage/instance_trait.rs
2021-04-07 12:58:23 +00:00
Seun Lanlege 1cb3590f49 Clean test runner up (#8485)
* bump scale-codec in test runner

* refactor config

* Update test-utils/test-runner/Cargo.toml

Co-authored-by: Andronik Ordian <write@reusable.software>

* bump cargo.lock

* add reasonable defaults

Co-authored-by: Andronik Ordian <write@reusable.software>
2021-04-07 14:54:31 +02:00
Arkadiy Paronyan e3c1fe299a Drain blocks on peer disconnect (#8553)
* Drain blocks on peer disconnect

* Finish comment

* Fixed test

* Update client/network/src/protocol/sync.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2021-04-07 15:43:24 +03:00
Martin Pugh dd89d994ce Fix monthly tags #2 (#8557)
* fix monthly tags

* explicitly set GITHUB_TOKEN

* debug

* Update monthly-tag.yml

* Revert "debug"

This reverts commit 041735d1e5ee78fbb54a841f8fe87a0ba7f1098b and
9ed60840e1647f4e0a5797776a68f0faa0569713
2021-04-07 13:24:54 +02:00
Martin Pugh 467f42b5b3 fix monthly tags (#8554) 2021-04-07 12:52:02 +02:00
Benjamin Kampmann 58d00df134 Let's put up monthly pre-release tags (#8552)
* trying to monthly tag for the first time
2021-04-07 12:06:39 +02:00
Jonathan Brown 9852077dee Remove node-runtime dependency from node-rpc. (#8539)
* Remove node-runtime dependency from node-rpc.

The node-runtime dependency is not used and increases build times.

* update Cargo.lock
2021-04-07 08:05:24 +00:00
Gavin Wood 25de970ab3 Bump codec. (#8548)
* Bump codec.

* Bump codec-derive

* Remove FullCodec bound on Call
2021-04-06 21:02:15 +02:00
Sergei Shulepov b2a6ad0553 Opt-out from fast instance reuse and foundation for other refactorings (#8394)
* Establish the runtime_blob module

Seed it with the existing contents of the `util` module.

* Port wasmtime mutable globals instrumentation into runtime blob APIs

* Opt-out from fast instance reuse

* Minor clean up

* Spaces

* Docs clean up

* Apply suggestions from code review

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* Factor out the expects

* Fix the suggestion

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2021-04-06 18:21:34 +02:00
Gavin Wood 6a8c6b2b0a Fix account ref-counting in session (#8538)
* Fix account ref-counting in session.

* Avoid needless check

* fix compile

* put back in check and conversion

* Fix test to actually catch this error

Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
2021-04-06 15:57:37 +00:00
Vladimir Istyufeev ca57860a13 Add check --features try-runtime CI job (#8532) 2021-04-06 16:16:11 +03:00
Bastian Köcher ec5c7762a0 Require FullCodec on frame_system::Call (#8540) 2021-04-06 15:08:04 +02:00
Pierre Krieger 29a9ba6346 Don't report confusing unsupported protocol errors (#8482) 2021-04-06 12:35:12 +00:00
Arkadiy Paronyan d51127f956 Revert storage cache optimization (#8535)
* Revert "Fixes `storage_hash` caching issue and enables better caching for Cumulus (#8518)"

This reverts commit 85eef08bf23453a06758acbb4b17068ca982b8a2.

* Fix reverting storage_hash

* Restore test
2021-04-06 13:04:32 +02:00
Alexander Popiak bf8a1d8a1a add more notes on changing epoch duration (#8491)
* add more notes on changing epoch duration

* add note about changing slot duration
2021-04-06 12:09:04 +02:00
Liu-Cheng Xu 00432a5ab7 Add some trivial improvements to primitives runtime (#8528)
* Add some trivial improvements

* Finish primitives/runtime
2021-04-05 20:20:36 +02:00
Pierre Krieger b16bc0552e Clean up log levels in sc_network (#8529)
* Clean up log levels in sc_network

* Fix imports
2021-04-05 18:18:47 +00:00
Pierre Krieger 6092b56dda Adjust number of slots in sync requests channel (#8492) 2021-04-05 18:31:14 +02:00
Kian Paimani 6d26adce01 Add nominators option to chain-spec-builder (#8502)
* Add nominators option to chain-spec-builder

* Update bin/utils/chain-spec-builder/src/main.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2021-04-05 12:30:30 +00:00
Bastian Köcher 4e334f59d6 Use log::error! for bad mandatory (#8521)
To make the life of people easier ;)
2021-04-04 13:42:11 +02:00
Arkadiy Paronyan 1740177462 Fixed restoring state-db journals on startup (#8494)
* Fixed restoring state-db journals on startup

* Improved documentation a bit

* Update client/state-db/src/lib.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2021-04-03 23:49:24 +03:00
Keith Yeung b2db0ff881 Properly declare errors in pallets that use decl_module (#8523)
* Properly declare errors in pallets that use decl_module

* Remove extra error type declaration
2021-04-03 22:06:25 +02:00
Caio 35acdbc16f Pin jsonrpsee (#8524) 2021-04-03 16:34:17 +02:00
Bastian Köcher 4186274ddd Fixes storage_hash caching issue and enables better caching for Cumulus (#8518)
* Fixes `storage_hash` caching issue and enables better caching for Cumulus

There was a caching issue with `storage_hash` that resulted in not
reverting cached storage hashes when required. In Cumulus this resulted
in nodes failing to import new blocks after a runtime upgrade, because
they were using the old runtime version.

Besides that, this pr optimizes for the Cumulus use case. In particular
that we always import blocks first as non-best blocks and enact them
later. In current version of the caching that would mean we would always
throw away the complete cache of the latest imported block. Now, we
always update the cache for the first block of a new block height. This
enables us to use the cache if this block will enacted as best block
later. If there is a fork and that is enacted as best, we revert all the
changes to the cache.

* Apply suggestions from code review

Co-authored-by: Arkadiy Paronyan <arkady.paronyan@gmail.com>

* Indentation

* Update client/db/src/storage_cache.rs

Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>

Co-authored-by: Arkadiy Paronyan <arkady.paronyan@gmail.com>
Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
2021-04-02 23:58:30 +02:00
Andronik Ordian 161ca3aa27 upgrade wasmtime to 0.24.0 (#8356) 2021-04-02 19:50:35 +00:00
Pierre Krieger 1468de6b3e Another tweak to GrandPa warp sync (#8514)
* Another tweak to GrandPa warp sync

* Rename to WarpSyncFragment

* Ensure proof is minimal
2021-04-02 14:40:05 +00:00
Bastian Köcher dcf29a8523 Make SetCode::set_code return a result (#8515) 2021-04-02 01:09:41 +02:00
ferrell-code c90828ee34 tests for assets pallet (#8487)
* tests for assets

* Update frame/assets/src/tests.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* Update frame/assets/src/tests.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

* add force asset status check

* remove TODO

* actually remove TODO

* add force asset status tests

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2021-04-01 23:46:41 +02:00
Pierre Krieger 09aa03e3c5 Add a feedback when response is successfully sent (#8510)
* Add a feedback when response is successfully sent

* Fix gp warp sync
2021-04-01 16:25:37 +00:00
Keith Yeung 1fdc8fa1c1 Add ChildTriePrefixIterator and methods (#8478)
* Make use of PrefixIterator underneath Storage[Key]Iterator

* Add ChildTriePrefixIterator and methods

* Add documentation on ChilTriePrefixIterator fields

* Deprecate Storage[Key]Iterator API instead of removing them

* Allow fetching for the prefix as an option for ChildTriePrefixIterator

* Rename prefix_fetch to fetch_previous_key

* fix implementation + test

* make gitdiff better

* Add test for storage_iter and storage_key_iter

Co-authored-by: thiolliere <gui.thiolliere@gmail.com>
2021-04-01 14:20:43 +00:00
Gavin Wood 643d2b669f Introduce OnSetCode type into system config trait. (#8496)
* Introduce OnSetCode type into system config trait.

* Docs.

* Fixes

* Fixes
2021-04-01 12:20:24 +00:00
André Silva 34458e9b9c grandpa: always store justification for the latest finalized block (#8392)
* grandpa: always store justification for best finalized block

* grandpa-warp-sync: add latest justification when finished proving

* grandpa-warp-sync: change logic for sending best justification when finished

* grandpa: test storing best justification

* grandpa: reorder variants in WarpSyncFinished
2021-04-01 09:42:56 +00:00
Yuanchao Sun 159e7d50bb Expose key_owner(), so other pallets can look up validator ID by the (#8506)
session key.
2021-03-31 21:48:12 +00:00
Arkadiy Paronyan 484a630db9 Fixed sync skipping some block announcements (#8459)
* Fixed sync missing some block announcements

* Apply suggestions from code review

Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>

Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
2021-04-01 00:02:31 +03:00
Andrew Jones 0e6481d01a Migrate pallet-indices to pallet! (#8465)
* tmp add upgrade file

* Migrate pallet-indices to `pallet!`

* Delete temp upgrade file

* Fix some migration errors

* Fix some warnings

* Add serde bound, explicit balance type

* Module -> Pallet
2021-03-31 18:08:28 +00:00
Arkadiy Paronyan d294e51214 Duplicate logging to stdout (#8495)
* Duplicate logging to stdout

* Update client/tracing/src/logging/event_format.rs

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
2021-03-31 13:46:14 +03:00
Arkadiy Paronyan 2ed268286e Fix sync restart (#8497) 2021-03-31 10:28:52 +03:00
André Silva 68d8b810c4 client: fix justifications migration (#8489)
* client: rename variables

* client: fix justifications migration

* client: fix compilation
2021-03-30 11:08:05 +00:00
Kian Paimani 19f9224e5d helper macro to create storage types on the fly (#8456)
* helper macro to create storage types on the fly

* Update frame/support/src/lib.rs

Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>

* update lock

* fix test;

* Fix line width

Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
2021-03-30 09:40:56 +00:00
Bastian Köcher 217c4be226 Make BlockImport and Verifier async (#8472)
* Make grandpa work

* Introduce `SharedData`

* Add test and fix bugs

* Switch to `SharedData`

* Make grandpa tests working

* More Babe work

* Make it async

* Fix fix

* Use `async_trait` in sc-consensus-slots

This makes the code a little bit easier to read and also expresses that
there can always only be one call at a time to `on_slot`.

* Make grandpa tests compile

* More Babe tests work

* Fix network test

* Start fixing service test

* Finish service-test

* Fix sc-consensus-aura

* Fix fix fix

* More fixes

* Make everything compile *yeah*

* Fix build when we have Rust 1.51

* Update client/consensus/common/src/shared_data.rs

Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>

* Update client/consensus/common/src/shared_data.rs

Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>

* Update client/consensus/common/src/shared_data.rs

Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>

* Update client/consensus/common/src/shared_data.rs

Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>

* Update client/consensus/common/src/shared_data.rs

Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>

* Update client/consensus/babe/src/tests.rs

Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>

* Update client/consensus/babe/src/tests.rs

Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>

* Fix warning

Co-authored-by: André Silva <123550+andresilva@users.noreply.github.com>
2021-03-30 09:19:49 +00:00
Bastian Köcher 2998b42311 Get rid of test-helpers feature in sc-consensus-babe (#8486)
This is not really required and having a special `test-helpers` feature
is a bad idea anyway.
2021-03-30 08:10:54 +02:00
Jimmy Chu fb73a4eef6 Enhancement on Substrate Node Template (#8473)
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Co-authored-by: Alexander Popiak <alexander.popiak@parity.io>
2021-03-30 07:47:37 +08:00