mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-07-04 16:17:23 +00:00
9383f7a01a
* split authorities discovery keys for the current and next session * Revert "split authorities discovery keys for the current and next session" This reverts commit 0a40b8b4c14e85d95357a27f6db30199cbe0aa4d. * pallet_authority_discovery: introduce a next_authorities method * address feedback * amend the doccomments
316 lines
9.4 KiB
Rust
316 lines
9.4 KiB
Rust
// This file is part of Substrate.
|
|
|
|
// Copyright (C) 2019-2021 Parity Technologies (UK) Ltd.
|
|
// SPDX-License-Identifier: Apache-2.0
|
|
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
//! # Authority discovery module.
|
|
//!
|
|
//! This module is used by the `client/authority-discovery` and by polkadot's parachain logic
|
|
//! to retrieve the current and the next set of authorities.
|
|
|
|
// Ensure we're `no_std` when compiling for Wasm.
|
|
#![cfg_attr(not(feature = "std"), no_std)]
|
|
|
|
use sp_std::prelude::*;
|
|
use frame_support::{decl_module, decl_storage};
|
|
use sp_authority_discovery::AuthorityId;
|
|
|
|
/// The module's config trait.
|
|
pub trait Config: frame_system::Config + pallet_session::Config {}
|
|
|
|
decl_storage! {
|
|
trait Store for Module<T: Config> as AuthorityDiscovery {
|
|
/// Keys of the current authority set.
|
|
Keys get(fn keys): Vec<AuthorityId>;
|
|
/// Keys of the next authority set.
|
|
NextKeys get(fn next_keys): Vec<AuthorityId>;
|
|
}
|
|
add_extra_genesis {
|
|
config(keys): Vec<AuthorityId>;
|
|
build(|config| Module::<T>::initialize_keys(&config.keys))
|
|
}
|
|
}
|
|
|
|
decl_module! {
|
|
pub struct Module<T: Config> for enum Call where origin: T::Origin {
|
|
}
|
|
}
|
|
|
|
impl<T: Config> Module<T> {
|
|
/// Retrieve authority identifiers of the current and next authority set
|
|
/// sorted and deduplicated.
|
|
pub fn authorities() -> Vec<AuthorityId> {
|
|
let mut keys = Keys::get();
|
|
let next = NextKeys::get();
|
|
|
|
keys.extend(next);
|
|
keys.sort();
|
|
keys.dedup();
|
|
|
|
keys
|
|
}
|
|
|
|
/// Retrieve authority identifiers of the current authority set in the original order.
|
|
pub fn current_authorities() -> Vec<AuthorityId> {
|
|
Keys::get()
|
|
}
|
|
|
|
/// Retrieve authority identifiers of the next authority set in the original order.
|
|
pub fn next_authorities() -> Vec<AuthorityId> {
|
|
NextKeys::get()
|
|
}
|
|
|
|
fn initialize_keys(keys: &[AuthorityId]) {
|
|
if !keys.is_empty() {
|
|
assert!(Keys::get().is_empty(), "Keys are already initialized!");
|
|
Keys::put(keys);
|
|
NextKeys::put(keys);
|
|
}
|
|
}
|
|
}
|
|
|
|
impl<T: Config> sp_runtime::BoundToRuntimeAppPublic for Module<T> {
|
|
type Public = AuthorityId;
|
|
}
|
|
|
|
impl<T: Config> pallet_session::OneSessionHandler<T::AccountId> for Module<T> {
|
|
type Key = AuthorityId;
|
|
|
|
fn on_genesis_session<'a, I: 'a>(authorities: I)
|
|
where
|
|
I: Iterator<Item = (&'a T::AccountId, Self::Key)>,
|
|
{
|
|
Self::initialize_keys(&authorities.map(|x| x.1).collect::<Vec<_>>());
|
|
}
|
|
|
|
fn on_new_session<'a, I: 'a>(changed: bool, validators: I, queued_validators: I)
|
|
where
|
|
I: Iterator<Item = (&'a T::AccountId, Self::Key)>,
|
|
{
|
|
// Remember who the authorities are for the new and next session.
|
|
if changed {
|
|
let keys = validators.map(|x| x.1);
|
|
Keys::put(keys.collect::<Vec<_>>());
|
|
let next_keys = queued_validators.map(|x| x.1);
|
|
NextKeys::put(next_keys.collect::<Vec<_>>());
|
|
}
|
|
}
|
|
|
|
fn on_disabled(_i: usize) {
|
|
// ignore
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
use sp_authority_discovery::AuthorityPair;
|
|
use sp_application_crypto::Pair;
|
|
use sp_core::{crypto::key_types, H256};
|
|
use sp_io::TestExternalities;
|
|
use sp_runtime::{
|
|
testing::{Header, UintAuthorityId}, traits::{ConvertInto, IdentityLookup, OpaqueKeys},
|
|
Perbill, KeyTypeId,
|
|
};
|
|
use frame_support::{impl_outer_origin, parameter_types};
|
|
|
|
type AuthorityDiscovery = Module<Test>;
|
|
|
|
#[derive(Clone, Eq, PartialEq)]
|
|
pub struct Test;
|
|
impl Config for Test {}
|
|
|
|
parameter_types! {
|
|
pub const DisabledValidatorsThreshold: Perbill = Perbill::from_percent(33);
|
|
}
|
|
|
|
impl pallet_session::Config for Test {
|
|
type SessionManager = ();
|
|
type Keys = UintAuthorityId;
|
|
type ShouldEndSession = pallet_session::PeriodicSessions<Period, Offset>;
|
|
type SessionHandler = TestSessionHandler;
|
|
type Event = ();
|
|
type ValidatorId = AuthorityId;
|
|
type ValidatorIdOf = ConvertInto;
|
|
type DisabledValidatorsThreshold = DisabledValidatorsThreshold;
|
|
type NextSessionRotation = pallet_session::PeriodicSessions<Period, Offset>;
|
|
type WeightInfo = ();
|
|
}
|
|
|
|
impl pallet_session::historical::Config for Test {
|
|
type FullIdentification = ();
|
|
type FullIdentificationOf = ();
|
|
}
|
|
|
|
pub type BlockNumber = u64;
|
|
|
|
parameter_types! {
|
|
pub const Period: BlockNumber = 1;
|
|
pub const Offset: BlockNumber = 0;
|
|
pub const UncleGenerations: u64 = 0;
|
|
pub const BlockHashCount: u64 = 250;
|
|
pub BlockWeights: frame_system::limits::BlockWeights =
|
|
frame_system::limits::BlockWeights::simple_max(1024);
|
|
}
|
|
|
|
impl frame_system::Config for Test {
|
|
type BaseCallFilter = ();
|
|
type BlockWeights = ();
|
|
type BlockLength = ();
|
|
type DbWeight = ();
|
|
type Origin = Origin;
|
|
type Index = u64;
|
|
type BlockNumber = BlockNumber;
|
|
type Call = ();
|
|
type Hash = H256;
|
|
type Hashing = ::sp_runtime::traits::BlakeTwo256;
|
|
type AccountId = AuthorityId;
|
|
type Lookup = IdentityLookup<Self::AccountId>;
|
|
type Header = Header;
|
|
type Event = ();
|
|
type BlockHashCount = BlockHashCount;
|
|
type Version = ();
|
|
type PalletInfo = ();
|
|
type AccountData = ();
|
|
type OnNewAccount = ();
|
|
type OnKilledAccount = ();
|
|
type SystemWeightInfo = ();
|
|
type SS58Prefix = ();
|
|
}
|
|
|
|
impl_outer_origin! {
|
|
pub enum Origin for Test where system = frame_system {}
|
|
}
|
|
|
|
pub struct TestSessionHandler;
|
|
impl pallet_session::SessionHandler<AuthorityId> for TestSessionHandler {
|
|
const KEY_TYPE_IDS: &'static [KeyTypeId] = &[key_types::DUMMY];
|
|
|
|
fn on_new_session<Ks: OpaqueKeys>(
|
|
_changed: bool,
|
|
_validators: &[(AuthorityId, Ks)],
|
|
_queued_validators: &[(AuthorityId, Ks)],
|
|
) {
|
|
}
|
|
|
|
fn on_disabled(_validator_index: usize) {}
|
|
|
|
fn on_genesis_session<Ks: OpaqueKeys>(_validators: &[(AuthorityId, Ks)]) {}
|
|
}
|
|
|
|
#[test]
|
|
fn authorities_returns_current_and_next_authority_set() {
|
|
// The whole authority discovery module ignores account ids, but we still need them for
|
|
// `pallet_session::OneSessionHandler::on_new_session`, thus its safe to use the same value
|
|
// everywhere.
|
|
let account_id = AuthorityPair::from_seed_slice(vec![10; 32].as_ref()).unwrap().public();
|
|
|
|
let mut first_authorities: Vec<AuthorityId> = vec![0, 1].into_iter()
|
|
.map(|i| AuthorityPair::from_seed_slice(vec![i; 32].as_ref()).unwrap().public())
|
|
.map(AuthorityId::from)
|
|
.collect();
|
|
|
|
let second_authorities: Vec<AuthorityId> = vec![2, 3].into_iter()
|
|
.map(|i| AuthorityPair::from_seed_slice(vec![i; 32].as_ref()).unwrap().public())
|
|
.map(AuthorityId::from)
|
|
.collect();
|
|
// Needed for `pallet_session::OneSessionHandler::on_new_session`.
|
|
let second_authorities_and_account_ids = second_authorities.clone()
|
|
.into_iter()
|
|
.map(|id| (&account_id, id))
|
|
.collect::<Vec<(&AuthorityId, AuthorityId)> >();
|
|
|
|
let mut third_authorities: Vec<AuthorityId> = vec![4, 5].into_iter()
|
|
.map(|i| AuthorityPair::from_seed_slice(vec![i; 32].as_ref()).unwrap().public())
|
|
.map(AuthorityId::from)
|
|
.collect();
|
|
// Needed for `pallet_session::OneSessionHandler::on_new_session`.
|
|
let third_authorities_and_account_ids = third_authorities.clone()
|
|
.into_iter()
|
|
.map(|id| (&account_id, id))
|
|
.collect::<Vec<(&AuthorityId, AuthorityId)> >();
|
|
|
|
// Build genesis.
|
|
let mut t = frame_system::GenesisConfig::default()
|
|
.build_storage::<Test>()
|
|
.unwrap();
|
|
|
|
GenesisConfig {
|
|
keys: vec![],
|
|
}
|
|
.assimilate_storage::<Test>(&mut t)
|
|
.unwrap();
|
|
|
|
// Create externalities.
|
|
let mut externalities = TestExternalities::new(t);
|
|
|
|
externalities.execute_with(|| {
|
|
use pallet_session::OneSessionHandler;
|
|
|
|
AuthorityDiscovery::on_genesis_session(
|
|
first_authorities.iter().map(|id| (id, id.clone()))
|
|
);
|
|
first_authorities.sort();
|
|
let mut authorities_returned = AuthorityDiscovery::authorities();
|
|
authorities_returned.sort();
|
|
assert_eq!(first_authorities, authorities_returned);
|
|
|
|
// When `changed` set to false, the authority set should not be updated.
|
|
AuthorityDiscovery::on_new_session(
|
|
false,
|
|
second_authorities_and_account_ids.clone().into_iter(),
|
|
third_authorities_and_account_ids.clone().into_iter(),
|
|
);
|
|
let authorities_returned = AuthorityDiscovery::authorities();
|
|
assert_eq!(
|
|
first_authorities,
|
|
authorities_returned,
|
|
"Expected authority set not to change as `changed` was set to false.",
|
|
);
|
|
|
|
// When `changed` set to true, the authority set should be updated.
|
|
AuthorityDiscovery::on_new_session(
|
|
true,
|
|
second_authorities_and_account_ids.into_iter(),
|
|
third_authorities_and_account_ids.clone().into_iter(),
|
|
);
|
|
let mut second_and_third_authorities = second_authorities.iter()
|
|
.chain(third_authorities.iter())
|
|
.cloned()
|
|
.collect::<Vec<AuthorityId>>();
|
|
second_and_third_authorities.sort();
|
|
assert_eq!(
|
|
second_and_third_authorities,
|
|
AuthorityDiscovery::authorities(),
|
|
"Expected authority set to contain both the authorities of the new as well as the \
|
|
next session."
|
|
);
|
|
|
|
// With overlapping authority sets, `authorities()` should return a deduplicated set.
|
|
AuthorityDiscovery::on_new_session(
|
|
true,
|
|
third_authorities_and_account_ids.clone().into_iter(),
|
|
third_authorities_and_account_ids.clone().into_iter(),
|
|
);
|
|
third_authorities.sort();
|
|
assert_eq!(
|
|
third_authorities,
|
|
AuthorityDiscovery::authorities(),
|
|
"Expected authority set to be deduplicated."
|
|
);
|
|
});
|
|
}
|
|
}
|