mirror of
https://github.com/pezkuwichain/pezkuwi-subxt.git
synced 2026-04-26 23:57:56 +00:00
4009148889
* #10576: refactor `sc-utils::notification` and `sc-client-api::notifications`, so that they use common subscribe/unsubscribe routines * Add some docs. Reorganise `sc-utils::notification` * `sc-clent-api::notifications` and `sc-utils::notification` — ensure the SubscriptionGuard is dropped before the Rx-channel * `sc-utils::pubsub::SubscriptionGuard` make it a bit more ergonomic. Let the `Rx` to be put inside of the `SubscriptionGuard`, so that the latter shall guarantee the order: - first unsubscribe; - then drop the `Rx`. * Being less zealous with splitting the modules into little pieces * rework pubsub: the concrete usage should only define a good registry type * sc-client-api::notifications: make it comply with the reworked pubsub * cargo fmt * make sc-client-api tests work * Address the review notes * cargo fmt * Describe the behaviour of pubsub registry * Doc-comments for module `sc-utils::pubsub` * Fix: it used to send notifications regardless of the filter setup during subscription * `sc-client-api::StorageNotifications` the API does not have to require mut-self-reference. As a result `sc-service::Client` does not have to wrap its `storage_notifications` into a Mutex. * cargo fmt * Several changes addressing the notes by @bckhr. - Remove the `impl Default for StorageNotifications<Block>`; - no need for groupping the `remove_from` and `listen_from` into a separate `helpers` module; - remove unnecessary import `use registry::SubscribeOp`. * Add a doc-comment to the `sc-client::notifications::SubscribeOp` * As per @bkchr note on the unproven assertion: behave gracefully upon receiving a duplicate subscription-ID. * sc-utils::pubsub: log when a registry yields an ID that does point to an existing sink * `sc-utils::notifications`: payload materialized lazily * Update Cargo.lock (after adding `log` as a dependency to the `sc-utils`) * `sc-client-api::notifications`: introduce a struct (instead of a type def) for the notification message * Get rid of `sc-utils::pubsub::Channel` trait (instead just use the `sc-utils::mpsc`) * The SubsID is no more generic: the fact it is a `Copy` is known — no need to pass it by ref * sc-utils::pubsub internals do not have to be generic over the channel type * Rename Hub::dispatch into Hub::send * That method was unnecessary (`SubscriberSink::render_notification`) * cargo fmt * No need for a separate UnsubscribeGuard type * Ditch the type-def of SubsID in the sc-utils::pubsub, instead — just use the crate::id_sequence::SeqID * Return the <Registry as Dispatch>::Ret when sending an item * Make the `Hub<M, R>::lock_registry(...)` method more ergonomic * cargo doc links * cargo doc links * Use a simpler name for the type * cargo doc links * Derive `Default` rather than implement it * Derive `Default` rather than implement it * Remove an unnecessary usage of type_name * Define a more cautious order between sinks.remove->registry.unsubscribe and registry.subscribe->sinks.insert * Hub: lock_registry_for_tests->map_registry_for_tests — a safer choice for a public API * Replace Mutex over the shared Registry with a ReentrableMutex+RefCell * sc-utils::pubsub: add tests for a panicking registry * Add the missing copyright headers * Arc<Vec<_>> -> Arc<[_]>
123 lines
3.8 KiB
Rust
123 lines
3.8 KiB
Rust
// This file is part of Substrate.
|
|
|
|
// Copyright (C) 2021-2022 Parity Technologies (UK) Ltd.
|
|
// SPDX-License-Identifier: GPL-3.0-or-later WITH Classpath-exception-2.0
|
|
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
|
|
//! Provides mpsc notification channel that can be instantiated
|
|
//! _after_ it's been shared to the consumer and producers entities.
|
|
//!
|
|
//! Useful when building RPC extensions where, at service definition time, we
|
|
//! don't know whether the specific interface where the RPC extension will be
|
|
//! exposed is safe or not and we want to lazily build the RPC extension
|
|
//! whenever we bind the service to an interface.
|
|
//!
|
|
//! See [`sc-service::builder::RpcExtensionBuilder`] for more details.
|
|
|
|
use futures::stream::{FusedStream, Stream};
|
|
use std::{
|
|
pin::Pin,
|
|
task::{Context, Poll},
|
|
};
|
|
|
|
use crate::pubsub::{Hub, Receiver};
|
|
|
|
mod registry;
|
|
use registry::Registry;
|
|
|
|
#[cfg(test)]
|
|
mod tests;
|
|
|
|
/// Trait used to define the "tracing key" string used to tag
|
|
/// and identify the mpsc channels.
|
|
pub trait TracingKeyStr {
|
|
/// Const `str` representing the "tracing key" used to tag and identify
|
|
/// the mpsc channels owned by the object implemeting this trait.
|
|
const TRACING_KEY: &'static str;
|
|
}
|
|
|
|
/// The receiving half of the notifications channel.
|
|
///
|
|
/// The [`NotificationStream`] entity stores the [`Hub`] so it can be
|
|
/// used to add more subscriptions.
|
|
#[derive(Clone)]
|
|
pub struct NotificationStream<Payload, TK: TracingKeyStr> {
|
|
hub: Hub<Payload, Registry>,
|
|
_pd: std::marker::PhantomData<TK>,
|
|
}
|
|
|
|
/// The receiving half of the notifications channel(s).
|
|
#[derive(Debug)]
|
|
pub struct NotificationReceiver<Payload> {
|
|
receiver: Receiver<Payload, Registry>,
|
|
}
|
|
|
|
/// The sending half of the notifications channel(s).
|
|
pub struct NotificationSender<Payload> {
|
|
hub: Hub<Payload, Registry>,
|
|
}
|
|
|
|
impl<Payload, TK: TracingKeyStr> NotificationStream<Payload, TK> {
|
|
/// Creates a new pair of receiver and sender of `Payload` notifications.
|
|
pub fn channel() -> (NotificationSender<Payload>, Self) {
|
|
let hub = Hub::new(TK::TRACING_KEY);
|
|
let sender = NotificationSender { hub: hub.clone() };
|
|
let receiver = NotificationStream { hub, _pd: Default::default() };
|
|
(sender, receiver)
|
|
}
|
|
|
|
/// Subscribe to a channel through which the generic payload can be received.
|
|
pub fn subscribe(&self) -> NotificationReceiver<Payload> {
|
|
let receiver = self.hub.subscribe(());
|
|
NotificationReceiver { receiver }
|
|
}
|
|
}
|
|
|
|
impl<Payload> NotificationSender<Payload> {
|
|
/// Send out a notification to all subscribers that a new payload is available for a
|
|
/// block.
|
|
pub fn notify<Error>(
|
|
&self,
|
|
payload: impl FnOnce() -> Result<Payload, Error>,
|
|
) -> Result<(), Error>
|
|
where
|
|
Payload: Clone,
|
|
{
|
|
self.hub.send(payload)
|
|
}
|
|
}
|
|
|
|
impl<Payload> Clone for NotificationSender<Payload> {
|
|
fn clone(&self) -> Self {
|
|
Self { hub: self.hub.clone() }
|
|
}
|
|
}
|
|
|
|
impl<Payload> Unpin for NotificationReceiver<Payload> {}
|
|
|
|
impl<Payload> Stream for NotificationReceiver<Payload> {
|
|
type Item = Payload;
|
|
|
|
fn poll_next(self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Option<Payload>> {
|
|
Pin::new(&mut self.get_mut().receiver).poll_next(cx)
|
|
}
|
|
}
|
|
|
|
impl<Payload> FusedStream for NotificationReceiver<Payload> {
|
|
fn is_terminated(&self) -> bool {
|
|
self.receiver.is_terminated()
|
|
}
|
|
}
|